Removing non-required moc includes

2012-01-23 Thread Stephen Kelly
Hi, I wrote a script to remove most of the moc includes from kdelibs and transform the remaining ones from incorrect to correct form (usually from #include "foo.moc" to #include "moc_foo.cpp"). This is part of the work in porting away from the standalone automoc to the CMake built in automoc.

Re: Review Request: Install LibKexiv2Config.cmake

2012-01-23 Thread Yury G. Kudryashov
Le 15 января 2012 15:51:32 Alexander Neundorf a écrit : > On Sunday 15 January 2012, Yury Georgievich Kudryashov wrote: > > > On Jan. 15, 2012, 1:45 p.m., Alexander Neundorf wrote: > > > > IF(WIN32 AND NOT CYGWIN) > > > > > > > > SET(DEF_CMAKEFILES_INSTALL_DIR CMake) > > > > > > > > ELSE() > >

Re: Making writing Config.cmake files easier - updated example

2012-01-23 Thread Yury G. Kudryashov
15 January 2012 20:06:51 Alexander Neundorf written: > Hi, > > I create a new branch ImprovedConfigDotCMakeFile in the kdeexamples > repository, used by the buildsystem/HowToInstallALibrary/ example: > http://quickgit.kde.org/?p=kdeexamples.git&a=tree&h=9c8e84b16079b35f15c50ea0 > 27bbc95bd387bf90&

Re: Removing non-required moc includes

2012-01-23 Thread Pavel Heimlich, a.k.a. hajma
2012/1/23 Stephen Kelly : > > Hi, > > I wrote a script to remove most of the moc includes from kdelibs and > transform the remaining ones from incorrect to correct form (usually from > #include "foo.moc" to #include "moc_foo.cpp"). > > This is part of the work in porting away from the standalone au

Re: Removing non-required moc includes

2012-01-23 Thread Stephen Kelly
Pavel Heimlich, a.k.a. hajma wrote: > 2012/1/23 Stephen Kelly : >> >> Hi, >> >> I wrote a script to remove most of the moc includes from kdelibs and >> transform the remaining ones from incorrect to correct form (usually from >> #include "foo.moc" to #include "moc_foo.cpp"). >> >> This is part of

Re: Removing non-required moc includes

2012-01-23 Thread Andras Mantia
On Monday, January 23, 2012 09:39:07 Stephen Kelly wrote: > Hi, > > I wrote a script to remove most of the moc includes from kdelibs I probably missed something, but why remove them? Wouldn't that mean slower compilation? > and > transform the remaining ones from incorrect to correct form (usua

Re: Review Request: Install LibKexiv2Config.cmake

2012-01-23 Thread Alexander Neundorf
On Sunday 15 January 2012, Yury G. Kudryashov wrote: > Le 15 января 2012 15:51:32 Alexander Neundorf a écrit : > > On Sunday 15 January 2012, Yury Georgievich Kudryashov wrote: > > > > On Jan. 15, 2012, 1:45 p.m., Alexander Neundorf wrote: > > > > > IF(WIN32 AND NOT CYGWIN) > > > > > > > > > >

Re: Removing non-required moc includes

2012-01-23 Thread Alexander Neundorf
On Monday 23 January 2012, Andras Mantia wrote: > On Monday, January 23, 2012 09:39:07 Stephen Kelly wrote: > > Hi, > > > > I wrote a script to remove most of the moc includes from kdelibs > > I probably missed something, but why remove them? Wouldn't that mean slower > compilation? > > > and >

Re: Removing non-required moc includes

2012-01-23 Thread Stephen Kelly
Andras Mantia wrote: > On Monday, January 23, 2012 09:39:07 Stephen Kelly wrote: >> Hi, >> >> I wrote a script to remove most of the moc includes from kdelibs > > I probably missed something, but why remove them? Wouldn't that mean > slower compilation? Not really. The moc files are built toget