qt4 vs qt5 build for dependencies

2013-04-05 Thread David Faure
When I ported attica, soprano, libdbusmenu-qt and other such "kdesupport- level" dependencies to Qt5, I used find_package(Qt5Core QUIET) if (Qt5Core_FOUND) message(STATUS "Building with Qt5 support") ... else() find_package(Qt4 REQUIRED) endif() i.e. use Qt5 if it's in the user's environme

Re: qt4 vs qt5 build for dependencies

2013-04-05 Thread Ben Cooksley
On Fri, Apr 5, 2013 at 10:27 PM, David Faure wrote: > When I ported attica, soprano, libdbusmenu-qt and other such "kdesupport- > level" dependencies to Qt5, I used > > find_package(Qt5Core QUIET) > if (Qt5Core_FOUND) > message(STATUS "Building with Qt5 support") > ... > else() > find_packag

Re: qt4 vs qt5 build for dependencies

2013-04-05 Thread Max Brazhnikov
On Fri, 05 Apr 2013 23:22:09 +1300 Ben Cooksley wrote: > On Fri, Apr 5, 2013 at 10:27 PM, David Faure > wrote: > > When I ported attica, soprano, libdbusmenu-qt and other such "kdesupport- > > level" dependencies to Qt5, I used > > > > find_package(Qt5Core QUIET) > > if (Qt5Core_FOUND) > > mess

Re: Review Request 108268: Use CMake 2.8.9 (as required for kdelibs)

2013-04-05 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108268/#review30466 --- The patch does not apply cleanly anymore. - Albert Astals Cid