----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116733/#review52926 -----------------------------------------------------------
I would also have thought this to be an application. Again: the split between the 3 "include" files here is not arbitrary: it will match what we release, since we said we would release frameworks, workspace, and applications separately, at different times. I'm not sure it has been fully defined which modules goes where, but basically if an application is usable in other workspaces (e.g. gnome, XFCE etc.) then I'm quite sure it belongs in "applications". - David Faure On March 11, 2014, 6:07 p.m., Teo Mrnjavac wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116733/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 6:07 p.m.) > > > Review request for Build System. > > > Repository: kdesrc-build > > > Description > ------- > > Add kwalletmanager module to kf5-workspace-build-include. > > > Diffs > ----- > > kf5-workspace-build-include d3ed2e5567da3c67d2c9ce720ffae05eebe722de > > Diff: https://git.reviewboard.kde.org/r/116733/diff/ > > > Testing > ------- > > Builds fine. > > > Thanks, > > Teo Mrnjavac > >
_______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem
