Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/#review71815 --- modules/ECMAddAppIcon.cmake

Re: substitution for KDE4_ADD_APP_ICON cmake macro

2014-12-11 Thread Ralf Habacker
Am 11.12.2014 um 16:33 schrieb Laurent Navet: > Thanks, > > please add kdeframeworks and extracmakemodules groups to reviewers. see https://git.reviewboard.kde.org/r/121448/ Ralf > > Laurent. > > 2014-12-11 15:20 UTC+01:00, Ralf Habacker : >> Am 02.12.2014 um 15:03 schrieb Laurent Navet: >>> Thanks

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-11 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/ --- (Updated Dez. 11, 2014, 4:40 nachm.) Review request for Extra Cmake Modul

Re: substitution for KDE4_ADD_APP_ICON cmake macro

2014-12-11 Thread Laurent Navet
Thanks, please add kdeframeworks and extracmakemodules groups to reviewers. Laurent. 2014-12-11 15:20 UTC+01:00, Ralf Habacker : > Am 02.12.2014 um 15:03 schrieb Laurent Navet: >> Thanks for your reply and patch on >> >> http://article.gmane.org/gmane.comp.kde.devel.buildsystem/9119/ >> >> unfor

Re: substitution for KDE4_ADD_APP_ICON cmake macro

2014-12-11 Thread Ralf Habacker
Am 02.12.2014 um 15:03 schrieb Laurent Navet: > Thanks for your reply and patch on > > http://article.gmane.org/gmane.comp.kde.devel.buildsystem/9119/ > > unfortunately I can't test it as I have no Windows nor MacOs setup. > Does someone here can test it ? Shouldn't this patch be posted on reviewbo