On Thu, Apr 28, 2016 at 11:32 PM, Aleix Pol <aleix...@kde.org> wrote: > On Thu, Apr 28, 2016 at 8:28 AM, Ben Cooksley <bcooks...@kde.org> wrote: >> On Thu, Apr 28, 2016 at 7:22 AM, Stephen Kelly <steve...@gmail.com> wrote: >>> Ben Cooksley wrote: >>> >>>>> Has this issue been resolved somehow? >>>> >>>> Yes, the fault in Digikam's code has been resolved. >>>> From what I understand it has something to do with some of the more >>>> unusual CMake constructs which Digikam was using (and is a fault the >>>> CMake developers have acknowledged but is apparently rather difficult >>>> to fix) >>> >>> I'm curious, so I looked through some recent digikam commits but didn't find >>> what you are referring to. Can someone point me to more information? >> >> Sure. This appears to be the relevant commit: >> https://quickgit.kde.org/?p=digikam.git&a=commitdiff&h=f6e0fba7025fbbe5f9cd1d4fc8b16f88a5d0928e >> >> If you need more details I'll see what I can find. > > That commit looks wrong, if anything maybe AkonadiContacts should have > become PUBLIC.
From what I understand, AkonadiContacts is fine - the bug is in CMake not passing the targets automagic through the OBJECT construct Digikam uses. > > Aleix Cheers, Ben > _______________________________________________ > Kde-buildsystem mailing list > Kde-buildsystem@kde.org > https://mail.kde.org/mailman/listinfo/kde-buildsystem _______________________________________________ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem