[Differential] [Updated] D3830: Add a new FindGperf module

2016-12-30 Thread ltoscano (Luigi Toscano)
ltoscano added a dependent revision: D3883: Generate gperf output at build time. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks, #buildsystem,

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-30 Thread pino (Pino Toscano)
pino added a comment. In https://phabricator.kde.org/D3830#72502, @rjvbb wrote: > You're still determining the location from the path with this new revision, right? For the input file? Yes. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-30 Thread René J.V. Bertin
rjvbb added a comment. You're still determining the location from the path with this new revision, right? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino,

[Differential] [Updated, 125 lines] D3830: Add a new FindGperf module

2016-12-30 Thread pino (Pino Toscano)
pino updated this revision to Diff 9502. pino added a comment. Typo fix in previous revision. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3830?vs=9499=9502 BRANCH pino-gperf REVISION DETAIL https://phabricator.kde.org/D3830 AFFECTED

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

2016-12-30 Thread Michael Pyne
> On Dec. 30, 2016, 6:39 a.m., Martin Gräßlin wrote: > > Is that enabled by default now? I hope not! This is a completely useless > > warning for all frameworks (as we are not allowed to use override) and even > > more for a legacy code bases. I don't want to have to adjust the cmake in > >

[Differential] [Updated, 125 lines] D3830: Add a new FindGperf module

2016-12-30 Thread pino (Pino Toscano)
pino updated this revision to Diff 9499. pino added a comment. Restricted Application added projects: Frameworks, Buildsystem. Use a full path for the output location. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3830?vs=9408=9499 BRANCH

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

2016-12-30 Thread kfunk (Kevin Funk)
kfunk added a comment. In https://phabricator.kde.org/D3850#72308, @rakuco wrote: > Isn't it better to use `check_cxx_compiler_flag` to see if the flag is supported and enable it in case it is? -fno-operator-names is an ancient compiler flag, supported by GCC since at least 2000

Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

2016-12-30 Thread Martin Gräßlin
> On Dez. 30, 2016, 7:39 vorm., Martin Gräßlin wrote: > > Is that enabled by default now? I hope not! This is a completely useless > > warning for all frameworks (as we are not allowed to use override) and even > > more for a legacy code bases. I don't want to have to adjust the cmake in > >