Re: Review Request 129765: Handle the case of an enum with visibility attributes.

2017-01-04 Thread Stephen Kelly
> On Jan. 4, 2017, 10:11 p.m., Stephen Kelly wrote: > > Hi Shaheed, > > > > Can you also add something to the unit test python code which asserts the > > (not zero) value of an enum with an attribute like this? > > > > Thanks, > > > > Steve. > > Shaheed Haque wrote: > You mean to validat

Re: Review Request 129765: Handle the case of an enum with visibility attributes.

2017-01-04 Thread Shaheed Haque
> On Jan. 4, 2017, 10:11 p.m., Stephen Kelly wrote: > > Hi Shaheed, > > > > Can you also add something to the unit test python code which asserts the > > (not zero) value of an enum with an attribute like this? > > > > Thanks, > > > > Steve. You mean to validate it can be read as expected? O

Re: Review Request 129765: Handle the case of an enum with visibility attributes.

2017-01-04 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129765/#review101803 --- Hi Shaheed, Can you also add something to the unit test pyt

[Differential] [Closed] D3952: Fix message when searching for libclang.

2017-01-04 Thread adridg (Adriaan de Groot)
This revision was automatically updated to reflect the committed changes. Closed by commit R240:738972a9a29a: Fix message when searching for libclang. (authored by adridg). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3952?vs=9694&id=9705 REVISI

[Differential] [Accepted] D3952: Fix message when searching for libclang.

2017-01-04 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH python-message REVISION DETAIL https://phabricator.kde.org/D3952 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Request, 2 lines] D3952: Fix message when searching for libclang.

2017-01-04 Thread adridg (Adriaan de Groot)
adridg created this revision. adridg added reviewers: Frameworks, skelly. Restricted Application added projects: Frameworks, Buildsystem. Restricted Application added a subscriber: Buildsystem. REVISION SUMMARY Cut-and-paste-o from the Python detection code. REPOSITORY R240 Extra CMake Module

[Differential] [Updated] D3826: Detect inotify.

2017-01-04 Thread adridg (Adriaan de Groot)
adridg added a reviewer: Frameworks. adridg added a comment. Forgot to add Frameworks as reviewer in original review. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D3826 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai