Re: Review Request 129724: [frameworks] Enable -Wsuggest-override for g++ >= 5.0.0

2017-01-18 Thread Stephen Kelly
> On Jan. 16, 2017, 8:53 a.m., Kevin Funk wrote: > > @Stephen: Let's re-introduce this patch? Laurent + me have applied > > `Q_DECL_OVERRIDE` everywhere. Do you want to double-check? Sorry, I didn't get pinged by email about this, despite the mention from Albert below. Re-applying this sounds

Re: Review Request 129759: Fix the extraction of parameter initialisation.

2017-01-18 Thread Shaheed Haque
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129759/ --- (Updated Jan. 18, 2017, 12:48 p.m.) Status -- This change has been d

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

2017-01-18 Thread Elvis Angelaccio
elvisangelaccio added a comment. In https://phabricator.kde.org/D3850#72081, @kfunk wrote: > In https://phabricator.kde.org/D3850#72077, @elvisangelaccio wrote: > > > What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like a