dhaumann added a reviewer: alexmerry.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4589
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: gszymaszek, #build_system, #frameworks, alexmerry
Cc: dhaumann
dhaumann added a comment.
Correct is that we want to write
find_package(editorconfig "0.12.0)
i.e., with a version. This is missing in this find module, see the LibGit2
find module. Could you extend this?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator
gszymaszek created this revision.
gszymaszek added reviewers: Build System, Frameworks.
gszymaszek set the repository for this revision to R240 Extra CMake Modules.
gszymaszek added a project: Frameworks.
Restricted Application added a project: Build System.
REVISION SUMMARY
EditorConfig support
shaheed added inline comments.
INLINE COMMENTS
> skelly wrote in sip_generator.py:172
> It was possible to handle exports without looking for the text EXPORT in the
> MACRO NAME. Why is deprecated different?
Because the expansion of the attribute in this case contains not a string, but
a compi
shaheed added inline comments.
INLINE COMMENTS
> skelly wrote in rules_engine.py:494
> Does the docs match the code if you add this here? Why is this in this commit?
Yes. Why not?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4509
EMAIL PREFERENCES
htt
shaheed added a comment.
I think the scope of the changes in this commit are perfectly reasonable. I
don't think it is unreasonable to group them either.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4509
EMAIL PREFERENCES
https://phabricator.kde.org
shaheed added inline comments.
INLINE COMMENTS
> skelly wrote in rules_engine.py:58
> I don't think this should be here.
I disagree. Having this in the code suppresses the false positives which are
caused by the "_" used by gettext.
> skelly wrote in rules_engine.py:704
> I don't think the com
skelly added a comment.
In https://phabricator.kde.org/D4509#85725, @shaheed wrote:
> The PEP-8 changes are some blank line changes.
There is exactly one blank line insertion, and it makes this TypedefRuleDb
documentation inconsistent with, say, the VariableRuleDb, which doesn't h
shaheed added a comment.
The PEP-8 changes are some blank line changes.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4509
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: shaheed, #build_system, #frameworks, skelly
skelly added inline comments.
INLINE COMMENTS
> sip_generator.py:172
> """
> +if member.kind == CursorKind.UNEXPOSED_ATTR and
> text.find("_DEPRECATED") != -1:
> +sip["annotations"].add("Deprecated")
It was possible to handle exports without looking for the text EXP
skelly added inline comments.
INLINE COMMENTS
> rules_engine.py:58
> +# Keep PyCharm happy.
> +_ = _
> +
I don't think this should be here.
> rules_engine.py:494
> nameThe name of the
> typedef.
> +fn_resu
skelly added a comment.
Is anything here actually a PEP 8 fix?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D4509
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: shaheed, #build_system, #frameworks, skelly
Cc: #fram
thomasp reopened this revision.
thomasp added a comment.
This revision is now accepted and ready to land.
Alternative tokens [lex.digraph] are standard c++ and have been since it's
was standardized (and I don't know of any plan to deprecate them). They are a
accessibility feature, since not e
13 matches
Mail list logo
