D14912: Bindings: Make generator forward compatible with Python 3

2018-08-18 Thread Antonio Rojas
arojas added a comment. This adds a new build time dependency to all frameworks which support bindings. Any chance to simply port it to python 3 instead? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks Cc: arojas, kde-framewo

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-18 Thread Stefan Brüns
bruns added a comment. In D14912#311063 , @arojas wrote: > This adds a new build time dependency to all frameworks which support bindings. Any chance to simply port it to python 3 instead? Dropping python2 means dropping support for any d

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-18 Thread Stefan Brüns
bruns added a comment. Another option is to include a wrapper function directly in the code, instead of importing it REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh,

D14908: Bindings: Add support for scoped enums

2018-08-18 Thread Michael Pyne
mpyne added a comment. LGTM but then I don't use the Python bindings. Have you already tried the kcoreaddons build to see if this makes it work where it had failed before? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14908 To: bruns, #frameworks Cc: m

D14908: Bindings: Add support for scoped enums

2018-08-18 Thread Stefan Brüns
bruns added a comment. Compilation succeeds again, and the generated code looks sane. I have not actually tested it, though. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14908 To: bruns, #frameworks Cc: mpyne, kde-frameworks-devel, kde-buildsystem, mi