D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

rjvbb added a comment. This is in fact cmake's fault, or ECM's for not taking a cmake quirk into account. If you add an unknown option then all subsequent tests to see if the compiler supports a given argument will fail because cmake does not take into account which of the options gener

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

aacid added a comment. Oh, Hannah updated the summary, so an unknown option makes visibility stuff fail? Wow Apple really did a bad fork of clang if that's what's happening. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18547 To: vonreth, aacid, a

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

aacid added a comment. You sure about that? AFAICS from https://binary-factory.kde.org/view/MacOS/job/Kate_Release_macos/346/console it's just a warning, otherwise, ninja would stop after the first error, and it continues until a linking failure happens REPOSITORY R240 Extra CMake Modules

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

bcooksley added a comment. This change is somewhat urgent - as can be seen at https://binary-factory.kde.org/view/MacOS/ all Mac builds are currently broken due to this issue. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18547 To: vonreth, aacid, apo

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

rjvbb requested changes to this revision. rjvbb added a comment. This revision now requires changes to proceed. See also https://phabricator.kde.org/D16894 which (initially) aimed to tackle this in a more general fashion. IMHO the way forward (if my proposal is not acceptable) is to repla

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

vonreth added a comment. In D18547#400298 , @aacid wrote: > Why? Why it breaks the cmake macro or why apple clang doesn't support it? The second one I can't answer, for the first, its the same reason why we had to bump the cmake version

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

vonreth edited the summary of this revision. vonreth added reviewers: aacid, apol, dfaure, rjvbb, bcooksley. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18547 To: vonreth, aacid, apol, dfaure, rjvbb, bcooksley Cc: aacid, kde-frameworks-devel, kde-buildsys

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

aacid added a comment. Why? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18547 To: vonreth Cc: aacid, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

vonreth created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vonreth requested review of this revision. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D18547