D19005: android: don't default to gcc anymore

2019-02-18 Thread Volker Krause
vkrause added a comment. In D19005#414313 , @apol wrote: > In D19005#412258 , @vkrause wrote: > > > Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_valu

D18952: new find module for Canberra

2019-02-18 Thread Harald Sitter
sitter updated this revision to Diff 51976. sitter added a comment. fix bad copy paste in compat setup REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18952?vs=51952&id=51976 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18952

D18952: new find module for Canberra

2019-02-18 Thread Harald Sitter
sitter marked 5 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18952 To: sitter, cgiboudeaux Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18952: new find module for Canberra

2019-02-18 Thread Harald Sitter
sitter updated this revision to Diff 51952. sitter added a comment. - pkgconfig is now quiet - variables are now camelcase - old variables are still set for compat - new imported target (also sets pkgconfig's cflags, which I presume is the sane thing to do) - set package description

D19075: Fix FindEGL

2019-02-18 Thread Ben Cooksley
bcooksley added a comment. If someone could please trigger all of the Dependency Builds for FreeBSD once this has been landed that would be appreciated: https://build.kde.org/view/Failing/ REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D