D21381: use org.freedesktop.appstream-glib package to validate appstream data

bcooksley added a comment. Aleix is correct, Flatpak commands are not possible within the CI environment (as Docker is heavily locked down, and the containerisation and other isolation measures that Flatpak tries to take are locked out as a consequence) Not to mention that Flatpak is Linux

D21381: use org.freedesktop.appstream-glib package to validate appstream data

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. How about we test against both? And maybe it should be using `appstream-util validate` instead of forcing it through flatpak? It will make it easier to be able to run it in bui

D21381: use org.freedesktop.appstream-glib package to validate appstream data

ngraham added a reviewer: apol. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21381 To: mgallien, aacid, yurchor, apol Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

kossebau added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:131 > # autostart files (``CONFDIR/autostart``) [``AUTOSTART_INSTALL_DIR``] > +# ``DEBUGCATEGORIESDIR`` > +# kdebugsettings categories files directory > (``DATAROOTDIR/debug-categories5``) Since 5.59.0 Might `LOGGIN

D21313: Create specific directory for kdebugsettings categories file

mlaurent updated this revision to Diff 58604. mlaurent added a comment. Oops indeed I forgot to readd KXMLGUI_INSTALL_DIR Thanks for pointing me it :) REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21313?vs=58454&id=58604 BRANCH add_spec

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien created this revision. mgallien added reviewers: aacid, yurchor. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY should help having the same validation than the

D21313: Create specific directory for kdebugsettings categories file

cgiboudeaux added a comment. In D21313#469311 , @mlaurent wrote: > Ping ? You didn't add "KXMLGUI_INSTALL_DIR)" back to where it belongs afaics. If noone has a better suggestion, we'll go for debug-categories5 REPOSITORY R240 Extra