D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

dfaure added a comment. I wouldn't offer both variants, but rather recommend always adding a hint. At worse that hint can be "See method documentation" or an empty string. I think we're just over-complicating things otherwise, for no actual gain, since providing a hint is good practice

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in ECMGenerateExportHeader.cmake:87 > I'm having trouble parsing the "only" in this sentence. > > `deprecated API only`... that seems redundant, it's only API that gets > deprecated :-) > > Maybe you mean "to disable only at build

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau updated this revision to Diff 65854. kossebau marked 3 inline comments as done. kossebau added a comment. - reword documentation based on dfaure's comments - bump since-version to 5.64.0, as currently targetted introduction version Hope is review can be finished at 5.63 tagging

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

kossebau added a comment. @dfaure Thanks for first in-detail feedback, good to get a feeling this is not totally insane over-engineered stuff to other people'e eyes :) In D23789#528994 , @dfaure wrote: > Great work. Not really easy to grasp