D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

2019-09-30 Thread David Faure
dfaure added a comment. I found confirmation in cmake's Tests/RunCMake/GenerateExportHeader/reference/ $ grep -r LIBSHARED_DEPRECATED\ . | grep -w define ./UNIX_DeprecatedOnly/libshared_export.h:# define LIBSHARED_DEPRECATED __attribute__ ((__deprecated__))

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

2019-09-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D23789#539940 , @dfaure wrote: > I see the theoretical problem, but how could this ever be a problem in practice? > On Unix all compilers support the same syntax (`__attribute__ ((__deprecated__))`), so you'd

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

2019-09-30 Thread David Faure
dfaure added a comment. > Which might be an issue for people who would like to use different compiler on the same system, both building against the same generated export header file. I see the theoretical problem, but how could this ever be a problem in practice? On Unix all compilers

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

2019-09-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. Quick Update (week 40): Locally have added experimental code to even set the proper attribute for GCC compiler, so we get e.g.: /home/koder/Kode/kdegit/kf5/frameworks/kparts/tests/notepad.cpp: In constructor ‘NotepadPart::NotepadPart(QWidget*, QObject*,