D26394: ECMGeneratePriFile: Fix static configurations

2020-02-08 Thread Luca Beltrame
lbeltrame added subscribers: cgiboudeaux, lbeltrame. lbeltrame added a comment. This breaks stuff in PIM: [ 107s] CMake Error at /usr/share/ECM/modules/ECMGeneratePriFile.cmake:183 (get_target_property): [ 107s] get_target_property() called with non-existent target "KF5AlarmCal".

D26394: ECMGeneratePriFile: Fix static configurations

2020-02-08 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > ECMGeneratePriFile.cmake:183 > + set(PRI_TARGET_MODULE_CONFIG "") > + get_target_property(target_type ${EGPF_LIB_NAME} TYPE) > + if (target_type STREQUAL "STATIC_LIBRARY") Hmpf, this adds the firm assumption that EGPF_LIB_NAME actually is a ta

D26394: ECMGeneratePriFile: Fix static configurations

2020-02-08 Thread Friedrich W. H. Kossebau
kossebau added a comment. Pushed a8c3ab79912fcb25d7e59a04c08752a9252a5f08 as hotfix for now. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26394 To: kfunk, dfaure, winterz, vkrause, apol Cc: kossebau, lbeltrame, cgiboudeaux, kde-frameworks-devel, kde-bu

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

2020-02-08 Thread Friedrich W. H. Kossebau
kossebau added a comment. @mlaurent Wasn't there also something which tells kdebugsettings about renamed categories? Is that documented anywhere? Could that be supported by some additional macro or adaption of the existing/new ones? REPOSITORY R240 Extra CMake Modules BRANCH addautomati