davidedmundson added a dependent revision: D28305: Systemd Startup.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D29051
To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencrea
davidedmundson added a dependent revision: D28305: Systemd Startup.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D28355
To: davidedmundson
Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n,
cblack, bencreasy, michaelh, ngraham, bru
kossebau added a comment.
Thanks for the explanation, fear though I am missing some details and thus
have not yet understood the problem and the solution. Not having done much
cross-compilation-library-setups naively I would have thought that when
building a library which uses ECMGeneratePri
kossebau added reviewers: Build System, apol, vkrause, kfunk.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D29096
To: ablu, #build_system, apol, vkrause, kfunk
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack,
bencreasy, michaelh, ngr
kossebau added a reviewer: Build System.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D28355
To: davidedmundson, #build_system
Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n,
cblack, bencreasy, michaelh, ngraham, bruns
ablu added a comment.
> Not having done much cross-compilation-library-setups naively I would have
thought that when building a library which uses ECMGeneratePriFile and
preparing it for cross-compilation, the installation prefix would be hardcoded
into the generated artifacts.. Seems that i
kossebau added a comment.
A bit unsure if the arg name "TEMPLATES" is good, or if perhaps should be
renamed to "INPUT". Just mentioning, not preferring one over the other. So far
have not found existing samples to take as lead for consistent argument naming.
For completeness, would be go
kossebau added a comment.
Any chance for a simple unit test to check the generation does what is
expected (or catches bad input)? :)
INLINE COMMENTS
> ECMGenerateDBusServiceFile.cmake:22
> +# are to be installed in the same directory as the D-Bus daemon. On other
> platforms
> +# must