This revision was automatically updated to reflect the committed changes.
Closed by commit R240:fafbc8cec665: ECMGeneratePriFile: Fix static
configurations (authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26394?vs=72687&id=75155
kfunk created this revision.
kfunk added a reviewer: dfaure.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kfunk requested review of this revision.
REVISION SUMMARY
Populate module_config with staticlib. This is needed for Qt 5.
kfunk added reviewers: winterz, vkrause.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D26394
To: kfunk, dfaure, winterz, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy,
michaelh, ngraham, bruns
kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.
I don't like the hiding of the if-branches as argument to macro. We shouldn't
to this as it makes the code harder to understand.
The general issue with the existing code here is
kfunk requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5865
To: rjvbb, #frameworks, #build_system, cgilles, kfunk
Cc: thiago, kfunk, michaelh, ngraham
kfunk added a comment.
Sorry for being late, but I didn't have time to follow up on this one.
My concerns:
- If you have that option `ON` and all frameworks install into the same
prefix, `prefix.sh` will be overwritten. => Bad.
- I still don't fully see how to adopt the use case ap
kfunk added a comment.
In https://phabricator.kde.org/D9299#179036, @cgiboudeaux wrote:
> In https://phabricator.kde.org/D9299#179035, @cgiboudeaux wrote:
>
> > In https://phabricator.kde.org/D9299#179032, @kfunk wrote:
> >
> > > If we'd name this file somewhat less generic then it
kfunk added a comment.
If we'd name this file somewhat less generic then it could be even installed
by default, no?
I had the scheme of the QNX setup script in my mind:
https://github.com/acklinr/qnx660/blob/master/qnx660-env.sh
Thus: Maybe rename prefix.sh to say 'ecm-env.sh' and
kfunk added inline comments.
INLINE COMMENTS
> sitter wrote in KDEInstallDirs.cmake:699
> From a style perspective, I'd suggest having the prefix.sh live somewhere in
> the installed ECM tree and get copied, rather than maintained as a glorified
> heredoc in the cmake code. That's just a sugges
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
This shouldn't create any troubles with earlier CMake versions.
Also note that we set the same properties unconditionally in newer Qt5 CMake
macros: https://codereview.qt-project.org/#/c/
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:64915e0291cd: ecm_add_test: Use proper path sep on
Windows (authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8979?vs=22863&id=22869
R
kfunk added a reviewer: bcooksley.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8979
To: kfunk, dfaure, cgiboudeaux, bcooksley
Cc: #windows, #frameworks, #build_system
kfunk added a subscriber: Windows.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8979
To: kfunk, dfaure, cgiboudeaux
Cc: #windows, #frameworks, #build_system
kfunk added a reviewer: cgiboudeaux.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8979
To: kfunk, dfaure, cgiboudeaux
Cc: #frameworks, #build_system
kfunk created this revision.
kfunk added a reviewer: dfaure.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
We need to separate paths in environment variables
with a semincolon (;) on Windows
kfunk accepted this revision.
kfunk added a comment.
I like the initiative, +1
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7198
To: dfaure, cgiboudeaux, kfunk
Cc: kfunk, #frameworks, #build_system
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:b99d2d2c5ded: RFC: Make ECMAddTests respect BUILD_TESTING
(authored by kfunk).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7187?vs=17835&id=17858#toc
REPOSITORY
R240 Extra CMake Modules
kfunk added a comment.
In https://phabricator.kde.org/D7187#133497, @kossebau wrote:
> +1 as well. Please also add a note in the API dox what BUILD_TESTING will
do on this macro, so this is not magic behaviour and people can plan with this
(like making sure to not set `target_link_librar
kfunk added a comment.
Guys... no one gave me an "Accepted' yet :)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7187
To: kfunk
Cc: vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system
kfunk added a comment.
In https://phabricator.kde.org/D7187#133358, @elvisangelaccio wrote:
> In `ecm_mark_as_test` (which is used in `ecm_add_test`) we already disable
the target if `BUILD_TESTING` is false, why is that not enough?
Good question. I didn't explain that in the comm
kfunk updated this revision to Diff 17835.
kfunk added a comment.
Fix typo. "no-top" is something else.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7187?vs=17830&id=17835
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7187
kfunk added a comment.
It's not possible to easily disable tests at the moment, is it? I might be
missing something.
Anyhow, this patch tries to make it easy to build KDevelop without tests;
trying to avoid hacky approaches like those being done in Gentoo:
https://bugs.gentoo.org/
kfunk updated this revision to Diff 17830.
kfunk added a comment.
Remove unrelated hunks
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7187?vs=17829&id=17830
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7187
AFFECTED FILES
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Use-case: Make building unit tests optional, by just following the CMake
BUILD_TESTING option.
The usual appro
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6762
To: winterz, skelly, #build_system, #windows, kfunk
Cc: nalvarez, #frameworks, #build_system
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6249
To: palimaka, #frameworks, kossebau, kfunk
Cc: alexeymin, asturmlechner, #build_system
kfunk added subscribers: arrowdodger, kfunk.
kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.
I don't think we should do that. Compilation only breaks on MSVC2017, which
is fairly new. And according to some test compilations by @ar
kfunk added a comment.
In https://phabricator.kde.org/D5865#112766, @rjvbb wrote:
> KDE is FOSS not bound to Microsoft by any corporate buy-in or whatever,
right?
What non-sense is this? Please stay on topic. There's a benefit we make sure
KDE software is compiling under MSVC giv
kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.
Can't go in as-is, as it breaks compilation on MSVC 2015.
But interesting to see that `/Za` is actually problematic. Which proves my
point: Just don't use named operators in cod
kfunk added a comment.
LGTM in general. I'll hope to find some time to test on Window, wouldn't want
this to be merged before that.
INLINE COMMENTS
> KDECompilerSettings.cmake:226
> +if (MSVC)
> +if (${MSVC_VERSION} GREATER 1900)
> +# /permissive- became the preferred
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
Well, for me that looks good now
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5766
To: tcberner, #freebsd, apol, kfunk
Cc: kfunk, #fr
kfunk requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5766
To: tcberner, #freebsd, apol, kfunk
Cc: kfunk, #frameworks, #build_system
kfunk added inline comments.
INLINE COMMENTS
> ECMGeneratePkgConfigFile.cmake:172
>if(EGPF_INSTALL)
> -set(ECM_PKGCONFIG_INSTALL_DIR "${EGPF_LIB_INSTALL_DIR}/pkgconfig" CACHE
> PATH "The directory where pkgconfig will be installed to.")
> +if(NOT CMAKE_SYSTEM_NAME matches "FreeBSD")
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c56cf46b4beb: Sanitizers: Don't use GCC-like flags for
e.g. MSVC (authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5489?vs=13555&id=13
kfunk added reviewers: aacid, bcooksley.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5489
To: kfunk, aacid, bcooksley
Cc: #frameworks, #build_system
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Fixes compiler warnings such as:
cl : Command line warning D9002 : ignoring unknown option
'-fsanitize=add
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:0348332744d2: KDECompilerSettings: Pass -Wvla &
-Wdate-time (authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5430?vs=13476&id=13554
kfunk updated this revision to Diff 13476.
kfunk added a comment.
Address mpyne's concerns
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5430?vs=13396&id=13476
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5430
AFFECTED FILE
kfunk added a comment.
For -Wdate-time:
https://lxr.kde.org/search?_filestring=&_string=__DATE__
https://lxr.kde.org/search?_filestring=&_string=__TIME__
-> Only around ~10 locations affected, mainly Krita/Digikam/Amarok stuff. The
use of __DATE__ & __TIME__ should just be avoided.
R
kfunk edited the summary of this revision.
kfunk edited the test plan for this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5430
To: kfunk
Cc: #frameworks, #build_system
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
-Wvla: Warn because it's non-standard feature, not supported by MSVC to date
-Wdate-time: Warn because using __TIME
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:3d1d436da60a: Fix compilation under AppleClang (authored
by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5379?vs=13284&id=13289
REVISION DETA
kfunk added a comment.
In https://phabricator.kde.org/D5379#100960, @rjvbb wrote:
> LGTM.
>
> Is this related to the compiler features issue in one of Qt's cmake modules?
No, it's related to CMake starting to treat AppleClang & Clang differently
since 3.0
REPOSITORY
R240 Ex
kfunk added a reviewer: rjvbb.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5379
To: kfunk, rjvbb
Cc: #frameworks, #build_system
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Broken since we started to treat Clang and AppleClang differently (with
the switch to CMake 3.0)
FIXED-IN: v5.
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c20a9f69e8e2: Use -Wno-gnu-zero-variadic-macro-arguments
more (authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5302?vs=13096&id=13113
kfunk added a comment.
FYI: I'll wait with pushing until v5.33 is released.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5302
To: kfunk, kossebau, dfaure, apol
Cc: apol, #frameworks, #build_system
kfunk added a comment.
In https://phabricator.kde.org/D5302#99816, @apol wrote:
> +1
>
> Which warnings? Are they proper warnings that should be fixed?
See comment inside the source code: It's triggered by normal usage from
`qCDebug()`...
REPOSITORY
R240 Extra CMake Modules
kfunk updated this revision to Diff 13096.
kfunk added a comment.
Re-enable for Clang
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5302?vs=13094&id=13096
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5302
AFFECTED FILES
k
kfunk created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
Add it to KDECompilerSettings.cmake instead of
KDEFrameworkCompilerSettings.cmake.
Users can then just enable
kfunk added reviewers: kossebau, dfaure.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5302
To: kfunk, kossebau, dfaure
Cc: #frameworks, #build_system
kfunk added a comment.
In https://phabricator.kde.org/D5136#96878, @aacid wrote:
> I'm not sure addign a dependency for releaseme in ki18n is a good idea to
be honest.
>
> This very "only works for KDE-based applications", a third-party using k18n
has no interest in this at all.
>
kfunk requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D5136
To: apol, #frameworks, #build_system, aacid, sitter, kfunk
kfunk added inline comments.
INLINE COMMENTS
> KF5I18nConfig.cmake.in:12
> +
> +execute_process(COMMAND git config --get remote.origin.url
> +OUTPUT_VARIABLE reponame
Can you delay that git invocation to when the custom target is executed?
Otherwise we also pay for this whenever `KF5I18nCon
kfunk closed this revision.
kfunk added a comment.
Closing. Please just strip the flag from CMake flags if you're using a
library making use of alternative tokens.
We've just seen compilation failing early because some lib in KF5
accidentally used alternative tokens => would have broken
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
LGTM
REVISION DETAIL
https://phabricator.kde.org/D5089
To: rjvbb, #build_system, #frameworks, kfunk
Cc: kfunk, apol, kde-mac, #frameworks, #build_system
kfunk requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D5089
To: rjvbb, #build_system, #frameworks, kfunk
Cc: kfunk, apol, kde-mac, #frameworks, #build_system
kfunk added a comment.
+1 to apol's recommendation. `... MATCHES "Clang"` is the expression everyone
uses.
Even in cmake.git:
Modules/CMakeDetermineCCompiler.cmake
138: if(CMAKE_C_COMPILER_ID MATCHES "GNU" OR CMAKE_C_COMPILER_ID MATCHES
"Clang")
Also see:
http://stackov
kfunk added a comment.
I start to agree that it's probably better to revert this patch, for the
simple reason: We might break compilation of a project using boost if boost
decides to add code which uses alternative tokens to any of its headers. This
is not under our control.
On the othe
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R240 Extra CMake Modules
BRANCH
inotify
REVISION DETAIL
https://phabricator.kde.org/D3826
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: adridg, apol, arrowdodg
kfunk added a comment.
@dfaure `find_path` is okay here, it's commonly used for finding includes.
See: https://cmake.org/cmake/help/v3.0/command/find_path.html
`check_include_files` is used for just checking the existence of a include,
not finding out //where// it is.
Example use: `CHE
kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> FindInotify.cmake:51
> +if(Inotify_INCLUDE_DIRS)
> + # On Linux there is no library to link against, on the BSDs there is.
> + #
have applied
`Q_DECL_OVERRIDE` everywhere. Do you want to double-check?
- Kevin Funk
On Dec. 29, 2016, 11:48 p.m., Albert Astals Cid wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.re
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:a5f3a76e1479: Pass -fno-operator-names when supported
(authored by kfunk).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3850?vs=9443&id=10205
REVISIO
too many warnings
caused by this change.
We'll reapply it after the KF5 release. Most of the warnings have been fixed by
Laurent a few days ago (and I have a few more patches I'll push after the
release).
- Kevin Funk
On Dec. 29, 2016, 11:48 p.m., Albert Astals
kfunk added a comment.
Note: I'll push this after the imminent KF5 release if no-one objects.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3850
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfun
kfunk added a comment.
In https://phabricator.kde.org/D3850#72308, @rakuco wrote:
> Isn't it better to use `check_cxx_compiler_flag` to see if the flag is
supported and enable it in case it is?
-fno-operator-names is an ancient compiler flag, supported by GCC since at
least 2000
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
LGTM
REPOSITORY
R240 Extra CMake Modules
BRANCH
ninja-colors
REVISION DETAIL
https://phabricator.kde.org/D3733
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpref
kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision now requires changes to proceed.
This flag is only needed for Ninja, correct? Thus please check for Ninja in
`CMAKE_GENERATOR ` before adding the compiler flag.
REPOSITORY
R240 Extr
kfunk added a comment.
Windows: We have working gperf recipe in Craft => we're fine.
QtWebKit already had an (optional) dependency on gperf.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D3830
EMAIL PREFERENCES
https://phabricator.kde.org/settings
> On Sept. 30, 2016, 6:47 a.m., Kevin Funk wrote:
> > kde-modules/KDECompilerSettings.cmake, line 74
> > <https://git.reviewboard.kde.org/r/128779/diff/1/?file=475491#file475491line74>
> >
> > `CMAKE_C_SIMULATE_ID STREQUAL "MSVC"` instead of
&
/KDECompilerSettings.cmake (line 181)
<https://git.reviewboard.kde.org/r/128779/#comment67022>
At least here and for similar checks you can just use `CLANG_AS_MSVC`.
- Kevin Funk
On Aug. 27, 2016, 12:48 p.m., Gleb Popov wrote:
>
> ---
tps://git.reviewboard.kde.org/r/128779/#comment67020>
`CMAKE_C_SIMULATE_ID STREQUAL "MSVC"` instead of `x${CMAKE_C_SIMULATE_ID}
STREQUAL "xMSVC"` should do the job, no?
There are multiple other places in this patch where `${FOO}` could be
replaced by just `FOO`.
/ECMAddAppIcon.cmake (line 90)
<https://git.reviewboard.kde.org/r/126711/#comment62077>
Arguable if you need to change this...
But indeed, just matching the name is the safer approach.
- Kevin Funk
On Jan. 10, 2016, 8 p.m., Gleb Popov
marked as submitted.
Review request for Extra Cmake Modules and Alex Merry.
Changes
---
Submitted with commit 942ba80dae253fef93094d178da3ce0abc47da5d by Kevin Funk to
branch master.
Repository: extra-cmake-modules
Description
---
CMake: Cleanup: Strip text from endif/else
Diffs
marked as submitted.
Review request for Extra Cmake Modules, Alex Merry and Hannah von Reth.
Changes
---
Submitted with commit bdd38b5f45a889043deb0665bdb66086ca6c9bf5 by Kevin Funk to
branch master.
Repository: extra-cmake-modules
Description
---
Example:
CMake Warning (dev) at
Z
://git.reviewboard.kde.org/r/126414/diff/
Testing
---
Thanks,
Kevin Funk
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
cb5
Diff: https://git.reviewboard.kde.org/r/126405/diff/
Testing
---
Thanks,
Kevin Funk
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
> On April 24, 2015, 3:49 p.m., Kevin Funk wrote:
> > modules/ECMGeneratePriFile.cmake, line 180
> > <https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180>
> >
> > Just tested the patch myself on sonnet.
> >
> >
g the right `QMAKEPATH` set during the test run imposes another
burden on the user, however.
What about adding:
```
set_tests_properties(... PROPERTIES
ENVIRONMENT
QMAKEPATH=${qt_host_data_dir}
```
- Kevin Funk
On April 24, 2015, 3:26 p.m., Albert Astal
> On April 24, 2015, 3:49 p.m., Kevin Funk wrote:
> > modules/ECMGeneratePriFile.cmake, line 180
> > <https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180>
> >
> > Just tested the patch myself on sonnet.
> >
> >
just spotted that the .pri file for SonnetUi doesn't
have SonnetCore in its dependency list... => Bug? :)
- Kevin Funk
On April 24, 2015, 2:53 p.m., Albert Astals Cid wrote:
>
> ---
> This is an automatically generated e
tps://git.reviewboard.kde.org/r/123491/#comment54298>
Rather: `${PRI_TARGET_BASENAME}_test.pro`?
(Uses the correct suffix)
- Kevin Funk
On April 24, 2015, 2:53 p.m., Albert Astals Cid wrote:
>
> ---
> This is a
thers giving their +1, too
modules/ecm_uninstall.cmake.in
<https://git.reviewboard.kde.org/r/122359/#comment52112>
I'd remove the text inside the condition of `elseif`, `endif` and
`endforeach` (I know it is copied code, but still ...)
- Kevin Funk
On Feb. 3, 2015, 8:19 p.m.,
ject basis in the KDE domain.
Newcomers probably don't need to know about that target, thus, if they don't
know they cannot use it and cause harm to their files anyway.
Also, the name "uninstall" indicates it's a destructive operation, so you have
been
ettings.
>
> Sune Vuorela wrote:
> agreed.
>
> Kevin Funk wrote:
> Yep. I'm also *strongly* in favor of adjusting the code instead of
> enabling the define.
>
> In fact, I thought I've fixed all of KF5. (It isn't?).
> There are so
> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote:
> > I would rather change the code. The Qt behaviour was changed for a reason,
> > to prevent accidental use of dangerous behaviour, and I'm not too keen on
> > undoing that move for all software that uses KDECompilerSettings.
>
> Sune Vuorela wr
dab8498dfd5a5f6dd7a63d8d06d1701770760b33
Diff: https://git.reviewboard.kde.org/r/115632/diff/
Testing
---
Thanks,
Kevin Funk
___
Kde-buildsystem mailing list
Kde-buildsystem@kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem
7;-based constructs.
It's also fine if you just commit whatever you think fits best here, given that
I basically have no clue about kdesrc-build. All I wanted to do is to be able
to 'kdesrc-build kdevelop' under KF5 :)
- Kevin
-------
---
Two commits:
Add .reviewboardrc
Add frameworks-based kdevplatform + kdevelop
Diffs
-
.reviewboardrc PRE-CREATION
kf5-applications-build-include dab8498dfd5a5f6dd7a63d8d06d1701770760b33
Diff: https://git.reviewboard.kde.org/r/115632/diff/
Testing
---
Thanks,
Kevin
90 matches
Mail list logo
