D28355: Introduce function ecm_install_configured_file

2020-03-27 Thread Pino Toscano
pino added inline comments. INLINE COMMENTS > davidedmundson wrote in ECMConfiguredInstall.cmake:46-48 > Maybe. > > My rationale for not forcing a suffix is sometimes we do this configure dance > for .desktop files and there we have to be a bit careful with scripty. > > But generally it's

D28355: Introduce function ecm_install_configured_file

2020-03-27 Thread Pino Toscano
pino added a comment. Nice one! I cannot test right now though, I might do it over the weekend (do not hold on me though). I took the liberty of doing some formatting changes to the header of the new file, what do you think? #.rst: # ECMConfiguredInstall #

D28355: Introduce function ecm_install_configured_file

2020-03-27 Thread Pino Toscano
pino added a comment. Can you please adapt it so `_template` can be an absolute path? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28355 To: davidedmundson Cc: pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh,

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

2018-12-21 Thread Pino Toscano
pino added a comment. In D17718#380261 , @alexeymin wrote: > I tested this, it indeed fixes 390225 > Withoug this patch, generated pkgconfig file was: > > prefix=/usr > exec_prefix=bin > libdir=lib/x86_64-linux-gnu >

D16938: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core

2018-11-18 Thread Pino Toscano
pino closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16938 To: pino, kossebau Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16938: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core

2018-11-17 Thread Pino Toscano
pino created this revision. pino added a reviewer: kossebau. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. pino requested review of this revision. REVISION SUMMARY The Qt5Help CMake modules contain the Qt5::qhelpgenerator

D3830: Add a new FindGperf module

2017-05-15 Thread Pino Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c61aee80d647: Add a new FindGperf module (authored by pino). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3830?vs=9502=14562#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST

D3830: Add a new FindGperf module

2017-04-04 Thread Pino Toscano
pino added a comment. Ping? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 To: pino, #frameworks, #build_system, #windows, kde-mac Cc: kfunk, rjvbb, adridg

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-31 Thread pino (Pino Toscano)
pino added a comment. In https://phabricator.kde.org/D3830#72696, @rjvbb wrote: > In https://phabricator.kde.org/D3830#72508, @pino wrote: > > > For the input file? Yes. > > > I did mean the gperf executable...! I don't get what you mean, sorry :/ The full path of gperf

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-30 Thread pino (Pino Toscano)
pino added a comment. In https://phabricator.kde.org/D3830#72502, @rjvbb wrote: > You're still determining the location from the path with this new revision, right? For the input file? Yes. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

[Differential] [Updated, 125 lines] D3830: Add a new FindGperf module

2016-12-30 Thread pino (Pino Toscano)
pino updated this revision to Diff 9502. pino added a comment. Typo fix in previous revision. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3830?vs=9499=9502 BRANCH pino-gperf REVISION DETAIL https://phabricator.kde.org/D3830 AFFECTED

[Differential] [Updated, 125 lines] D3830: Add a new FindGperf module

2016-12-30 Thread pino (Pino Toscano)
pino updated this revision to Diff 9499. pino added a comment. Restricted Application added projects: Frameworks, Buildsystem. Use a full path for the output location. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3830?vs=9408=9499 BRANCH

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-28 Thread pino (Pino Toscano)
pino added a comment. Cool -- thanks guys for the feedback on FreeBSD/Mac/Windows! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: pino, #frameworks, #buildsystem,

[Differential] [Commented On] D3830: Add a new FindGperf module

2016-12-28 Thread pino (Pino Toscano)
pino added a comment. Windows and Mac people: at least from a quick glance, GNU gperf should be already available on Windows and Mac; can you please confirm the new (build time only) dependency could be acceptable? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

Re: Review Request 119696: KDECompilerSettings: Be more portable across libc's.

2014-08-10 Thread Pino Toscano
did in kde-dev-utils.git/kmtrace/CMakeLists.txt. - Pino Toscano On Ago. 10, 2014, 5:39 p.m., Raphael Kubo da Costa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119696

Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-18 Thread Pino Toscano
-core/NepomukCoreConfig.cmake.in is broken (see NEPOMUK_CORE_LIB_DIR and NEPOMUK_CORE_LIBRARY). -- Pino Toscano signature.asc Description: This is a digitally signed message part. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https

Re: kdepimlibs dependency on nepomuk-core breaks build for Calligra and kdeplasma-addons

2012-12-18 Thread Pino Toscano
Alle lunedì 17 dicembre 2012, Alexander Neundorf ha scritto: On Monday 17 December 2012, Pino Toscano wrote: Alle lunedì 17 dicembre 2012, Ben Cooksley ha scritto: Currently build.kde.org is unable to successfully complete builds of kdeplasma-addons and Calligra due to recent changes

Re: kde4 marbles

2010-04-22 Thread Pino Toscano
to cmake or is it another procedure and if so what is it? Marble ships its own python binding with itself, so you need to pass -DEXPERIMENTAL_PYTHON_BINDINGS=TRUE to kdeedu's cmake invocation to build it. -- Pino Toscano signature.asc Description: This is a digitally signed message part

Re: Cross compiling KDE / Nokia N900

2009-12-23 Thread Pino Toscano
Alle mercoledì 23 dicembre 2009, Alexander Neundorf ha scritto: On Wednesday 23 December 2009, Pino Toscano wrote: Hi, Alle mercoledì 23 dicembre 2009, Alexander Neundorf ha scritto: Yes, it's also on my todo, but it would be really nice if somebody else could actually do the work

Re: KDE/kdepimlibs

2009-05-12 Thread Pino Toscano
Alle martedì 12 maggio 2009, Andreas Pakulat ha scritto: On 11.05.09 23:23:25, Pino Toscano wrote: Alle lunedì 11 maggio 2009, Christophe Giboudeaux ha scritto: SVN commit 966746 by cgiboudeaux: As mentioned by Alex when KDEPIMLIBS_INCLUDE_DIRS was created, installing the kdepimlibs

Re: KDE/kdepimlibs

2009-05-12 Thread Pino Toscano
. -- Pino Toscano signature.asc Description: This is a digitally signed message part. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: KDE/kdepimlibs

2009-05-11 Thread Pino Toscano
KDE module (eg kdelibs, kdepimlibs, kdebase-workspace, kdegames, etc) But now kdepimlibs differs and will install its CamelCase includes in a different location. I don't see them conflicting with kdelibs (or other modules) ones, so... why? -- Pino Toscano signature.asc Description

Re: Remove FindBoost.cmake from kdelibs

2009-05-06 Thread Pino Toscano
${Boost_ADDITIONAL_VERSIONS} 1.39.0 1.39 1.38.0 1.38 1.37.0 1.37) so users can still set Boost_ADDITIONAL_VERSIONS it to add additional Boost versions, and having the same meaning as in FindBoost.cmake (ie more priority than the versions in it). -- Pino Toscano signature.asc Description: This is a digitally

Re: Remove FindBoost.cmake from kdelibs

2009-05-05 Thread Pino Toscano
FindBoost.cmake should be updated for Boost 1.38 and 1.39 (released three days ago). I can do that, whichever solution we agree about (ie mine above or our FindBoost.cmake). -- Pino Toscano signature.asc Description: This is a digitally signed message part

Re: FindBoostPython.cmake in kdeedu

2009-01-19 Thread Pino Toscano
version for a boost version. Note that does not mean picking the first boost found with the first python found. -- Pino Toscano signature.asc Description: This is a digitally signed message part. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org

Re: FindKdepimLibs should require Boost

2008-08-04 Thread Pino Toscano
this to no if boost is not found but the specific library contains boost stuff in its public headers (like libsyndication). Yes. -- Pino Toscano signature.asc Description: This is a digitally signed message part. ___ Kde-buildsystem mailing list Kde-buildsystem

Re: KDE/kdelibs/cmake/modules

2008-05-20 Thread Pino Toscano
) from his distro (a non-source-based one, be it debian, opensuse, fedora, ubuntu, etc), and then develops an own application (or comple some other app). Then they basically don't need the SM/ICE headers at all (and most probably not even the X11 ones). -- Pino Toscano signature.asc Description

Re: Building Docs with meinproc

2007-01-17 Thread Pino Toscano
cases you have to specify always the index file, even if the documentation is splitted into several files. Regards, -- Pino Toscano pgpT967itP88H.pgp Description: PGP signature ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https

Re: Poppler-qt4

2006-06-29 Thread Pino Toscano
-pdf, kviewshell, krita maybe?) just want it with no particular requires on its version. And if the minimum version for okular will be raised, should we keeping the kdelibs one updated? Regards, -- Pino Toscano pgpJh2pZXXraF.pgp Description: PGP signature

Re: Poppler-qt4

2006-06-29 Thread Pino Toscano
is lost. Luckly SVN is smart enough. Regards, -- Pino Toscano pgpmv3141BNyR.pgp Description: PGP signature ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: Asking for a CMake feature

2006-04-24 Thread Pino Toscano
on kdeui, and then a make install did the relink and reinstalled *all*. Yes, using cmake 2.4.0beta, the version released 6 days ago. Regards, -- Pino Toscano pgpAb0ogFGfb8.pgp Description: PGP signature ___ Kde-buildsystem mailing list Kde-buildsystem

Re: Breaking a foreach loop

2006-04-19 Thread Pino Toscano
Alle 16:20, martedì 18 aprile 2006, Brad King ha scritto: Pino Toscano wrote: Hello, imagine I'm iterating using a foreach() like this: set(MY_OPTS foo bar etc) foreach(OPT ${MY_OPTS}) # do something ... endforeach(OPT ${MY_OPTS}) is there a way to break the iteration, just

Trimming newlines from a string

2006-03-21 Thread Pino Toscano
to make cmake output that the regexp matches an empty string. Do you have any precious suggestion about sometimg that I'm missing? Regards, -- Pino Toscano pgp1mZ7o4K8Zx.pgp Description: PGP signature ___ Kde-buildsystem mailing list Kde-buildsystem