habacker created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel.
habacker requested review of this revision.
REVISION SUMMARY
kcoreaddons test case 'kformattest' is designed not to us
habacker abandoned this revision.
habacker added a comment.
How to handle single/plural form then ?
QString KFormatPrivate::formatDecimalDuration(quint64 msecs, int
decimalPlaces) const
{
...
//: @item:intext %1 is a whole number
//~ singular %n millisecond
//~ plural %
aacid added a comment.
Honestly i think that test in kformattest is wrong and that it should contain
it's own small minitranslation so that stuff works fine and then it should be
QCOMPARE(format.formatDecimalDuration(10), QStringLiteral("10
milliseconds"));
instead of
QCOMP
habacker added a comment.
Just as info:
kcoreaddons uses '(s)' suffix in its internal formating methods
(https://cgit.kde.org/kcoreaddons.git/commit/src/lib/util/kformatprivate.cpp?id=ffcd094c1f4716a0d91650608e42017886a0a7e3)
which is always translated with or without 's' 'not always (
habacker added a comment.
No, both LC_ALL=C and LC_ALL=en fetches the same english translation
~/src/kf5/kcoreaddons-build> LC_ALL=en strace -e trace=file bin/kformattest
2>&1 | grep \.qm | grep R_OK
access("/usr/share/locale/en/LC_MESSAGES/kcoreaddons5_qt.qm", R_OK) = 0
~
aacid added a comment.
Doesn't setting the locale to en solve the same problem without needing to
change ECM?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D14778
To: habacker, #frameworks, apol
Cc: aacid, kde-frameworks-devel, kde-buildsystem, michaelh
ngraham added reviewers: Frameworks, apol.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D14778
To: habacker, #frameworks, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
ngraham edited the summary of this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D14778
To: habacker
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
