D27269: Use ecm_qt_install_logging_categories over manual categories file

2020-02-09 Thread Friedrich W. H. Kossebau
kossebau added a dependency: D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27269 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27269: Use ecm_qt_install_logging_categories over manual categories file

2020-02-09 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Build System, Frameworks, broulik, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. TEST PLAN Generated file matches entries of existing manual file

D27269: Use ecm_qt_install_logging_categories over manual categories file

2020-02-10 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:f385d5716762: Use ecm_qt_install_logging_categories over manual categories file (authored by kossebau). CHANGED PRIOR

D27269: Use ecm_qt_install_logging_categories over manual categories file

2020-02-10 Thread Ahmad Samir
ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27269 To: kossebau, #build_system, #frameworks, broulik, mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27269: Use ecm_qt_install_logging_categories over manual categories file

2020-02-28 Thread Stefan BrĂ¼ns
bruns added inline comments. INLINE COMMENTS > CMakeLists.txt:9 > include(FeatureSummary) > find_package(ECM 5.67.0 NO_MODULE) > set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake > Modules." URL "https://commits.kde.org/extra-cmake-modules";) Obviously, this is no