Re: KDE/kdelibs/cmake/modules

2010-10-07 Thread Alexander Neundorf
On Tuesday 05 October 2010, Andreas Holzammer wrote: Hi Alex, i am sorry, i was wrting the replay as draft. Somebody who wanted to build kde static was asking me about it and if i could bring it upstream, then i did. I did not see that i have just saved the replay as draft. So i am sorry how

KDE/kdelibs/cmake/modules

2010-10-05 Thread Rafael Fernández López
--- trunk/KDE/kdelibs/cmake/modules/CMakeLists.txt #1182130:1182131 @@ -116,6 +116,7 @@ FindSqlite.cmake FindStrigi.cmake FindTaglib.cmake + FindUDev.cmake FindUSB.cmake FindWcecompat.cmake

KDE/kdelibs/cmake/modules

2010-10-05 Thread Kevin Ottens
SVN commit 1182142 by ervin: Make the module actually works for me. Seems to be the more standard way to deal with this kind of detection. CCMAIL: eresli...@kde.org CCMAIL: kde-buildsystem@kde.org M +6 -6 FindUDev.cmake --- trunk/KDE/kdelibs/cmake/modules/FindUDev.cmake #1182141

Re: KDE/kdelibs/cmake/modules

2010-10-05 Thread Rafael Fernández López
For now it is only used in kdelibs solid. Best regards, Rafael Fernández López. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

KDE/kdelibs/cmake/modules

2010-10-05 Thread Rafael Fernández López
--- trunk/KDE/kdelibs/cmake/modules/CMakeLists.txt #1182269:1182270 @@ -7,9 +7,10 @@ # to have it around, so there is a place where the modules which are not installed # are listed explicitely: set(cmakeFilesDontInstall + FindHUpnp.cmake FindPolkitQt.cmake

Re: KDE/kdelibs/cmake/modules

2010-10-05 Thread Rafael Fernández López
Thanks for the advise. Will do it in a matter of minutes :-) Best regards, Rafael Fernández López. ___ Kde-buildsystem mailing list Kde-buildsystem@kde.org https://mail.kde.org/mailman/listinfo/kde-buildsystem

Re: KDE/kdelibs/cmake/modules

2010-10-05 Thread Alexander Neundorf
to parse the arguments of KDE4_ADD_PLUGIN(). So, I don't like this commit. Alex --- trunk/KDE/kdelibs/cmake/modules/KDE4Macros.cmake #1182378:1182379 @@ -626,30 +626,63 @@ endmacro (KDE4_HANDLE_RPATH_FOR_EXECUTABLE) -macro (KDE4_ADD_PLUGIN _target_NAME _with_PREFIX) -#is the first argument

Re: KDE/kdelibs/cmake/modules

2010-10-03 Thread Alexander Neundorf
On Sunday 03 October 2010, Kevin Ottens wrote: SVN commit 1182142 by ervin: Make the module actually works for me. Seems to be the more standard way to deal with this kind of detection. CCMAIL: eresli...@kde.org CCMAIL: kde-buildsystem@kde.org M +6 -6 FindUDev.cmake The file

Re: KDE/kdelibs/cmake/modules

2010-10-03 Thread Alexander Neundorf
On Sunday 03 October 2010, Rafael Fernández López wrote: For now it is only used in kdelibs solid. Then please move it from the variable cmakeFiles to cmakeFilesDontInstall in kdelibs/cmake/modules/. Installing it means we promise source comaptibility for this file for all of KDE 4.x. Not

KDE/kdelibs/cmake/modules

2010-08-25 Thread Alexander Neundorf
-30 FindEigen2.cmake M +106 -47 FindPackageHandleStandardArgs.cmake --- trunk/KDE/kdelibs/cmake/modules/CMakeLists.txt #1167972:1167973 @@ -10,9 +10,6 @@ FindPolkitQt.cmake FindPolkitQt-1.cmake) -# remove once we depend on a newer cmake version

Re: KDE/kdelibs/cmake/modules

2010-07-27 Thread Volker Krause
On Monday 26 July 2010 21:17:28 Alexander Neundorf wrote: On Monday 12 July 2010, Andreas Holzammer wrote: SVN commit 1149092 by aholzammer: - fixed some find scripts for wince M +6 -0 FindKDE4Internal.cmake M +2 -2 KDE4Macros.cmake Hi Andreas, it's very nice that

Re: KDE/kdelibs/cmake/modules

2010-07-26 Thread Alexander Neundorf
is currently comment 0016984 from Brad. Alex --- trunk/KDE/kdelibs/cmake/modules/FindKDE4Internal.cmake #1149091:1149092 @@ -508,6 +508,7 @@ set(KDE4_LIB_DIR ${LIBRARY_OUTPUT_PATH}/${CMAKE_CFG_INTDIR}) + # when building kdelibs, make the kcfg rules depend on the binaries... set

Re: KDE/kdelibs/cmake/modules

2010-07-26 Thread Alexander Neundorf
On Sunday 18 July 2010, Romain Pokrzywka wrote: SVN commit 1151234 by pokrzywka: install FindWcecompat.cmake (needed by FindKDEWin.cmake) Hi, FindWcecompat.cmake looks somewhat strange. It seems to contain the same code twice ? Also it should have been posted for review first before adding

KDE/kdelibs/cmake/modules

2010-07-08 Thread Michael Jansen
SVN commit 1147584 by mjansen: Make PYTHON_SITE_PACKAGES_INSTALL_DIR an absolute path. CCMAIL: kde-buildsystem@kde.org M +1 -1 FindPythonLibrary.cmake --- trunk/KDE/kdelibs/cmake/modules/FindPythonLibrary.cmake #1147583:1147584 @@ -60,7 +60,7 @@ set(PYTHON_SITE_PACKAGES_DIR

Re: KDE/kdelibs/cmake/modules

2010-07-08 Thread Andreas Pakulat
On 08.07.10 21:18:03, Michael Jansen wrote: SVN commit 1147584 by mjansen: Make PYTHON_SITE_PACKAGES_INSTALL_DIR an absolute path. CCMAIL: kde-buildsystem@kde.org How is the variable used? If its used with install() commands then cmake will prepend the prefix anyway. In particular I think

Re: KDE/kdelibs/cmake/modules

2010-07-08 Thread Michael Jansen
On Donnerstag 08 Juli 2010 22:40:05 Andreas Pakulat wrote: On 08.07.10 21:18:03, Michael Jansen wrote: SVN commit 1147584 by mjansen: Make PYTHON_SITE_PACKAGES_INSTALL_DIR an absolute path. CCMAIL: kde-buildsystem@kde.org How is the variable used? If its used with install()

KDE/kdelibs/cmake/modules

2010-06-07 Thread Raphael Kubo da Costa
/kdelibs/cmake/modules/FindKDE4Internal.cmake #1135641:1135642 @@ -1136,8 +1136,36 @@ kde_check_flag_exists(/NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd CMAKE_EXE_LINKER_FLAGS_DEBUG debug) endif(MSVC) +# This macro is for internal use only +# Return the directories present in gcc's include path

KDE/kdelibs/cmake/modules

2010-05-11 Thread Allen Winter
SVN commit 1125486 by winterz: Super-duper-hackarific for supporting Fedora12 and Fedora13. Older Fedoras will need to be added as required. Rex is talking to Fedora about this. CCMAIL: kde-buildsystem@kde.org M +10 -0 FindDocBookXML.cmake --- trunk/KDE/kdelibs/cmake/modules

KDE/kdelibs/cmake/modules

2010-05-01 Thread Alexander Neundorf
SVN commit 1121456 by neundorf: -require CMake 2.6.4 for trunk Alex CCMAIL: kde-buildsystem@kde.org M +1 -1 FindKDE4Internal.cmake --- trunk/KDE/kdelibs/cmake/modules/FindKDE4Internal.cmake #1121455:1121456 @@ -293,7 +293,7 @@ # this is required now by cmake 2.6 and so must

Re: Fwd: Re: KDE/kdelibs/cmake/modules

2010-03-05 Thread Jonathan Marten
On Friday 05 March 2010 17:59:42 Alexander Neundorf wrote: I don't think having a add_subdirectory(foo) and then not having a CMakeLists.txt in foo/ is deliberate anywhere. I think Laurent was commenting on the use of macro_optional_add_subdirectory, not add_subdirectory (which is built into

KDE/kdelibs/cmake/modules

2010-01-07 Thread Alexander Neundorf
SVN commit 1071192 by neundorf: we require CMake 2.6.2 or KDE, nothing else has been announced, discussed or even suggested Alex CCMAIL: kde-buildsystem@kde.org CCMAIL: muel...@kde.org M +1 -1 FindKDE4Internal.cmake --- trunk/KDE/kdelibs/cmake/modules/FindKDE4Internal.cmake

Re: KDE/kdelibs/cmake/modules

2010-01-07 Thread Mike Arthur
On 7 Jan 2010, at 17:53, Alexander Neundorf wrote: we require CMake 2.6.2 or KDE, nothing else has been announced, discussed or even suggested I suggest 2.8! ;) -- Cheers, Mike Arthur http://mikearthur.co.uk ___ Kde-buildsystem mailing list

Re: KDE/kdelibs/cmake/modules

2010-01-07 Thread Raphael Kubo da Costa
     FindKDE4Internal.cmake --- trunk/KDE/kdelibs/cmake/modules/FindKDE4Internal.cmake #1071191:1071192 @@ -275,7 +275,7 @@  # this is required now by cmake 2.6 and so must not be skipped by if(KDE4_FOUND) below -cmake_minimum_required(VERSION 2.6.3 FATAL_ERROR) +cmake_minimum_required(VERSION 2.6.2

Re: KDE/kdelibs/cmake/modules

2010-01-07 Thread Alexander Neundorf
On Thursday 07 January 2010, Dirk Mueller wrote: SVN commit 1071123 by mueller: we need 2.6.3 for the shared-desktop-ontologies detection What ?? You cannot simply do that without discussing or announcing this anywhere. I'll revert. SDI is just a simple file, this surely can't be the reason

Re: KDE/kdelibs/cmake/modules

2010-01-07 Thread Alexander Neundorf
On Thursday 07 January 2010, Mike Arthur wrote: On 7 Jan 2010, at 17:53, Alexander Neundorf wrote: we require CMake 2.6.2 or KDE, nothing else has been announced, discussed or even suggested I suggest 2.8! ;) Maybe, but only if necessary and people should have time to update beforee it

Re: KDE/kdelibs/cmake/modules

2010-01-07 Thread Alexander Neundorf
-buildsystem@kde.org CCMAIL: muel...@kde.org  M  +1 -1      FindKDE4Internal.cmake --- trunk/KDE/kdelibs/cmake/modules/FindKDE4Internal.cmake #1071191:1071192 @@ -275,7 +275,7 @@  # this is required now by cmake 2.6 and so must not be skipped by if(KDE4_FOUND) below

Re: KDE/kdelibs/cmake/modules

2010-01-07 Thread Dirk Mueller
On Thursday 07 January 2010, Alexander Neundorf wrote: we need 2.6.3 for the shared-desktop-ontologies detection What ?? Sorry, I assumed this is not a big issue, given that we depend on kdebindings in kdebase/workspace which only builds against a recent SVN snapshot of the python sip

KDE/kdelibs/cmake/modules

2010-01-06 Thread Alexander Neundorf
--- trunk/KDE/kdelibs/cmake/modules/FindQt4.cmake #1070848:1070849 @@ -892,39 +892,36 @@ MACRO (_QT4_ADJUST_LIB_VARS basename) +#message(STATUS Adjusting ${basename}, release: -${QT_${basename}_LIBRARY_RELEASE}- debug: -${QT_${basename

KDE/kdelibs/cmake/modules

2010-01-01 Thread Michael Jansen
? But I'm not sure. CCMAIL: kde-buildsystem@kde.org CCMAIL: kde-bindi...@kde.org M +3 -1 FindSIP.cmake --- trunk/KDE/kdelibs/cmake/modules/FindSIP.cmake #1068560:1068561 @@ -38,7 +38,9 @@ STRING(REGEX REPLACE ^sip_version:([^\n]+).*$ \\1 SIP_VERSION ${sip_config}) STRING(REGEX

KDE/kdelibs/cmake/modules

2009-12-13 Thread Alexander Neundorf
SVN commit 1062002 by neundorf: -make building KDE with Qt4 installed as OSX frameworks work Alex CCMAIL: m...@mikearthur.co.uk CCMAIL: kde-buildsystem@kde.org M +0 -3 FindKDE4Internal.cmake M +8 -1 FindQt4.cmake --- trunk/KDE/kdelibs/cmake/modules/FindKDE4Internal.cmake

Re: KDE/kdelibs/cmake/modules

2009-12-13 Thread Mike Arthur
On 13 Dec 2009, at 14:36, Alexander Neundorf wrote: -make building KDE with Qt4 installed as OSX frameworks work Nice one, I'll double-check that this works properly. This should definitely be in upstream CMake if it's not already. -- Cheers, Mike Arthur http://mikearthur.co.uk

Re: KDE/kdelibs/cmake/modules

2009-11-25 Thread Alexander Neundorf
On Wednesday 25 November 2009, Sebastian Trueg wrote: SVN commit 1054115 by trueg: removed completely deprecated stuff D FindKNepomuk.cmake D FindKonto.cmake Hmm, we shipped both with KDE 4.3 and previous versions, so if there are no really good reasons (e.g. that

Re: KDE/kdelibs/cmake/modules

2009-11-25 Thread Alexander Neundorf
Hi Sebastian, On Wednesday 25 November 2009, Sebastian Trueg wrote: SVN commit 1054294 by trueg: Added macro to find the new shared-desktop-ontologies package M +1 -0 CMakeLists.txt M +7 -1 FindNepomuk.cmake A FindSharedDesktopOntologies.cmake please be more

Re: KDE/kdelibs/cmake/modules

2009-11-23 Thread Dario Freddi
On Sunday 22 November 2009 02:06:58 Alexander Neundorf wrote: On Friday 20 November 2009, Dario Freddi wrote: SVN commit 1051970 by dafre: CCMAIL: kde-buildsystem@kde.org Nevermind, I found out how. Also, probably FindPolkitQt.cmake is another good candidate for non-installation? It

Re: KDE/kdelibs/cmake/modules

2009-11-22 Thread Alexander Neundorf
On Sunday 22 November 2009, Dario Freddi wrote: On Sunday 22 November 2009 02:06:58 Alexander Neundorf wrote: On Friday 20 November 2009, Dario Freddi wrote: SVN commit 1051970 by dafre: CCMAIL: kde-buildsystem@kde.org Nevermind, I found out how. Also, probably FindPolkitQt.cmake

Re: KDE/kdelibs/cmake/modules

2009-11-22 Thread Alexander Neundorf
On Friday 20 November 2009, Dario Freddi wrote: SVN commit 1051967 by dafre: CCMAIL: kde-buildsystem@kde.org Adding FindPolkitQt-1.cmake for the upcoming polkit-1 support in KAuth, as discussed on kde-buildsystem some time ago. Alex, can you please take care of making this module not

Re: KDE/kdelibs/cmake/modules

2009-11-21 Thread Alexander Neundorf
On Friday 20 November 2009, Dario Freddi wrote: SVN commit 1051970 by dafre: CCMAIL: kde-buildsystem@kde.org Nevermind, I found out how. Also, probably FindPolkitQt.cmake is another good candidate for non-installation? It could be just copied over to kdebase/workspace/cmake/modules in that

KDE/kdelibs/cmake/modules

2009-11-20 Thread Dario Freddi
SVN commit 1051967 by dafre: CCMAIL: kde-buildsystem@kde.org Adding FindPolkitQt-1.cmake for the upcoming polkit-1 support in KAuth, as discussed on kde-buildsystem some time ago. Alex, can you please take care of making this module not getting installed? A FindPolkitQt-1.cmake

KDE/kdelibs/cmake/modules

2009-11-20 Thread Dario Freddi
sense, as KDE applications are not supposed to take advantage of polkit-qt, but of KAuth instead. M +2 -1 CMakeLists.txt --- trunk/KDE/kdelibs/cmake/modules/CMakeLists.txt #1051969:1051970 @@ -3,7 +3,8 @@ set(module_install_dir ${DATA_INSTALL_DIR}/cmake/modules ) # maybe

Re: KDE/kdelibs/cmake/modules

2009-10-04 Thread Alexander Neundorf
/KDE/kdelibs/cmake/modules/KDE4Macros.cmake #1031057:1031058 @@ -159,7 +159,7 @@ #usage: KDE4_ADD_UI3_FILES(foo_SRCS ${ui_files}) macro (KDE4_ADD_UI3_FILES _sources ) - qt4_get_moc_inc_dirs(_moc_INCS) + qt4_get_moc_flags(_moc_INCS) Hmm, what do we do here... qt4_get_moc_inc_dirs

Re: KDE/kdelibs/cmake/modules

2009-10-04 Thread Andreas Pakulat
...@kde.org M +1 -1 KDE4Macros.cmake --- trunk/KDE/kdelibs/cmake/modules/KDE4Macros.cmake #1031057:1031058 @@ -159,7 +159,7 @@ #usage: KDE4_ADD_UI3_FILES(foo_SRCS ${ui_files}) macro (KDE4_ADD_UI3_FILES _sources ) - qt4_get_moc_inc_dirs(_moc_INCS) + qt4_get_moc_flags

Re: KDE/kdelibs/cmake/modules

2009-10-04 Thread Alexander Neundorf
On Sunday 04 October 2009, Michael Jansen wrote: SVN commit 1031231 by mjansen: Provide a FindKDE4Runtime.cmake file. Copied and adapted from FindKDE4Workspace.cmake. CCMAIL: kde-buildsystem@kde.org CCMAIL: neund...@kde.org A FindKDE4Runtime.cmake The documentation in that

Re: KDE/kdelibs/cmake/modules

2009-10-04 Thread Michael Jansen
I thought that's what i have done with the CCMAIL . That's much easier then attaching the content. Mike On Sunday 04 October 2009 18:18:07 Alexander Neundorf wrote: On Sunday 04 October 2009, Michael Jansen wrote: SVN commit 1031231 by mjansen: Provide a FindKDE4Runtime.cmake file.

Re: KDE/kdelibs/cmake/modules

2009-10-04 Thread Alexander Neundorf
On Sunday 04 October 2009, you wrote: I thought that's what i have done with the CCMAIL . That's much easier then attaching the content. From http://techbase.kde.org/Policies/CMake_Commit_Policy: When committing changes in kdelibs/cmake/modules/, the following rules must be followed: 1.

Re: KDE/kdelibs/cmake/modules

2009-10-04 Thread Andreas Hartmetz
CCMAIL: neund...@kde.org M +1 -1 KDE4Macros.cmake --- trunk/KDE/kdelibs/cmake/modules/KDE4Macros.cmake #1031057:1031058 @@ -159,7 +159,7 @@ #usage: KDE4_ADD_UI3_FILES(foo_SRCS ${ui_files}) macro (KDE4_ADD_UI3_FILES _sources ) - qt4_get_moc_inc_dirs(_moc_INCS

KDE/kdelibs/cmake/modules

2009-10-03 Thread Alexander Neundorf
there. Let me know if there are suddenly moc-related problems. Alex CCMAIL: kde-buildsystem@kde.org M +47 -38FindQt4.cmake --- trunk/KDE/kdelibs/cmake/modules/FindQt4.cmake #1030974:1030975 @@ -1294,7 +1294,7 @@ ENDIF (${_currentArg} STREQUAL OPTIONS) ENDFOREACH(_currentArg

KDE/kdelibs/cmake/modules

2009-10-03 Thread Andreas Hartmetz
SVN commit 1031058 by ahartmetz: Fix / adapt to FindQt4.cmake changes. Found the error in kdenetwork which uses reeeally old ui files. CCMAIL: kde-buildsystem@kde.org CCMAIL: neund...@kde.org M +1 -1 KDE4Macros.cmake --- trunk/KDE/kdelibs/cmake/modules/KDE4Macros.cmake #1031057

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Dario Freddi
Here it goes, new diff for findkde4internals and kde4macros (and the full polkitqt file :D) some comments below In data sabato 05 settembre 2009 21:53:36, Alexander Neundorf ha scritto: [snip] Yes, please. This would add another macro which creates an executable, but without providing real

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Alexander Neundorf
On Sunday 06 September 2009, Dario Freddi wrote: Here it goes, new diff for findkde4internals and kde4macros There is some inconsistency in the naming: KDE4_AUTH_INSTALL_ACTIONS() vs. KDE4_INSTALL_AUTH_HELPER_FILES() How about KDE4_INSTALL_AUTH_ACTIONS() ? From the documentation: # This

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Alexander Neundorf
On Sunday 06 September 2009, Dario Freddi wrote: Diff updated. This one should be a good commit candidate, all concerns should have gone away. No objections. If there is anything left we can still work on it later. Alex ___ Kde-buildsystem mailing

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Alexander Neundorf
On Sunday 06 September 2009, Dario Freddi wrote: About the dbus macro, I finally found out where I copied it from: kdebase/workspace/cmake/modules/PkgConfigGetVar.cmake. It has a dbus_add_activation_service macro inside it. Yes, weird. Also FindDBus (the workspace one) has no dbus related

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Alexander Neundorf
On Sunday 06 September 2009, Dario Freddi wrote: This is getting ridicolous. Following snippet in FindPolkitQt.cmake: find_path( POLKITQT_INCLUDE_DIR NAMES polkit-qt/auth.h PATH_SUFFIXES PolicyKit ) find_path( p1 NAMES polkit-qt/auth.h PATH_SUFFIXES PolicyKit )

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Alexander Neundorf
On Sunday 06 September 2009, Dario Freddi wrote: In data domenica 06 settembre 2009 15:57:59, Alexander Neundorf ha scritto: Sure ? I don't see it. You are right. We replaced that macro with stubs some time ago and I completely forgot about it. Cool :-) So we even got rid of an unused macro

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Alexander Neundorf
On Sunday 06 September 2009, Dario Freddi wrote: In data domenica 06 settembre 2009 15:34:00, Alexander Neundorf ha scritto: : On Sunday 06 September 2009, Dario Freddi wrote: : About the dbus macro, I finally found out where I copied it from:

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Dario Freddi
Diff updated. This one should be a good commit candidate, all concerns should have gone away. In data domenica 06 settembre 2009 14:40:40, Alexander Neundorf ha scritto: : On Sunday 06 September 2009, Dario Freddi wrote: Here it goes, new diff for findkde4internals and kde4macros There is

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Dario Freddi
In data domenica 06 settembre 2009 15:26:55, Alexander Neundorf ha scritto: We have to get that working. Have a look at the attached file. It searches for a header in a similar path, /usr/include/GL/internal.glcore.h. This is what I get here: $ /opt/cmake-2.6.2-Linux-i386/bin/cmake .. --

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Dario Freddi
In data domenica 06 settembre 2009 15:34:00, Alexander Neundorf ha scritto: : On Sunday 06 September 2009, Dario Freddi wrote: About the dbus macro, I finally found out where I copied it from: kdebase/workspace/cmake/modules/PkgConfigGetVar.cmake. It has a dbus_add_activation_service macro

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Dario Freddi
About the dbus macro, I finally found out where I copied it from: kdebase/workspace/cmake/modules/PkgConfigGetVar.cmake. It has a dbus_add_activation_service macro inside it. Yes, weird. Also FindDBus (the workspace one) has no dbus related macros inside it. Alexander, I depend on you to

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Dario Freddi
In data domenica 06 settembre 2009 16:13:07, Alexander Neundorf ha scritto: : On Sunday 06 September 2009, Dario Freddi wrote: In data domenica 06 settembre 2009 15:57:59, Alexander Neundorf ha scritto: Sure ? I don't see it. You are right. We replaced that macro with stubs some time

Re: KDE/kdelibs/cmake/modules

2009-09-06 Thread Dario Freddi
In data domenica 06 settembre 2009 15:57:59, Alexander Neundorf ha scritto: Sure ? I don't see it. You are right. We replaced that macro with stubs some time ago and I completely forgot about it. Whatever, here comes FindPolkitQt.cmake without the macro, but featuring fixes (and license

Re: KDE/kdelibs/cmake/modules

2009-09-05 Thread Alexander Neundorf
On Saturday 05 September 2009, Dario Freddi wrote: Hi back, first attempt of doing things right. Please review. My only doubt is about the new KDE4_KAUTH_POLICY_GEN_EXECUTABLE: is it valid also while building kdelibs or should I add another if _kdeBootstrap to kde4_auth_add_actions? Since

Re: KDE/kdelibs/cmake/modules

2009-09-05 Thread Alexander Neundorf
On Saturday 05 September 2009, Dario Freddi wrote: Gotta go out in a moment, I'll try to be quick In data sabato 05 settembre 2009 15:47:27, Alexander Neundorf ha scritto: ... Hmm, now actually looking at it, I don't like the macro. It does many things at once and that's not obvious from

Re: KDE/kdelibs/cmake/modules

2009-09-05 Thread Dario Freddi
Hi back, first attempt of doing things right. Please review. My only doubt is about the new KDE4_KAUTH_POLICY_GEN_EXECUTABLE: is it valid also while building kdelibs or should I add another if _kdeBootstrap to kde4_auth_add_actions? In data giovedì 03 settembre 2009 20:50:28, Alexander

Re: KDE/kdelibs/cmake/modules

2009-09-05 Thread Dario Freddi
P.S.: Whenever I will commit this one, I will increase KDELibs version number, make the needed modifications to kdebase-workspace and set its dependency from kdelibs on the new version number. Please tell me if that's ok as well In data giovedì 03 settembre 2009 20:50:28, Alexander Neundorf ha

Re: KDE/kdelibs/cmake/modules

2009-09-05 Thread Dario Freddi
Gotta go out in a moment, I'll try to be quick In data sabato 05 settembre 2009 15:47:27, Alexander Neundorf ha scritto: : On Saturday 05 September 2009, Dario Freddi wrote: Hi back, first attempt of doing things right. Please review. My only doubt is about the new

Re: KDE/kdelibs/cmake/modules

2009-09-04 Thread Dario Freddi
In data giovedì 03 settembre 2009 19:35:30, Alexander Neundorf ha scritto: : ... sending it again, since I assume that Dario is not subscribed to both lists You assume right :) On Wednesday 02 September 2009, Dario Freddi wrote: SVN commit 1018860 by dafre: Fix installation prefix,

Re: KDE/kdelibs/cmake/modules

2009-09-04 Thread Dario Freddi
Ah, can you please also point me to a find*.cmake that uses pkg-config the right way? In data giovedì 03 settembre 2009 19:35:30, Alexander Neundorf ha scritto: : ... sending it again, since I assume that Dario is not subscribed to both lists On Wednesday 02 September 2009, Dario Freddi

Re: KDE/kdelibs/cmake/modules

2009-09-04 Thread Dario Freddi
Also (sorry for flooding) just read about the cmake files needed to be sent to kde-buildsystem for review. So please, your target is cmake/modules/MacroKAuth.cmake. By the way, what about making these policies more widespread? If it was not for Alexander, I would have never known that, and

Re: KDE/kdelibs/cmake/modules

2009-09-04 Thread Dario Freddi
First attempt to refactor. Problems: include paths seems not to work. It should include /usr/include/PolicyKit but somehow it does not work. Hints? TODO: Move the macros Is there a way to check version better than what I'm doing? -- --- Dario Freddi KDE Developer

Re: KDE/kdelibs/cmake/modules

2009-09-04 Thread Dario Freddi
In data giovedì 03 settembre 2009 20:24:13, Alexander Neundorf ha scritto: Roger that I guess this means ok ? Yes :) The variables is set, but neither documented nor used. Maybe just remove it ? If it stays in that file, it should be documented and it really should get the POLKITQT_

Re: KDE/kdelibs/cmake/modules

2009-09-04 Thread Dario Freddi
In data giovedì 03 settembre 2009 20:02:38, Alexander Neundorf ha scritto: Now that it is part of kdecore the searching for the installed files is not really necessary anymore. kauth/dbus_service.stub and kauth/dbus_policy.stub will be installed to ${DATA_INSTALL_DIR}, which is

Re: KDE/kdelibs/cmake/modules

2009-09-03 Thread Alexander Neundorf
... sending it again, since I assume that Dario is not subscribed to both lists On Wednesday 02 September 2009, Dario Freddi wrote: SVN commit 1018860 by dafre: Fix installation prefix, still need to spit a warning M +4 -1 FindPolkitQt.cmake CMake files which go into

Re: KDE/kdelibs/cmake/modules

2009-09-03 Thread Alexander Neundorf
On Wednesday 02 September 2009, Alexander Neundorf wrote: On Tuesday 01 September 2009, Raphael Kubo da Costa wrote: 2009/9/1 Dario Freddi drf54...@gmail.com: In every application using KAuth. Should I just put some comments or there's a syntax for that? usage guide is already in the

Re: KDE/kdelibs/cmake/modules

2009-09-03 Thread Alexander Neundorf
On Thursday 03 September 2009, Dario Freddi wrote: In data giovedì 03 settembre 2009 19:35:30, Alexander Neundorf ha scritto: ... * I missed the point where the new files were posted for review on kde-buildsystem (maybe due to my vacation ?) It was part of KAuth during review. Additionally,

Re: KDE/kdelibs/cmake/modules

2009-09-03 Thread Alexander Neundorf
On Thursday 03 September 2009, Dario Freddi wrote: Also (sorry for flooding) just read about the cmake files needed to be sent to kde-buildsystem for review. So please, your target is cmake/modules/MacroKAuth.cmake. By the way, what about making these policies more widespread? If it was not

Re: KDE/kdelibs/cmake/modules

2009-09-03 Thread Alexander Neundorf
On Thursday 03 September 2009, you wrote: Ah, can you please also point me to a find*.cmake that uses pkg-config the right way? FindLibXml2.cmake (except that the calls are all-uppercase there) Alex ___ Kde-buildsystem mailing list

Re: KDE/kdelibs/cmake/modules

2009-09-03 Thread Andreas Pakulat
On 03.09.09 20:08:17, Alexander Neundorf wrote: On Thursday 03 September 2009, Dario Freddi wrote: Also (sorry for flooding) just read about the cmake files needed to be sent to kde-buildsystem for review. So please, your target is cmake/modules/MacroKAuth.cmake. By the way, what about

Re: KDE/kdelibs/cmake/modules

2009-09-03 Thread Alexander Neundorf
On Thursday 03 September 2009, Dario Freddi wrote: First attempt to refactor. Problems: include paths seems not to work. It should include /usr/include/PolicyKit but somehow it does not work. Hints? NAMES should be followed by a header file name, e.g. PolicyKit/policykit.h (or something like

Re: KDE/kdelibs/cmake/modules

2009-09-03 Thread Alexander Neundorf
On Thursday 03 September 2009, Dario Freddi wrote: In data giovedì 03 settembre 2009 20:02:38, Alexander Neundorf ha scritto: Now that it is part of kdecore the searching for the installed files is not really necessary anymore. kauth/dbus_service.stub and kauth/dbus_policy.stub will be

Re: KDE/kdelibs/cmake/modules

2009-09-03 Thread Alexander Neundorf
On Thursday 03 September 2009, Andreas Pakulat wrote: On 03.09.09 20:08:17, Alexander Neundorf wrote: On Thursday 03 September 2009, Dario Freddi wrote: Also (sorry for flooding) just read about the cmake files needed to be sent to kde-buildsystem for review. So please, your target is

Re: KDE/kdelibs/cmake/modules

2009-09-03 Thread Andreas Pakulat
On 03.09.09 22:02:52, Alexander Neundorf wrote: On Thursday 03 September 2009, Andreas Pakulat wrote: On 03.09.09 20:08:17, Alexander Neundorf wrote: On Thursday 03 September 2009, Dario Freddi wrote: Also (sorry for flooding) just read about the cmake files needed to be sent to

Re: KDE/kdelibs/cmake/modules

2009-09-02 Thread Alexander Neundorf
On Wednesday 02 September 2009, Dario Freddi wrote: SVN commit 1018860 by dafre: Fix installation prefix, still need to spit a warning M +4 -1 FindPolkitQt.cmake CMake files which go into kdelibs/cmake/modules/ must follow the commit policy we have for them:

Re: KDE/kdelibs/cmake/modules

2009-09-02 Thread Alexander Neundorf
On Tuesday 01 September 2009, Raphael Kubo da Costa wrote: 2009/9/1 Dario Freddi drf54...@gmail.com: In every application using KAuth. Should I just put some comments or there's a syntax for that? usage guide is already in the kauth MainPage.dox All CMake files in kdelibs should have

Re: KDE/kdelibs/cmake/modules

2009-09-01 Thread Alexander Neundorf
On Wednesday 26 August 2009, Kevin Ottens wrote: SVN commit 1015825 by ervin: OK, my previous claim for r1015454 was wrong. The new behavior breaks old file in many more cases. Why do we need this option ? Are there otherwise name collisions ? So activating the new behavior only if the

Re: KDE/kdelibs/cmake/modules

2009-09-01 Thread Alexander Neundorf
On Monday 31 August 2009, Dario Freddi wrote: SVN commit 1017843 by dafre: Fix modules M +2 -0 MacroKAuth.cmake --- trunk/KDE/kdelibs/cmake/modules/MacroKAuth.cmake #1017842:1017843 @@ -55,7 +55,9 @@ COMMENT Generating ${HELPER_ID}.policy

Re: KDE/kdelibs/cmake/modules

2009-09-01 Thread Raphael Kubo da Costa
/kdelibs/cmake/modules/MacroKAuth.cmake #1017842:1017843 @@ -55,7 +55,9 @@                         COMMENT Generating ${HELPER_ID}.policy)      add_custom_target(actions for ${HELPER_ID} ALL DEPENDS ${_output}) +    if (POLKITQT_FOUND)      install(FILES ${_output} DESTINATION

KDE/kdelibs/cmake/modules

2009-08-25 Thread Kevin Ottens
a small adjustment in plasma desktop shell (committed a minute ago). CCMAIL: kde-buildsystem@kde.org M +25 -1 KDE4Macros.cmake --- trunk/KDE/kdelibs/cmake/modules/KDE4Macros.cmake #1015453:1015454 @@ -62,7 +62,26 @@ if(NOT ${_current_FILE} STREQUAL GENERATE_MOC

KDE/kdelibs/cmake/modules

2009-08-17 Thread David Faure
@kde.org M +1 -1 FindQt4.cmake --- trunk/KDE/kdelibs/cmake/modules/FindQt4.cmake #1012420:1012421 @@ -1335,7 +1335,7 @@ ENDIF (_customName) ADD_CUSTOM_COMMAND(OUTPUT ${_target} -COMMAND ${QT_DBUSCPP2XML_EXECUTABLE} ${_qt4_dbus_options} ${_in_file} ${_target

Re: KDE/kdelibs/cmake/modules

2009-07-30 Thread Alexander Neundorf
Sebastian, --- trunk/KDE/kdelibs/cmake/modules/FindSoprano.cmake #1004263:1004264 @@ -47,18 +47,6 @@ ${KDE4_INCLUDE_DIR} ) - # find the cmake macro file installed by soprano, relative to the include dir - get_filename_component(_SOPRANO_PREFIX ${SOPRANO_INCLUDE_DIR

Re: KDE/kdelibs/cmake/modules

2009-07-29 Thread Alexander Neundorf
FindSoprano.cmake --- trunk/KDE/kdelibs/cmake/modules/FindSoprano.cmake #1004263:1004264 @@ -47,18 +47,6 @@ ${KDE4_INCLUDE_DIR} ) - # find the cmake macro file installed by soprano, relative to the include dir - get_filename_component(_SOPRANO_PREFIX ${SOPRANO_INCLUDE_DIR} PATH

Re: KDE/kdelibs/cmake/modules

2009-07-29 Thread Sebastian Trüg
On Wednesday 29 July 2009 22:36:17 Alexander Neundorf wrote: Hi Sebastian, --- trunk/KDE/kdelibs/cmake/modules/FindSoprano.cmake #1004263:1004264 @@ -47,18 +47,6 @@ ${KDE4_INCLUDE_DIR} ) - # find the cmake macro file installed by soprano, relative to the include dir

Re: KDE4 on cygwin, was: Re: KDE/kdelibs/cmake/modules

2009-07-09 Thread Yaakov (Cygwin/X)
On 08/07/2009 10:07, Benjamin Reed wrote: Agreed. If they're using WIN32 as a check for Q_WS_WIN then they're doing it wrong. =) Perhaps I wasn't clear; I meant the CMake define WIN32, not the CPP #define. Cygwin gcc does not #define WIN32 by default anyway. Yaakov Cygwin Ports

Re: KDE4 on cygwin, was: Re: KDE/kdelibs/cmake/modules

2009-07-09 Thread Alexander Neundorf
Hi, On Wednesday 08 July 2009, Yaakov (Cygwin/X) wrote: On 07/07/2009 12:12, Alexander Neundorf wrote: I would suggest you try to get them first into cmake, and from there will will automatically flow into cygwin cmake. I'm not the Cygwin cmake package maintainer, so I would prefer to work

Re: KDE4 on cygwin, was: Re: KDE/kdelibs/cmake/modules

2009-07-08 Thread Benjamin Reed
On Tue, Jul 7, 2009 at 1:12 PM, Alexander Neundorfneund...@kde.org wrote: to make CMake behave correctly on Cygwin; one of those patches removes the WIN32 define on Cygwin, That doesn't sound like a good idea, since it still is WIN32, and all documentation and postings on the mailing list

Re: KDE4 on cygwin, was: Re: KDE/kdelibs/cmake/modules

2009-07-07 Thread Yaakov (Cygwin/X)
On 05/07/2009 11:23, Alexander Neundorf wrote: Is anybody trying to build KDE4 for cygwin ? Yes, me. When habacker and the kde-cygwin group changed focus to the native Win32 port of Qt/KDE, I began providing Qt3.3/KDE3.5 packages through my Cygwin Ports project. With an upcoming major update

KDE4 on cygwin, was: Re: KDE/kdelibs/cmake/modules

2009-07-05 Thread Alexander Neundorf
On Saturday 04 July 2009, Ralf Habacker wrote: Alexander Neundorf schrieb: On Thursday 02 July 2009, Ralf Habacker wrote: SVN commit 990260 by habacker: Account for CMAKE_EXECUTABLE_SUFFIX in KDE4_*_EXECUTABLE .shell names, since that is how they are created. by cygwin ports maintainer

Re: KDE/kdelibs/cmake/modules

2009-07-05 Thread Alexander Neundorf
On Thursday 29 January 2009, Christophe Giboudeaux wrote: On Wednesday 28 January 2009 22:44:00 Alexander Neundorf wrote: On Wednesday 28 January 2009, Christophe Giboudeaux wrote: SVN commit 917950 by cgiboudeaux: FindKdepim isn't (and shouldn't) be used anymore. Removing this

Re: KDE/kdelibs/cmake/modules

2009-07-05 Thread Christophe Giboudeaux
On Sunday 05 July 2009 22:38:43 Alexander Neundorf wrote: I just checked and found that this did not happen. Please add a FindKdepim.cmake which aborts with message(FATAL_ERROR ... ) with a useful error message. Please add this also in 4.3 branch. This is a source incompatible change, and

Re: KDE/kdelibs/cmake/modules

2009-05-29 Thread Ralf Habacker
M +46 -3 KDE4Macros.cmake A Win32.Manifest.in --- trunk/KDE/kdelibs/cmake/modules/CMakeLists.txt #972973:972974 @@ -1,5 +1,23 @@ +if (WIN32) +OPTION(KDE4_ENABLE_UAC_MANIFEST add manifest to make vista uac happy OFF) +if (KDE4_ENABLE_UAC_MANIFEST

Re: KDE/kdelibs/cmake/modules

2009-05-28 Thread Alexander Neundorf
A Win32.Manifest.in --- trunk/KDE/kdelibs/cmake/modules/CMakeLists.txt #972973:972974 @@ -1,5 +1,23 @@ +if (WIN32) +OPTION(KDE4_ENABLE_UAC_MANIFEST add manifest to make vista uac happy OFF) +if (KDE4_ENABLE_UAC_MANIFEST) +if (NOT MT_EXECUTABLE

  1   2   >