Review Request 129765: Handle the case of an enum with visibility attributes.

2017-01-03 Thread Shaheed Haque
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129765/ --- Review request for Extra Cmake Modules. Repository: extra-cmake-modules

Re: Review Request 129765: Handle the case of an enum with visibility attributes.

2017-01-04 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129765/#review101803 --- Hi Shaheed, Can you also add something to the unit test pyt

Re: Review Request 129765: Handle the case of an enum with visibility attributes.

2017-01-04 Thread Shaheed Haque
> On Jan. 4, 2017, 10:11 p.m., Stephen Kelly wrote: > > Hi Shaheed, > > > > Can you also add something to the unit test python code which asserts the > > (not zero) value of an enum with an attribute like this? > > > > Thanks, > > > > Steve. You mean to validate it can be read as expected? O

Re: Review Request 129765: Handle the case of an enum with visibility attributes.

2017-01-04 Thread Stephen Kelly
> On Jan. 4, 2017, 10:11 p.m., Stephen Kelly wrote: > > Hi Shaheed, > > > > Can you also add something to the unit test python code which asserts the > > (not zero) value of an enum with an attribute like this? > > > > Thanks, > > > > Steve. > > Shaheed Haque wrote: > You mean to validat

Re: Review Request 129765: Handle the case of an enum with visibility attributes.

2017-01-05 Thread Shaheed Haque
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129765/ --- (Updated Jan. 5, 2017, 8:31 a.m.) Review request for Extra Cmake Modules.

Re: Review Request 129765: Handle the case of an enum with visibility attributes.

2017-01-05 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129765/#review101825 --- Ship it! Perfect, thanks! I've cherry-picked (not merged)

Re: Review Request 129765: Handle the case of an enum with visibility attributes.

2017-01-05 Thread Shaheed Haque
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129765/ --- (Updated Jan. 5, 2017, 10:42 p.m.) Status -- This change has been ma