Re: kde4_add_test is not sufficient

2007-06-17 Thread Andreas Pakulat
On 14.06.07 22:15:53, Alexander Neundorf wrote: On Thursday 14 June 2007 20:59, Andreas Pakulat wrote: ... So I'll do the rename during the weekend (all of trunk/KDE), as the KProcess-Stuff is sorted out for kdelibs already. That is wherever currently kde4_add_test() and add_test() are

Re: kde4_add_test is not sufficient

2007-06-14 Thread Alexander Neundorf
On Thursday 14 June 2007 20:59, Andreas Pakulat wrote: ... So I'll do the rename during the weekend (all of trunk/KDE), as the KProcess-Stuff is sorted out for kdelibs already. That is wherever currently kde4_add_test() and add_test() are used it gets kde4_add_unit_test. Wherever kde4_add_test

Re: kde4_add_test is not sufficient

2007-06-09 Thread David Faure
On Friday 08 June 2007, Thiago Macieira wrote: Andreas Pakulat said: On 08.06.07 00:34:17, Alexander Neundorf wrote: Not sure we need this. If it just adds add_test() to kde4_add_test_executable() it might more confuse than help. Well, kde4_add_unit_test is simply just a little

Re: kde4_add_test is not sufficient

2007-06-08 Thread Andreas Pakulat
On 08.06.07 00:34:17, Alexander Neundorf wrote: On Thursday 07 June 2007 03:00, David Faure wrote: The naming is a bit unfortunate IMHO. kde4_add_test is called this way to look like kde4_add_executable, i.e. build this test program (which could be automated or interactive). But CMake's

Re: kde4_add_test is not sufficient

2007-06-08 Thread Thiago Macieira
Andreas Pakulat said: On 08.06.07 00:34:17, Alexander Neundorf wrote: Not sure we need this. If it just adds add_test() to kde4_add_test_executable() it might more confuse than help. Well, kde4_add_unit_test is simply just a little convenience macro to not having to remember to use both

Re: kde4_add_test is not sufficient

2007-06-07 Thread David Faure
On Wednesday 06 June 2007, Andreas Pakulat wrote: On 05.06.07 19:33:55, Thiago Macieira wrote: Andreas Pakulat wrote: Hi, I'd like to know wether its expected that one needs both kde4_add_test and add_test to make tests work even if KDE4_BUILD_TESTS was set to off? If one doesn't

Re: kde4_add_test is not sufficient

2007-06-05 Thread Thiago Macieira
Andreas Pakulat wrote: Hi, I'd like to know wether its expected that one needs both kde4_add_test and add_test to make tests work even if KDE4_BUILD_TESTS was set to off? If one doesn't tell cmake via add_test() that a testcase exists the make test target doesn't find any tests, even after

Re: kde4_add_test is not sufficient

2007-06-05 Thread Andreas Pakulat
On 05.06.07 19:33:55, Thiago Macieira wrote: Andreas Pakulat wrote: Hi, I'd like to know wether its expected that one needs both kde4_add_test and add_test to make tests work even if KDE4_BUILD_TESTS was set to off? If one doesn't tell cmake via add_test() that a testcase exists the make

Re: kde4_add_test is not sufficient

2007-06-05 Thread Alexander Neundorf
On Tuesday 05 June 2007 19:04, Andreas Pakulat wrote: On 05.06.07 19:33:55, Thiago Macieira wrote: Andreas Pakulat wrote: Hi, I'd like to know wether its expected that one needs both kde4_add_test and add_test to make tests work even if KDE4_BUILD_TESTS was set to off? If one