Re: windows build

2006-06-27 Thread Peter Kümmel
Thiago Macieira wrote: > According to our developers, the problem is that I'm exporting it in > QDBusMessage and there's probably a way of hiding that (probably by > removing inlines). Maybe this does help: http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=100739 _

Re: windows build

2006-06-27 Thread Peter Kümmel
Thiago Macieira wrote: > Peter Kümmel wrote: >> To fix the linker error we just have to show >> the compiler qdbusmessage.h and all is fine. > > This is wrong too. What happens when the next class inheriting from > QList shows up? > I know, but it is the best and simplest what we can do at the

Re: windows build

2006-06-27 Thread Thiago Macieira
Peter Kümmel wrote: >To fix the linker error we just have to show >the compiler qdbusmessage.h and all is fine. This is wrong too. What happens when the next class inheriting from QList shows up? According to our developers, the problem is that I'm exporting it in QDBusMessage and there's proba

RE: windows build

2006-06-27 Thread Paulo Jorge Guedes
> -Original Message- > From: Peter Kümmel [mailto:[EMAIL PROTECTED] > Sent: terça-feira, 27 de Junho de 2006 15:20 > To: kde-buildsystem@kde.org > Subject: Re: windows build > > Paulo Jorge Guedes wrote: > >> -Original Message- > >> From

Re: windows build

2006-06-27 Thread Peter Kümmel
Paulo Jorge Guedes wrote: >> -Original Message- >> From: Peter Kümmel [mailto:[EMAIL PROTECTED] >> Sent: terça-feira, 27 de Junho de 2006 15:08 >> To: kde-buildsystem@kde.org >> Subject: Re: windows build >> >> Paulo Jorge Guedes wrote: >>

RE: windows build

2006-06-27 Thread Paulo Jorge Guedes
> -Original Message- > From: Peter Kümmel [mailto:[EMAIL PROTECTED] > Sent: terça-feira, 27 de Junho de 2006 15:08 > To: kde-buildsystem@kde.org > Subject: Re: windows build > > Paulo Jorge Guedes wrote: > > > > Perhaps you should add some comment expla

Re: windows build

2006-06-27 Thread Peter Kümmel
Paulo Jorge Guedes wrote: > > Perhaps you should add some comment explaining why the include is needed. > You are right, this would prevent the removing. I could also only include when compiled under windows. But is the minimal speed up under linux worth an additional ifdef? Peter

RE: windows build

2006-06-27 Thread Paulo Jorge Guedes
> -Original Message- > From: Peter Kümmel [mailto:[EMAIL PROTECTED] > Sent: terça-feira, 27 de Junho de 2006 14:56 > To: kde-buildsystem@kde.org > Subject: Re: windows build > > Paulo Jorge Guedes wrote: > >> > >> $ svn diff

Re: windows build

2006-06-27 Thread Peter Kümmel
Peter Kümmel wrote: > Paulo Jorge Guedes wrote: >>> $ svn diff kconfigbase.h >>> Index: kconfigbase.h >>> === >>> --- kconfigbase.h (revision 555414) >>> +++ kconfigbase.h (working copy) >>> @@ -27,6 +27,7 @@ >>> #include

Re: windows build

2006-06-27 Thread Peter Kümmel
Paulo Jorge Guedes wrote: >> >> $ svn diff kconfigbase.h >> Index: kconfigbase.h >> === >> --- kconfigbase.h (revision 555414) >> +++ kconfigbase.h (working copy) >> @@ -27,6 +27,7 @@ >> #include >> #include >> #includ

RE: windows build

2006-06-27 Thread Paulo Jorge Guedes
> -Original Message- > From: Peter Kümmel [mailto:[EMAIL PROTECTED] > Sent: terça-feira, 27 de Junho de 2006 13:26 > To: kde-buildsystem@kde.org > Subject: Re: windows build > > I think now I understand a little bit > better what's going on: > >

Re: windows build

2006-06-27 Thread Peter Kümmel
I think now I understand a little bit better what's going on: QList is automatically instantiated because of the inheritance in qdbusmessage.h But when compiling kdecore, this is not known, so the compiler instantiates QList again, and we get the linker error. To fix the linker error we just hav

Re: windows build

2006-06-27 Thread Peter Kümmel
Thiago Macieira wrote: > Peter Kümmel wrote: >> Thiago Macieira wrote: >>> It looks like this is being caused by the KDE-side of things. Why >>> should kauthorized.obj define the QList::isEmpty() and >>> *export* it? That's an inline method defined in qlist.h. >> Does it export it? kauthorized has

RE: windows build

2006-06-27 Thread Paulo Jorge Guedes
> -Original Message- > From: Peter Kümmel [mailto:[EMAIL PROTECTED] > Sent: terça-feira, 27 de Junho de 2006 10:20 > To: kde-buildsystem@kde.org > Subject: Re: windows build > > Thiago Macieira wrote: > > Peter Kümmel wrote: > >> Thiago Macieira wrot

Re: windows build

2006-06-27 Thread Peter Kümmel
Thiago Macieira wrote: > Peter Kümmel wrote: >> Thiago Macieira wrote: >>> It looks like this is being caused by the KDE-side of things. Why >>> should kauthorized.obj define the QList::isEmpty() and >>> *export* it? That's an inline method defined in qlist.h. >> Does it export it? kauthorized has

Re: windows build

2006-06-27 Thread Thiago Macieira
Peter Kümmel wrote: >Thiago Macieira wrote: >> It looks like this is being caused by the KDE-side of things. Why >> should kauthorized.obj define the QList::isEmpty() and >> *export* it? That's an inline method defined in qlist.h. > >Does it export it? kauthorized has its own instantiation and this

Re: windows build

2006-06-27 Thread Peter Kümmel
Thiago Macieira wrote: > It looks like this is being caused by the KDE-side of things. Why should > kauthorized.obj define the QList::isEmpty() and *export* it? > That's an inline method defined in qlist.h. Does it export it? kauthorized has its own instantiation and this one conflicts with the

Re: windows build

2006-06-27 Thread Peter Kümmel
Thiago Macieira wrote: > Peter Kümmel wrote: >> I've tried to reproduce the linker error without success. >> (two dlls, one links against the other, template A, a class >> which inherits from A, ...) >> Maybe there is only one constellation which reproduce it. >> >> But even if I could reproduce it

Re: windows build

2006-06-27 Thread Thiago Macieira
Peter Kümmel wrote: >I've tried to reproduce the linker error without success. >(two dlls, one links against the other, template A, a class >which inherits from A, ...) >Maybe there is only one constellation which reproduce it. > >But even if I could reproduce it, it only shows that it is a compile

Re: windows build

2006-06-27 Thread Peter Kümmel
Thiago Macieira wrote: > Christian Ehrlicher wrote: >> Q_CORE_EXPORT is correct - it must be an export in *every* lib it is >> used (because of this it's KDE_EXPORT and not KIO_EXPORT) > > Then no, this isn't the same at all. Q_CORE_EXPORT means export from > QtCore (which is where QList comes fr

Re: windows build

2006-06-26 Thread Thiago Macieira
Christian Ehrlicher wrote: > >Q_CORE_EXPORT is correct - it must be an export in *every* lib it is >used (because of this it's KDE_EXPORT and not KIO_EXPORT) Then no, this isn't the same at all. Q_CORE_EXPORT means export from QtCore (which is where QList comes from and, more to the point QVaria

Re: windows build

2006-06-26 Thread Christian Ehrlicher
Peter Kümmel schrieb: > Thiago Macieira wrote: >> Peter Kümmel wrote: >>> +#ifdef Q_OS_WIN >>> +template class QDBUS_EXPORT QList; >>> +#endif >> Shouldn't this be Q_CORE_EXPORT? >> > > Oh, Q_CORE_EXPORT isn't a kdelibs macro, > so maybe you are right. > > I couldn't remember what the difference

Re: windows build

2006-06-26 Thread Peter Kümmel
Thiago Macieira wrote: > Peter Kümmel wrote: >> +#ifdef Q_OS_WIN >> +template class QDBUS_EXPORT QList; >> +#endif > > Shouldn't this be Q_CORE_EXPORT? > Oh, Q_CORE_EXPORT isn't a kdelibs macro, so maybe you are right. I couldn't remember what the difference is between KDE_EXPORT and KIO_EXPOR

Re: windows build

2006-06-26 Thread Peter Kümmel
Thiago Macieira wrote: > Peter Kümmel wrote: >> +#ifdef Q_OS_WIN >> +template class QDBUS_EXPORT QList; >> +#endif > > Shouldn't this be Q_CORE_EXPORT? The file is part of qt-dbus and I don't think qtdbus does anything know from kdelibs/Q_CORE_EXPORT. I've compared the code with the kio/kio/glo

Re: windows build

2006-06-26 Thread Thiago Macieira
Peter Kümmel wrote: >+#ifdef Q_OS_WIN >+template class QDBUS_EXPORT  QList; >+#endif Shouldn't this be Q_CORE_EXPORT? -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org thiago.macieira (AT) trolltech.com Trolltech ASA GPG: 0x6EF45358 | Sandakervei

Re: windows build

2006-06-26 Thread Peter Kümmel
Peter Kuemmel wrote: > --- Bill Hoffman <[EMAIL PROTECTED]> wrote: >> There seems to be an issue with dbus on windows: >> >> dbus-qt4-1.lib(dbus-qt4-1.dll) : error LNK2005: >> "public: bool __thiscall QList> QVariant>::isEmpty(void)const " >> ([EMAIL PROTECTED]@VQVariantQBE_NXZ) already >> defi

Re: windows build

2006-06-26 Thread Peter Kuemmel
--- Bill Hoffman <[EMAIL PROTECTED]> wrote: > So, the dashboard is looking better these days. > The build errors on dash17 should be cleared up > tomorrow. > However, we had to move the windows builds to the > experimental section. > > There seems to be an issue with dbus on windows: > > dbu

windows build

2006-06-26 Thread Bill Hoffman
So, the dashboard is looking better these days. The build errors on dash17 should be cleared up tomorrow. However, we had to move the windows builds to the experimental section. There seems to be an issue with dbus on windows: dbus-qt4-1.lib(dbus-qt4-1.dll) : error LNK2005: "public: bool __this

windows build is broken

2006-04-14 Thread Bill Hoffman
The windows build is trying to include X11 header files: In file included from D:\dashboard\kdelibs\kdeui\/kkeyserver.h:27, from D:\dashboard\kdelibs\kdeui\kshortcutdialog.cpp:44: D:\dashboard\kdelibs\kdeui\/kkeyserver_x11.h:27:22: X11/Xlib.h: No such file or directory http