Re: Review Request: Adding net usershare suport for KSambaShare

2010-11-30 Thread Rodrigo Belem
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4320/ --- (Updated 2010-11-30 00:40:10.025557) Review request for kdelibs, Raphael

Re: Review Request: KDateEdit moving into kdelibs

2010-11-30 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6014/#review9054 --- The code is based on an old version of KDateEdit - the feature in

Re: Helping libraries load their own translation catalogs

2010-11-30 Thread Albert Astals Cid
A Diumenge, 28 de novembre de 2010, Albert Astals Cid va escriure: A Diumenge, 28 de novembre de 2010, Ivan Cukic va escriure: On Monday, 22. November 2010. 19.05.45 Albert Astals Cid wrote: A Dilluns, 22 de novembre de 2010, David Faure va escriure: On Sunday 21 November 2010, Oswald

Re: Review Request: Adds method to KBookmarkManager disable showing dialogs on errors.

2010-11-30 Thread Matthias Fuchs
On 2010-11-29 00:08:22, Albert Astals Cid wrote: Why did you change the if/else logic? Also you added another kError when there was an existing one already. Also as commented on IRC maybe it would make sense to emit a signal to warn whoever might be interested that an error

Re: Review Request: Adds method to KBookmarkManager disable showing dialogs on errors.

2010-11-30 Thread Matthias Fuchs
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/ --- (Updated 2010-11-30 20:57:03.986026) Review request for kdelibs and David

Re: Review Request: Adding net usershare suport for KSambaShare

2010-11-30 Thread Rodrigo Belem
On 2010-11-19 02:36:54, Raphael Kubo da Costa wrote: I think we're finally getting there :) dfaure might know better about the KDirWatch stuff; apart from that, the appropriate @since tags need to be added, as well as the missing method apidox. After that it's probably r+ from me.