Hi.
On Fri, Dec 10, 2010 at 1:03 AM, Jaime wrote:
> You're right. I forgot about the tests that check something will fail
> with invalid input.
>
> Rigtht now, I only get 3 failures in nepomuk (without QT_FATAL_WARNINGS).
>
Which tests don't pass in Nepomuk? I just tried the tests in
kdelibs/ne
> On 2010-12-09 23:41:39, Christoph Feck wrote:
> > The changes are fine, I just don't like the filmstrip.h file. The upstream
> > project has to use it, because it doesn't have a way to paint on a QImage.
> > But if you want to work on it later, please commit this for now, too small
> > holes
On Friday, December 3, 2010, David Faure wrote:
> I guess your point is "KDialog should remember and make the button default
> once it exists". Hmm. It can be done indeed. I don't know if it's worth the
> additional complexity, but if you feel this should work, please review the
> attached patch. U
On Thursday 09 December 2010, Aurélien Gâteau wrote:
> On 09/12/2010 17:52, David Faure wrote:
> > On Tuesday 07 December 2010, Jaime wrote:
> >> Hi,
> >>
> >>I've run the kdelibs with the environment variable
> >>QT_FATAL_WARNINGS=1,
> >>
> >> and the number of failed tests has grown in
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5937/#review9191
---
Ship it!
The changes are fine, I just don't like the filmstrip.h
> On 2010-11-22 21:10:52, Christoph Feck wrote:
> > Wouldn't it be much simpler to use a scaled QPainter on the QImage to
> > render the filmstrip holes at different sizes?
>
> Thomas Lübking wrote:
> ... besides that the (hard)code(d strips - at least form a glimpse on the
> diff) does no
On 09/12/2010 17:52, David Faure wrote:
On Tuesday 07 December 2010, Jaime wrote:
Hi,
I've run the kdelibs with the environment variable QT_FATAL_WARNINGS=1,
and the number of failed tests has grown in a noticeable way. (also with 2
crashes).
I guess that less Qt warnings usually means l
On Thursday 09 December 2010, David Faure wrote:
> > On Monday 29 November 2010, David Faure wrote:
> > > On Monday 09 August 2010, Volker Krause wrote:
> > > > It also has a test that makes sure all headers compile with strict
> > > > flags (QT_NO_CAST_FROM_ASCII, etc), might be interesting for kd
You're right. I forgot about the tests that check something will fail
with invalid input.
Rigtht now, I only get 3 failures in nepomuk (without QT_FATAL_WARNINGS).
And kglobaltest fails only when I have QT_NO_GLIB=1 (I used to have it
because of flash plugin, but not any longer).
I'll check from
> On Monday 29 November 2010, David Faure wrote:
> > On Monday 09 August 2010, Volker Krause wrote:
> > > It also has a test that makes sure all headers compile with strict
> > > flags (QT_NO_CAST_FROM_ASCII, etc), might be interesting for kdelibs as
> > > well.
> >
> > Yep, very interesting, I ju
On Tuesday 07 December 2010, Jaime wrote:
> Hi,
>
> I've run the kdelibs with the environment variable QT_FATAL_WARNINGS=1,
> and the number of failed tests has grown in a noticeable way. (also with 2
> crashes).
>
> I guess that less Qt warnings usually means less unexpected crashes.
> The
11 matches
Mail list logo