Review Request: PATCH: Use 'getifaddrs' instead of 'gethostname+gethostbyname' in kpac_dhcp_helper

2011-03-28 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100964/ --- Review request for kdelibs. Summary --- The kpac_dhcp_helper, the hel

Re: Review Request: PATCH: FTP handle files that start or stop with whitespaces

2011-03-28 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100943/ --- (Updated March 28, 2011, 8:31 p.m.) Review request for kdelibs and David F

Re: Review of the branch plasma/declarative in kdelibs

2011-03-28 Thread Marco Martin
On Tuesday 22 February 2011, Stephen Kelly wrote: > Marco Martin wrote: > > Hi all, > > in kdelibs there is since some time a branch called plasma/declarative > > that contains a new little library, that depends at the moment on kdecore > > and kdeui (probably is possible to make it depend only fro

Re: Review Request: A new autoptr class for QPointer.

2011-03-28 Thread Milian Wolff
> On March 26, 2011, 1:20 p.m., Alex Merry wrote: > > Do we still want this? We now have QScopedPointer, but it doesn't do quite > > what this does (it doesn't watch for QObjects being deleted). Imo this should not go into kdelibs, as QPointer is notoriously slow and it's advised to use QWeak