Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

2011-05-08 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101312/ --- Review request for kdelibs. Summary --- This dialogue - used, for

Re: Review Request: KMessageWidget: Adapt height to text changes

2011-05-08 Thread Matthias Fuchs
On May 2, 2011, 5:49 p.m., Aurélien Gâteau wrote: Thanks for the patch Mattias! This is indeed an annoying bug but your fix does not work when the widget is resized. heightForWidth() needs to be implemented I think. The problem is that resizing takes no effect yet either. Here without

Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

2011-05-08 Thread Parker Coates
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101312/#review3200 --- Adding some before and after screenshots would probably get you

Review Request: Fix timer leak in KWalletD

2011-05-08 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101313/ --- Review request for KDE Runtime and Michael Leupold. Summary ---

Review Request: Fix KAuth::Action::execute() not returning error description string

2011-05-08 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101314/ --- Review request for kdelibs and Dario Freddi. Summary ---

svn - git transition status ?

2011-05-08 Thread Alexander Neundorf
Hi, what's the current status with our svn to git transition ? There are still several modules in svn (kdeaccessibility, kdeadmin, kdeartwork, kdebindings, kdegames, kdegraphics, kdemultimedia, kdenetwork, kdesdk, kdetoys, kdeutils, kdewebdev). Is it planned to move them also to git ? Is

Re: svn - git transition status ?

2011-05-08 Thread Raphael Kubo da Costa
Alexander Neundorf neund...@kde.org writes: what's the current status with our svn to git transition ? There are still several modules in svn (kdeaccessibility, kdeadmin, kdeartwork, kdebindings, kdegames, kdegraphics, kdemultimedia, kdenetwork, kdesdk, kdetoys, kdeutils, kdewebdev).

Re: svn - git transition status ?

2011-05-08 Thread todd rme
On Sun, May 8, 2011 at 12:44 PM, Raphael Kubo da Costa kub...@gmail.com wrote: Alexander Neundorf neund...@kde.org writes: The rest of the modules are at an unknown/early/inexistent migration state. Weren't there issues with kdeartwork and GIT because of the large number of binary files

Re: svn - git transition status ?

2011-05-08 Thread Stefan Majewsky
On Sun, May 8, 2011 at 6:52 PM, todd rme toddrme2...@gmail.com wrote: Weren't there issues with kdeartwork and GIT because of the large number of binary files (like wallpapers)? The same (still unresolved) issues are with kdegames, which has 400 MB of history just for data files (which make up

Changing the defaults for HTTP ACCEPT, ACCEPT-LANGUAGE and USERAGENT headers

2011-05-08 Thread Dawit A
In hopes of making Konqueror's default settings for the aforementioned HTTP headers inline with other browsers, I want to change the default settings for these three header as outlined below. ** Please note that this only affects the default! Each and every application can tell the ioslave what

Re: Changing the defaults for HTTP ACCEPT, ACCEPT-LANGUAGE and USERAGENT headers

2011-05-08 Thread Maksim Orlovich
1) Does this actually fix anything? Did you do any testing? 2) 'like Gecko' was added by Apple guys for a very good reason (UA sniffing) 3) It would be incorrect to add xhtml accepts to khtml's accept-type. XHTML parsing is buggy, and isn't really worth prioritizing fixing (on accounts on

Re: Review Request: Fix the layout of KNameAndUrlInputDialog (kfile)

2011-05-08 Thread Jonathan Marten
On May 8, 2011, 9:03 p.m., Michael Pyne wrote: kfile/knameandurlinputdialog.cpp, line 67 http://git.reviewboard.kde.org/r/101312/diff/1/?file=16267#file16267line67 It is inappropriate to create QWidgets that have no parent, unless you have a different means of ensuring they're