Re: SSL in KDE going forward

2011-06-09 Thread Hasso Tepper
On 08.06.11; 24. nädal 23:24, Dawit A wrote: Would asking for client certficate authentication support be out of the scope or does Qt's SSL already support that ? Last I checked it did not and there is a pending but report about this against kio_http. See

Review Request: Show the correct url in Konqueror when switching to tabs after clearing location bar.

2011-06-09 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101558/ --- Review request for KDE Base Apps. Summary --- Show the correct url

Re: Review Request: Use QDirIterator in KStandardDirs

2011-06-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101554/#review3799 --- my biggest question with this change would be performance.

Re: KDE git workflow

2011-06-09 Thread David Jarvie
On Wed, June 8, 2011 6:03 pm, Cornelius Schumacher wrote: As you already know, we have discussed the git workflow for KDE at the Platform 11 sprint, and have come up with a recommendation. Please find the full text here: http://community.kde.org/KDE_Core/Platform_11/Git_Workflow The core

Re: KDE at the Qt Contributors Summit

2011-06-09 Thread John Layt
On Thursday 09 Jun 2011 15:31:42 John Layt wrote: We would like to co-ordinate our efforts at QtCS to ensure the best possible outcome for KDE and Qt. To help this we would like all KDE community members attending to list their name on the KDE at QtCS wiki page [2]. Please indicate if you

Re: KDE git workflow

2011-06-09 Thread Torgny Nyblom
On Wednesday 08 June 2011 19.03.01 Cornelius Schumacher wrote: As you already know, we have discussed the git workflow for KDE at the Platform 11 sprint, and have come up with a recommendation. Please find the full text here: http://community.kde.org/KDE_Core/Platform_11/Git_Workflow Local

Re: KDE git workflow

2011-06-09 Thread Cornelius Schumacher
On Thursday 09 June 2011 Maksim Orlovich wrote: Will we have a single person review every single commit to master, too? We don't have formal rules about who reviews commits. That will be done by the developers and maintainers who care, just like it is done now. We might have a Aaron's

Review Request: Fix crash in KDirLister

2011-06-09 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101560/ --- Review request for kdelibs. Summary --- Attached patch fixes a crash

Re: KDE git workflow

2011-06-09 Thread David Jarvie
On Thu, June 9, 2011 5:22 pm, Cornelius Schumacher wrote: On Thursday 09 June 2011 Maksim Orlovich wrote: And what if there are multiple branches on the same module at the same time? Which one of these branches, or master (or release?) is going to get testing coverage? The idea is that, if

Re: KDE git workflow

2011-06-09 Thread Cornelius Schumacher
On Thursday 09 June 2011 Torgny Nyblom wrote: This part I fully agree with, however later in the example section it seems like rebasing should be done prior to review. Is the examples correct? The examples need some reality check, ideally with detailed actual git commands. In general it's a

Re: KDE git workflow

2011-06-09 Thread Cornelius Schumacher
On Thursday 09 June 2011 David Jarvie wrote: In order to get good testing coverage, there should normally only be one integration branch per git module. Otherwise, testing coverage will be split between the competing integration branches. Right. -- Cornelius Schumacher schumac...@kde.org

Re: KDE git workflow

2011-06-09 Thread John Layt
On Thursday 09 Jun 2011 17:34:57 Cornelius Schumacher wrote: On Thursday 09 June 2011 Torgny Nyblom wrote: This part I fully agree with, however later in the example section it seems like rebasing should be done prior to review. Is the examples correct? The examples need some reality

Re: Review Request: Use QDirIterator in KStandardDirs

2011-06-09 Thread Jarosław Staniek
On June 9, 2011, 9:49 a.m., Aaron J. Seigo wrote: my biggest question with this change would be performance. QFileInfo is not fast, and to make matters worse this code in KStandardDirs influences start up speed. have you measured the performance after this change relative to before?

Re: SSL in KDE going forward

2011-06-09 Thread Richard Moore
On Thu, Jun 9, 2011 at 8:16 AM, Hasso Tepper ha...@kde.org wrote: On 08.06.11; 24. nädal 23:24, Dawit A wrote: Would asking for client certficate authentication support be out of the scope or does Qt's SSL already support that ? Last I checked it did not and there is a pending but report about

Re: SSL in KDE going forward

2011-06-09 Thread Richard Moore
On Wed, Jun 8, 2011 at 9:24 PM, Dawit A ada...@kde.org wrote: Would asking for client certficate authentication support be out of the scope or does Qt's SSL already support that ? Last I checked it did not and there is a pending but report about this against kio_http. See

Re: KDE git workflow

2011-06-09 Thread Cornelius Schumacher
On Thursday 09 June 2011 John Layt wrote: Besides the inconsistency that Torgey also found, the one part of the command flow I'm wondering about is whether for the simple workflow we tell them to push or merge their commits into master? If it's a local branch, rebase the branch, merge it to

Re: KDE git workflow

2011-06-09 Thread Aaron J. Seigo
On Thursday, June 9, 2011 13:50:59 David Jarvie wrote: One side effect of using integration branches in what used to be kdelibs/kdepimlibs/kdebase is that new features aren't likely to be widely tested until later in the development cycle than previously. features should not remain in