Re: CDash of kdelibs

2011-07-17 Thread Rolf Eike Beer
Am Sonntag, 17. Juli 2011, 12:47:36 schrieb Rolf Eike Beer: > When I look at the kdelibs test results at > http://my.cdash.org/index.php?project=kdelibs I see the following things > that IMHO need to be changed: > > -the limit of 3000 warnings is reached, do we need to increase the limit? We don'

Re: RFC: replacing MacroLogFeature.cmake with FeatureSummary.cmake

2011-07-17 Thread David Jarvie
On Wednesday 13 July 2011 20:16:58 Alexander Neundorf wrote: > Hi, > > in KDE we have the file MacroLogFeature.cmake which we use to print a summary > of found/missing packages at the end of a cmake run. > I added similar functionality later on in 2007 to cmake in the form of > FeatureSummary.cm

Re: Review Request: Use platform palette and fonts when running on other desktop environments

2011-07-17 Thread Aurélien Gâteau
> On July 2, 2011, 9:49 p.m., Oswald Buddenhagen wrote: > > hmm. but now things are still done twice in a kde session, no? > > what was wrong with the suggestion to notify qt that it should update > > "stuff"? > > Aurélien Gâteau wrote: > createApplicationPalette() is indeed called twice wh

Re: Review Request: Make mouse cursor size configurable

2011-07-17 Thread Chusslove Illich
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: RFC: replacing MacroLogFeature.cmake with FeatureSummary.cmake

2011-07-17 Thread Alexander Neundorf
Ok, there is now a branch FeatureSummaryImprovements on the cmake stage: http://cmake.org/gitweb?p=stage/cmake.git;a=shortlog;h=refs/heads/FeatureSummaryImprovements It should have everything discussed here: * every package can have multiple PURPOSEs * every package has a dependency TYPE: RUNTIME

Re: cpp includes in http ioslave

2011-07-17 Thread Rolf Eike Beer
Am Sonntag, 17. Juli 2011, 20:58:09 schrieb Rolf Eike Beer: > Am Sonntag, 17. Juli 2011, 20:28:44 schrieb Rolf Eike Beer: > > Am Sonntag, 17. Juli 2011, 13:14:39 schrieb Dawit A: > > > No objection to the cleanup, but please do not do it until I commit > > > my > > > changes. I haved added a new un

Re: Review Request: Make mouse cursor size configurable

2011-07-17 Thread Lukas Sommer
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: cpp includes in http ioslave

2011-07-17 Thread Rolf Eike Beer
Am Sonntag, 17. Juli 2011, 20:28:44 schrieb Rolf Eike Beer: > Am Sonntag, 17. Juli 2011, 13:14:39 schrieb Dawit A: > > No objection to the cleanup, but please do not do it until I commit my > > changes. I haved added a new unit test for http authentication after > > fixing the test cases that were

Re: cpp includes in http ioslave

2011-07-17 Thread Rolf Eike Beer
Am Sonntag, 17. Juli 2011, 13:14:39 schrieb Dawit A: > On Sun, Jul 17, 2011 at 6:38 AM, Rolf Eike Beer > > wrote: > > When one looks at kioslave/http/http.cpp it finds things like this: > > > > //string parsing helpers and HeaderTokenizer implementation > > #include "parsinghelpers.cpp" > > //au

Re: cpp includes in http ioslave

2011-07-17 Thread Dawit A
On Sun, Jul 17, 2011 at 6:38 AM, Rolf Eike Beer wrote: > When one looks at kioslave/http/http.cpp it finds things like this: > > //string parsing helpers and HeaderTokenizer implementation > #include "parsinghelpers.cpp" > //authentication handlers > #include "httpauthentication.cpp" > > Which hap

Re: CDash of kdelibs

2011-07-17 Thread Rolf Eike Beer
Am Sonntag 17 Juli 2011, 12:58:35 schrieben Sie: > On Sunday 17 July 2011, Rolf Eike Beer wrote: > > -the moc files are counted in the coverage results even if > > CTestConfig.cmake contains > > > > set(CTEST_CUSTOM_COVERAGE_EXCLUDE ".moc$" "moc_" "ui_") > > > > So something is wrong there. This

Re: Review Request: Make mouse cursor size configurable

2011-07-17 Thread Chusslove Illich
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: CDash of kdelibs

2011-07-17 Thread Alexander Neundorf
On Sunday 17 July 2011, Rolf Eike Beer wrote: > When I look at the kdelibs test results at > http://my.cdash.org/index.php?project=kdelibs I see the following things > that IMHO need to be changed: > > -the limit of 3000 warnings is reached, do we need to increase the limit? I don't think having

CDash of kdelibs

2011-07-17 Thread Rolf Eike Beer
When I look at the kdelibs test results at http://my.cdash.org/index.php?project=kdelibs I see the following things that IMHO need to be changed: -the limit of 3000 warnings is reached, do we need to increase the limit? -the moc files are counted in the coverage results even if CTestConfig.cmak

cpp includes in http ioslave

2011-07-17 Thread Rolf Eike Beer
When one looks at kioslave/http/http.cpp it finds things like this: //string parsing helpers and HeaderTokenizer implementation #include "parsinghelpers.cpp" //authentication handlers #include "httpauthentication.cpp" Which happens because e.g. parsinghelpers.cpp only consist of static functions

Re: Review Request: Make mouse cursor size configurable

2011-07-17 Thread Lukas Sommer
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: Review Request: Use platform palette and fonts when running on other desktop environments

2011-07-17 Thread Dominik Haumann
> On July 2, 2011, 9:49 p.m., Oswald Buddenhagen wrote: > > hmm. but now things are still done twice in a kde session, no? > > what was wrong with the suggestion to notify qt that it should update > > "stuff"? > > Aurélien Gâteau wrote: > createApplicationPalette() is indeed called twice wh

Re: Review Request: Only include nepomuk directories if nepomuk is available

2011-07-17 Thread Laszlo Papp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101949/#review4755 --- Ship it! The compilation issue was not personally talkative eno

Re: Review Request: Use platform palette and fonts when running on other desktop environments

2011-07-17 Thread Thomas Lübking
> On July 2, 2011, 9:49 p.m., Oswald Buddenhagen wrote: > > hmm. but now things are still done twice in a kde session, no? > > what was wrong with the suggestion to notify qt that it should update > > "stuff"? > > Aurélien Gâteau wrote: > createApplicationPalette() is indeed called twice wh