Re: Review Request: Allow externally deleted files to be removed from view in Dolphin

2011-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102435/#review6019 --- This review has been submitted with commit

Re: Review Request: Allow externally deleted files to be removed from view in Dolphin

2011-08-26 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102435/#review6020 --- Ship it! Thanks for the patch, works nice! I've added a small

4.7 mergable into frameworks. No need to cherry-pick

2011-08-26 Thread Stephen Kelly
Hi, I merged the 4.7 branch into frameworks recently. Now it's easy to merge again, so no need to cherry-pick when you fix things in 4.7. You can merge instead. Thanks, Steve.

Re: git workflow draft

2011-08-26 Thread Stephen Kelly
Alexander Neundorf wrote: No branches should be prefixed with KDE; we consider that a reserved name. Nor topic should branches be numeric in nature (such as a version number) as those are reserved for actual release branches. (Sys admin at the meeting indicated that it is likely

Re: 4.7 mergable into frameworks. No need to cherry-pick

2011-08-26 Thread David Faure
On Friday 26 August 2011 12:04:29 Stephen Kelly wrote: Hi, I merged the 4.7 branch into frameworks recently. Now it's easy to merge again, so no need to cherry-pick when you fix things in 4.7. You can merge instead. OK, how do I do that exactly? Commit in 4.7, fetch in frameworks, then

Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-26 Thread David Faure
On Thursday 25 August 2011 19:23:10 Alexander Potashev wrote: 2011/8/25 Albert Astals Cid aa...@kde.org: The point is that usually you do not know what the library will end up doing and by using d-pointers everywhere you make it easier for yourself to maintain binary compatibility in the

Re: playground-libs/libkvkontakte has moved to kdereview

2011-08-26 Thread Thomas Zander
On Thursday 25 August 2011 19.23.10 Alexander Potashev wrote: 2011/8/25 Albert Astals Cid aa...@kde.org: The point is that usually you do not know what the library will end up doing and by using d-pointers everywhere you make it easier for yourself to maintain binary compatibility in the

Re: 4.7 mergable into frameworks. No need to cherry-pick

2011-08-26 Thread Stephen Kelly
David Faure wrote: On Friday 26 August 2011 12:04:29 Stephen Kelly wrote: Hi, I merged the 4.7 branch into frameworks recently. Now it's easy to merge again, so no need to cherry-pick when you fix things in 4.7. You can merge instead. OK, how do I do that exactly? Commit in 4.7, fetch

Re: 4.7 mergable into frameworks. No need to cherry-pick

2011-08-26 Thread Michael Jansen
On Friday, August 26, 2011 01:28:01 PM Stephen Kelly wrote: David Faure wrote: On Friday 26 August 2011 12:04:29 Stephen Kelly wrote: Hi, I merged the 4.7 branch into frameworks recently. Now it's easy to merge again, so no need to cherry-pick when you fix things in 4.7. You can

Re: System clock change notification

2011-08-26 Thread Aaron J. Seigo
On Tuesday, August 23, 2011 23:06:55 John Layt wrote: Not being too clued up on how we would hook this all up (Solid I guess?) solid seems the wrong place to me as that is about hardware awareness (networking, powermanagement, hotplug; those types of things) what i'd suggest is coding it up

Re: 4.7 mergable into frameworks. No need to cherry-pick

2011-08-26 Thread Aaron J. Seigo
On Friday, August 26, 2011 13:50:51 Michael Jansen wrote: That reminds me of my futile attempts to convince you guys of the need for a daily is everything merged check that sends its results (if stuff to merge is open) to kde-core-develop list. write it and show everyone how useful it is :)

Re: 4.7 mergable into frameworks. No need to cherry-pick

2011-08-26 Thread Stephen Kelly
Aaron J. Seigo wrote: On Friday, August 26, 2011 13:50:51 Michael Jansen wrote: That reminds me of my futile attempts to convince you guys of the need for a daily is everything merged check that sends its results (if stuff to merge is open) to kde-core-develop list. write it and show

Re: 4.7 mergable into frameworks. No need to cherry-pick

2011-08-26 Thread Michael Jansen
On Friday, August 26, 2011 03:14:26 PM Stephen Kelly wrote: Aaron J. Seigo wrote: On Friday, August 26, 2011 13:50:51 Michael Jansen wrote: That reminds me of my futile attempts to convince you guys of the need for a daily is everything merged check that sends its results (if stuff to

Re: Review Request: Fixed rating in knewstupp3.

2011-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102416/#review6032 --- This review has been submitted with commit

Re: -Wunused-but-set-variable warnings

2011-08-26 Thread David Faure
On Monday 04 July 2011 12:02:47 Dawit A wrote: The following files all contain set but unused variables: kdelibs/kdecore/io/kar.cpp:109:19: warning: variable ‘uid’ set but not used [-Wunused-but-set-variable] kdelibs/kdecore/io/kar.cpp:109:24: warning: variable ‘gid’ set but not used

Re: System clock change notification

2011-08-26 Thread Richard Moore
On Fri, Aug 26, 2011 at 1:40 PM, Aaron J. Seigo ase...@kde.org wrote: * QTimer; it's already a QObject and it would be nice to have support in there for such cases (as an option; not all timers want to be accurate to the actual time on the clock, but just time elapsed). that would also solve

Re: -Wunused-but-set-variable warnings

2011-08-26 Thread Dawit A
On Fri, Aug 26, 2011 at 11:25 AM, David Faure fa...@kde.org wrote: On Monday 04 July 2011 12:02:47 Dawit A wrote: The following files all contain set but unused variables: kdelibs/kdecore/io/kar.cpp:109:19: warning: variable ‘uid’ set but not used [-Wunused-but-set-variable]