Re: Review Request: Reset time format upon user request

2011-12-18 Thread Lamarque V. Souza
Em Sunday 18 December 2011, David Faure escreveu: > On Sunday 18 December 2011 12:51:25 Lamarque Vieira Souza wrote: > > Another problem with this approach is that we cannot prevent anybody else > > from listening to > > KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, > > KGlo

Re: Review Request: Reset time format upon user request

2011-12-18 Thread David Faure
On Sunday 18 December 2011 12:51:25 Lamarque Vieira Souza wrote: > Another problem with this approach is that we cannot prevent anybody else > from listening to > KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged, > KGlobalSettings::SETTING_LOCALE). What would be wrong with that

Re: Review Request: Improvements to create_tarball so it can properly package kio_gopher

2011-12-18 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6864/#review10581 --- That `mkdir #{app}` is actually a bug I did not notice. I just re

Re: Review Request: Reset time format upon user request

2011-12-18 Thread Lamarque Vieira Souza
> On Dec. 18, 2011, 8:59 a.m., David Faure wrote: > > SETTINGS_COMPLETION !? This has nothing to do with completion. How about > > adding a SETTINGS_LOCALE if that's what you need? I am trying to minimize the number of patches needed to fix bug #289094. This review is patch number two and a th

Re: Review Request: Reset time format upon user request

2011-12-18 Thread Lamarque Vieira Souza
> On Dec. 18, 2011, 8:33 a.m., Aaron J. Seigo wrote: > > plasma/generic/applets/digital-clock/clock.cpp, lines 100-102 > > > > > > this still realy ought to be done in klocale Well, we could add a KLocale::commit()

Re: Review Request: Rework kdebugdialog --fullmode ui

2011-12-18 Thread guy-kde
Hello! On Sun, 18 Dec 2011 09:01:58 -, "David Faure" wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103403/ [1] This patch replaces the area combobox in kdebugdialog --fullmode with a searchable tree widget. The patch is quite large

Re: Review Request: Rework kdebugdialog --fullmode ui

2011-12-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103403/#review9032 --- How does one simply enable/disable individual areas? Using the c

Re: Review Request: Reset time format upon user request

2011-12-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9031 --- SETTINGS_COMPLETION !? This has nothing to do with completion. H

Re: Review Request: Reset time format upon user request

2011-12-18 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9030 --- Ship it! i'm ok with this fix for now, but we need to look at m