Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-19 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103740/ --- Review request for KDE Base Apps and David Faure. Description --- If

Re: Review Request: Record job dbus id in dataengine to allow software to terminate a job through DBUS

2012-01-19 Thread Shaun Reich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103732/#review9952 --- hi, thanks for the patch. however, i'm not sure i understand th

Re: Review Request: Append ".desktop" to generated link files to prevent them from being identified as something else

2012-01-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103691/#review9951 --- This review has been submitted with commit bb1b0c92a5911bfa47ec

Re: hard-dep for Qt 4.8

2012-01-19 Thread Lamarque V. Souza
Em Thursday 19 January 2012, Giorgos Tsiapaliwkas escreveu: > On 19 January 2012 13:28, Lamarque V. Souza wrote: > > Strangely that Gentoo does not include an ebuild (package) for Qt 4.8. > > No,it does. You just have to add the qting-edge overlay. > > http://gitorious.org/gentoo-qt/qting-edge/t

Re: hard-dep for Qt 4.8

2012-01-19 Thread David Faure
On Wednesday 18 January 2012 10:26:13 Thomas Zander wrote: > On Wednesday 18 January 2012 10.11.58 todd rme wrote: > > But according to Martin, this isn't just about API changes, it is also > > about behavior changes. How do you expect people to know if they are > > relying on a Qt 4.8-specific be

Re: Review Request: Append ".desktop" to generated link files to prevent them from being identified as something else

2012-01-19 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103691/#review9944 --- Ship it! kfile/knewfilemenu.cpp

Re: hard-dep for Qt 4.8

2012-01-19 Thread Giorgos Tsiapaliwkas
On 19 January 2012 13:28, Lamarque V. Souza wrote: > Strangely that Gentoo does not include an ebuild (package) for Qt 4.8. No,it does. You just have to add the qting-edge overlay. http://gitorious.org/gentoo-qt/qting-edge/trees/master/x11-libs/qt-gui -- Giorgos Tsiapaliwkas (terietor) KDE Dev

Re: Review Request: Record job dbus id in dataengine to allow software to terminate a job through DBUS

2012-01-19 Thread Bellegarde Cédric
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103732/ --- (Updated Jan. 19, 2012, 7:55 a.m.) Review request for KDE Base Apps and kd

Review Request: Record job dbus id in dataengine to allow software to terminate a job through DBUS

2012-01-19 Thread Bellegarde Cédric
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103732/ --- Review request for KDE Base Apps and kdelibs. Description --- Record

Re: hard-dep for Qt 4.8

2012-01-19 Thread Lamarque V. Souza
Em Thursday 19 January 2012, Martin Gräßlin escreveu: > On Wednesday 18 January 2012 12:53:25 Dario Freddi wrote: > > Let's try to move the issue another way > > round: can we think of a way in which we can safely make master depend > > on new stuff without the risk of hurting these categories? >

Re: Re: hard-dep for Qt 4.8

2012-01-19 Thread Giorgos Tsiapaliwkas
1.I understand the point "Qt 4.8 has new feature and we need them." but I don't understand the point "Qt 4.8 is difficult to be installed". As Martin said some of the most popular distros have packages for Qt 4.8.(The same applies for gentoo). Also for the distros that don't have Qt 4.8(note that

Re: Re: hard-dep for Qt 4.8

2012-01-19 Thread Martin Gräßlin
On Thursday 19 January 2012 08:52:48 Thomas Zander wrote: > On Thursday 19 January 2012 08.15.39 Martin Gräßlin wrote: > > > As far as I know there are no forward incompatible behavior changes > > > between Qt4.7 and Qt 4.8> I.e. AFAIK programming for 4.8 using 4.7 APIs > > > but 4.8 behavior will