Re: hard-dep for Qt 4.8

2012-01-27 Thread Laszlo Papp
> To contribute to the actual question in this thread: I'd say let's support > both for now. And the responsibility is shared: developers should check for > "since 4.8" tags when looking at Qt api docs, and people using 4.7 to compile > kde must accept that they'll sometimes hit a breakage due to 4

Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103740/#review10155 --- This review has been submitted with commit 92385ff42503710f7b4

Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103740/#review10152 --- This review has been submitted with commit 349264ee404c8a6b3d4

Re: Review Request: removed misplaced line formatting control character in documentation

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103623/#review10137 --- This review has been submitted with commit 98d1d925237a212d83b

Re: Review Request: Fix KConfigIniBackend::isWritable() when the parent directory doesn't exist

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103577/#review10136 --- This review has been submitted with commit dec29afc01df5129049

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469/#review10141 --- This review has been submitted with commit 87756493f51716594c5

Re: Review Request: Do not show path info the Properties dialog edit box

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103594/#review10147 --- This review has been submitted with commit e8322e3fef98b02d3b8

Re: Review Request: Fïx two little bugs: one with default contrast settings and one with plasma popup alignment.

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103529/#review10144 --- This review has been submitted with commit a4123b08c0cad1c559e

Re: Review Request: KOpenWithDialog: Quote paths selected in the file dialog

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/#review10148 --- This review has been submitted with commit cfc52e240ae5a15f049

Re: Review Request: Append ".desktop" to generated link files to prevent them from being identified as something else

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103691/#review10142 --- This review has been submitted with commit 74bc2eeaa89f5c04946

Re: Review Request: Do not emit KEditToolBar::newToolBarConfig twice

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103579/#review10146 --- This review has been submitted with commit e7ee12fcb0719f1cdd5

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/#review10149 --- This review has been submitted with commit 73f5e4716fcb760b3a9

Re: Review Request: fix the rect passed to kcapacitybar paint method

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103669/#review10139 --- This review has been submitted with commit e073090e405437a7207

Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103617/#review10138 --- This review has been submitted with commit 29f3619a8049a18d29d