Re: Review Request: Fix readLongLink method

2012-02-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104062/#review10938 --- Ship it! Just like David with your previous request I don't ne

Re: Review Request: Test and add prefix value

2012-02-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104067/#review10939 --- kdecore/io/ktar.cpp

Re: Review Request: Test also the prefix value

2012-02-27 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104068/#review10940 --- Ship it! I still don't have the fine knowledge of tarball stru

Re: Review Request: KImageCache optimization

2012-02-27 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- (Updated Feb. 26, 2012, 6:46 p.m.) Review request for kdelibs, David Faure

Re: Review Request: kcontrol mouse coursor: better performance

2012-02-27 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104077/#review10918 --- With Qt 4.8, there is usually no difference between QImage and

Re: Review Request: KImageCache optimization

2012-02-27 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- (Updated Feb. 26, 2012, 8:08 p.m.) Review request for kdelibs, David Faure

Re: Review Request: KImageCache optimization

2012-02-27 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/#review10925 --- Overall I like the idea of taking a more direct role in KImageC

Re: Review Request: Test Global extended header

2012-02-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104065/#review10950 --- This review has been submitted with commit 262cf5920c9c0d9619d

Re: Review Request: Test and add prefix value

2012-02-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104067/#review10951 --- This review has been submitted with commit 762136bc525d84215bf

Re: Review Request: Test also the prefix value

2012-02-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104068/#review10952 --- This review has been submitted with commit 6e0d694b302b57883ed

Re: Review Request: Make ksmserver not wait for kcminit if compiled with mobile profile

2012-02-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104051/#review10972 --- This review has been submitted with commit 93fc655c1f749f4405d

Re: Review Request: Hacky workaround for https://bugs.kde.org/show_bug.cgi?id=228005

2012-02-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103593/#review10973 --- This review has been submitted with commit 82d5f2a118a9a40e18b

Re: Review Request: Hacky workaround for https://bugs.kde.org/show_bug.cgi?id=228005

2012-02-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103593/#review10974 --- This review has been submitted with commit ad188bfdb06af50448a

Re: Review Request: kjs: Allow keywords as object propertynames

2012-02-27 Thread Maksim Orlovich
Thanks for the patch. I don't think that this is a good approach. Spec-wise, what permits keywords to be used in a few spots is not just the production MemberExpression ::= MemberExpression . IdentifierName and likewise for CallExpression (where IdentifierName matches both our IdentifierOrKeyword