Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-20 Thread Kevin Ottens
> On March 18, 2012, 11:04 p.m., Stephen Kelly wrote: > > Nice, thanks and sorry for the noise, and thanks for making the branch. > > Dario Freddi wrote: > Np, hope you'll be able to have a quick look at it as well, it would be > great :) > > Stephen Kelly wrote: > Mostly it looks fine

Re: [GSoC] KWin colour management

2012-03-20 Thread Martin Graesslin
On Sunday 18 March 2012 20:01:01 Casian Andrei wrote: > Hello, taking it to the KWin mailinglist as that's the relevant list in case this proposal would be accepted. First of all thanks for considering doing a GSoC project around KWin. > I need your guidance in order to create a decent proposal.

Review Request: Set the parent widget in KIO::SlaveInterface::messageBox

2012-03-20 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104351/ --- Review request for kdelibs. Description --- This patch sets the top l

Re: [GSoC] KWin colour management

2012-03-20 Thread Thomas Lübking
Am 20.03.2012, 20:12 Uhr, schrieb Martin Graesslin : A fully color corrected compositor seems feasible to me I'm atm. not even sure about that. I might be utterly wrong, but my impression is that the xvidmode extension can correct screens (eg. xcalib loads icc profiles), so a screen wide

Re: Review Request: KJS: No longer treat invalid hex as string

2012-03-20 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/#review11663 --- This is consistent with the spec; but I am worried that in the

Re: Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr

2012-03-20 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104243/#review11664 --- Can I presume this change doesn't changer # of conflicts? kj

Re: Review Request: KJS: Correctly get begin, deleteCount for Splice

2012-03-20 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104104/#review11666 --- kjs/array_object.cpp

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-20 Thread Dario Freddi
> On March 18, 2012, 11:04 p.m., Stephen Kelly wrote: > > Nice, thanks and sorry for the noise, and thanks for making the branch. > > Dario Freddi wrote: > Np, hope you'll be able to have a quick look at it as well, it would be > great :) > > Stephen Kelly wrote: > Mostly it looks fine

Need suggestion on how to fix the common crash in plasma-desktop (kdelibs related)

2012-03-20 Thread Lamarque V. Souza
Hi, There is a crash in WeatherEngine (kde-workspace) triggered by the fact that Plasma::DataEngineManager::self() (kdelib) is invalid when plasma-{desktop,device} are exiting. WeatherEngine::~WeatherEngine() calls WeatherEngine::unloadIons(), which tries to use the invalid Pla

Re: Need suggestion on how to fix the common crash in plasma-desktop (kdelibs related)

2012-03-20 Thread Thomas Lübking
Tried to connect to QCoreApplication::aboutToQuit()? Am 21.03.2012, 02:31 Uhr, schrieb Lamarque V. Souza : Hi, There is a crash in WeatherEngine (kde-workspace) triggered by the fact that Plasma::DataEngineManager::self() (kdelib) is invalid when plasma-{desktop,device} are exi

Re: Need suggestion on how to fix the common crash in plasma-desktop (kdelibs related)

2012-03-20 Thread Lamarque V. Souza
Em Tuesday 20 March 2012, Thomas Lübking escreveu: > Tried to connect to QCoreApplication::aboutToQuit()? It is already done but that does not cover the case where WeatherEngine is unloaded without plasma-{desktop,device} exiting. The Ions must be unloaded in that case or we will have a