Re: QtScript considered dangerous

2012-05-24 Thread Dominik Haumann
Hi Milian, CC: kde-core-devel, as this is really a tough issue... there are other applications like Kile that heavily use QtScript for scripting as well, so porting away KatePart from QtScript may solve the issue for KDevelop, the real problem lies (as you say) within QtScript, not Kate. The

Re: QtScript considered dangerous

2012-05-24 Thread Thomas Friedrichsmeier
-- Note: Reposting to follow Dominik's example of CCing kde-core-devel -- Hi, On Wednesday 23 May 2012, Milian Wolff wrote: We have port Kate away from QtScript. I'm not sure, whether this is a serious suggestion, or just a way to catch attention. In the latter case: it worked. In the former

Re: Re: QtScript considered dangerous

2012-05-24 Thread Martin Gräßlin
On Wednesday, May 23, 2012 22:08:08 Milian Wolff wrote: We have port Kate away from QtScript. I want to remind that today is beta tagging for 4.9 and we are already in feature and dependency freeze. No matter how we turn it: switching the scripting engine cannot count as a bugfix and might

Re: Review Request: Plasma::RunnerManager: only dequeue our ThreadWeaver jobs

2012-05-24 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104973/ --- (Updated May 24, 2012, 9:50 a.m.) Review request for kdelibs and Plasma.

Re: QtScript considered dangerous

2012-05-24 Thread David Faure
On Thursday 24 May 2012 10:59:21 Dominik Haumann wrote: they said they will probably not spent the considerable amount of time in updating the archaic jsc checkout used in QtScript. What about the solution of updating the JSC in QtScript, and submitting that on codereview.qt-project.org? I.e.

Re: Review Request: Apper on kdereview

2012-05-24 Thread Matthias Klumpp
Hi! @Albert: Isn't this the line? https://projects.kde.org/projects/kdereview/apper/repository/revisions/master/entry/AppSetup/main.cpp#L44 (please tell me if there's something wrong ^^) @Burkhard: The files have been moved - but I think I copied the location scheme from another project, so this

Re: QtScript considered dangerous

2012-05-24 Thread Martin Sandsmark
On Thu, May 24, 2012 at 10:59:21AM +0200, Dominik Haumann wrote: Another question is: Maybe we'll have similar/other issues with kjs? ;) But KJS is maintained and has actual developers you can talk with (even on IRC!). Failing that, it is developed together with the rest of KDE, so you can even

Re: QtScript considered dangerous

2012-05-24 Thread Martin Sandsmark
On Thu, May 24, 2012 at 11:28:41AM +0200, Thomas Friedrichsmeier wrote: 1. AFAIR, there are some subtle differences between KJS and QtScript. I'd be hard pressed to provide an example, but I know for sure that I have run into some, personally. Some code that worked fine in QtScript did not

Re: Review Request: Do not restore previously empty location bar URL

2012-05-24 Thread Dawit Alemayehu
On May 23, 2012, 12:36 p.m., David Faure wrote: I'm ok with the change, but it seems this area is still buggy in any case... the location bar must be restored to the URL of the content currently displayed doesn't work here, e.g. when typing ~/foo.exe (yes a windows executable,

Re: Review Request: Apper on kdereview

2012-05-24 Thread Burkhard Lück
Am Donnerstag, 24. Mai 2012, 17:07:20 schrieb Matthias Klumpp: Hi! @Albert: Isn't this the line? https://projects.kde.org/projects/kdereview/apper/repository/revisions/mast er/entry/AppSetup/main.cpp#L44 (please tell me if there's something wrong ^^) Afaik the insertCatalog() call is done

Re: Review Request: Do not restore previously empty location bar URL

2012-05-24 Thread David Faure
On May 23, 2012, 12:36 p.m., David Faure wrote: I'm ok with the change, but it seems this area is still buggy in any case... the location bar must be restored to the URL of the content currently displayed doesn't work here, e.g. when typing ~/foo.exe (yes a windows executable,

Re: Review Request: Do not restore previously empty location bar URL

2012-05-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104982/#review14135 --- This review has been submitted with commit

Re: Review Request: Remove additional directories from shortcuts scheme export path

2012-05-24 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104981/#review14140 --- Ping? - Burkhard Lück On May 18, 2012, 7:11 a.m., Burkhard

Re: Review Request: Apper on kdereview

2012-05-24 Thread Matthias Klumpp
Hi! 2012/5/24 Burkhard Lück lu...@hube-lueck.de: Am Donnerstag, 24. Mai 2012, 17:07:20 schrieb Matthias Klumpp: Hi! @Albert: Isn't this the line? https://projects.kde.org/projects/kdereview/apper/repository/revisions/mast er/entry/AppSetup/main.cpp#L44 (please tell me if there's something

Re: Review Request: Remove additional directories from shortcuts scheme export path

2012-05-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104981/ --- (Updated May 24, 2012, 10:01 p.m.) Review request for kdelibs and Andreas

Re: Review Request: QSslConfiguration set/get functions for KTcpSocket

2012-05-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104958/ --- (Updated May 24, 2012, 10:52 p.m.) Review request for kdelibs and Thiago

Re: Review Request: Remove additional directories from shortcuts scheme export path

2012-05-24 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104981/#review14150 --- Ship it! In response to the ping, I like the concept of the