Re: Review Request: kjs: Implement JSON.parse

2012-07-04 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review15397 --- No functional review, just reading through the code. kjs/json

Re: Review Request: kjs: Implement JSON.stringify

2012-07-04 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105057/ --- (Updated July 4, 2012, 10:27 p.m.) Review request for kdelibs. Changes -

Re: Review Request: kjs: Implement JSON.parse

2012-07-04 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated July 4, 2012, 10:27 p.m.) Review request for kdelibs. Changes -

Re: Review Request: kjs: Implement JSON.stringify

2012-07-04 Thread Bernd Buschinski
> On July 4, 2012, 2:30 p.m., Maks Orlovich wrote: > > kjs/jsonstringify.cpp, line 69 > > > > > > Does this do the right thing if it's shorter than 10? yes, it does > On July 4, 2012, 2:30 p.m., Maks Orlovich wrot

Re: Review Request: kjs: Use toPrimitive in Array.join to get the correct String

2012-07-04 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105391/ --- (Updated July 4, 2012, 10:27 p.m.) Review request for kdelibs. Changes -

Re: Review Request: kjs: Implement JSON.parse

2012-07-04 Thread Bernd Buschinski
> On July 4, 2012, 2:24 p.m., Maks Orlovich wrote: > > kjs/jsonlexer.cpp, line 198 > > > > > > I don't think this is needed anymore. If we got called from JSONArray-TokLBrace we did not create an object. In more d

Re: Review Request: kjs: Implement JSON.stringify

2012-07-04 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105057/#review15376 --- kjs/jsonstringify.cpp

Re: Review Request: kjs: Implement JSON.stringify

2012-07-04 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105057/#review14245 --- kjs/jsonstringify.h

Re: Review Request: kjs: Implement JSON.parse

2012-07-04 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review15374 --- kjs/json_object.cpp

Re: Review Request: kjs: Use toPrimitive in Array.join to get the correct String

2012-07-04 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105391/#review15371 --- kjs/array_object.cpp

Re: Review request: moving libkgoogle to extragear

2012-07-04 Thread Laszlo Papp
> I'm reopening this thread again as I think (and ask you to correct me if not) > the library now meets all the requirements to be moved to extragear. IMO, just go ahead, move to extragear! You had fixed the issues requested more than one month ago (very swiftly) without any further complains. B

Re: Review request: moving libkgoogle to extragear

2012-07-04 Thread Dan Vratil
On Saturday 26 of May 2012 00:47:04 Dan Vratil wrote: > Hi, > > LibKGoogle is a new optional dependency of kdepim-runtime. It's used by the > new Akonadi Google resources. > > It's now in kdereview [0] and I'd like to move it to extragear, so I'm > asking for a review on the library. Hi, I'm re

Re: Using userbase for manuals

2012-07-04 Thread Chusslove Illich
>> [: Aurélien Gâteau :] >> I know at least one wiki which is git-based: [...] > > [: Ingo Malchow :] > [...] > Additionally we will loose support for quite some plugins, most notably > the translate extension, which is integral part of this entire discussion. > So we would be back at manually copy