Review Request: Fix finding the QtMimeTypes headers when compiling frameworks individually

2012-08-04 Thread George Goldberg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105862/ --- Review request for kdelibs and David Faure. Description --- I hope th

Review Request: Make kcodecs framework build standalone

2012-08-04 Thread George Goldberg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105860/ --- Review request for kdelibs and David Faure. Description --- Make it p

Re: RFC: Moving KWallet Password dialog into Plasma

2012-08-04 Thread Valentin Rusu
On 07/24/2012 02:20 PM, Aurélien Gâteau wrote: Le vendredi 20 juillet 2012 17:58:04 Martin Gräßlin a écrit : Providing a password safe and asking for the master password is also a "system" service and should belong into the workspace. So here my idea: let's move the password dialog into the des

Re: Review Request: KWallet Password Prompt Dialog In Your Face

2012-08-04 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105628/ --- (Updated Aug. 4, 2012, 12:35 p.m.) Review request for KDE Runtime, David F

Re: playground/games/picmi moved to KDE Review

2012-08-04 Thread Jakob Gruber
On 08/04/2012 10:02 AM, Laszlo Papp wrote: >> It *should* work logically and correctly until a new refactor, thus I >> cannot buy this argument, I am afraid. This is a few-liner change to >> make this operation right... > > Just to clarify, this statement means that you either support the old > kd

Re: playground/games/picmi moved to KDE Review

2012-08-04 Thread Laszlo Papp
> It *should* work logically and correctly until a new refactor, thus I > cannot buy this argument, I am afraid. This is a few-liner change to > make this operation right... Just to clarify, this statement means that you either support the old kde games library properly, or you do not support at a

Re: playground/games/picmi moved to KDE Review

2012-08-04 Thread Laszlo Papp
> Support for the old libkdegames will be removed soon, making both of the > points below nonissues. I already stated as much in both my original > mail and on 07/25. It *should* work logically and correctly until a new refactor, thus I cannot buy this argument, I am afraid. This is a few-liner ch

Re: playground/games/picmi moved to KDE Review

2012-08-04 Thread Jakob Gruber
On 08/04/2012 09:24 AM, Laszlo Papp wrote: >> Are there any objections or requested changes before Picmi can proceed >> to kdegames? > > Yes, you have ignored my comments for more than a week with a > cross-platform issue, and not just on Windows. Support for the old libkdegames will be removed s

Re: playground/games/picmi moved to KDE Review

2012-08-04 Thread Laszlo Papp
> Could somebody please point out the next steps to take? As for information about the procedure, you can find all the necessary information here: http://techbase.kde.org/Policies/Application_Lifecycle#Stage_2:_Stable Best Regards, Laszlo Papp

Re: playground/games/picmi moved to KDE Review

2012-08-04 Thread Laszlo Papp
> Are there any objections or requested changes before Picmi can proceed > to kdegames? Yes, you have ignored my comments for more than a week with a cross-platform issue, and not just on Windows. Here is what I wrote earlier: 1) The current double check is in wrong order unless you have fixed t