Review Request: Set noMerge=1 for menus when saving the xml file in kedittoolbar

2012-09-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106535/ --- Review request for kdelibs and David Faure. Description --- As discus

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-09-22 Thread Frederik Gladhorn
Hello Frank, On Sunday 23. September 2012 00.10.38 Frank Reininghaus wrote: > Hi everyone, > > 2012/9/22 Frederik Gladhorn: > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/105972/ > > > > Ship it! > > in my opinion, the "Ship It!" button shou

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-09-22 Thread Frank Reininghaus
Hi everyone, 2012/9/22 Frederik Gladhorn: > > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105972/ > > Ship it! in my opinion, the "Ship It!" button should be pressed only by the maintainer or another core developer of the application. I have cle

Re: Review Request: Ability to select which screen savers are used for "Random"

2012-09-22 Thread Jonathan Marten
> On Sept. 22, 2012, 9:28 a.m., Oswald Buddenhagen wrote: > > this UI is completely opaque to the user and thus not acceptable. > > you have two options: > > - add a proper header to the tree and put the checkboxes into a separate > > column "allow in 'random'". the list's double function is sti

Re: Review Request: Ability to select which screen savers are used for "Random"

2012-09-22 Thread Thomas Lübking
> On Sept. 22, 2012, 9:28 a.m., Oswald Buddenhagen wrote: > > this UI is completely opaque to the user and thus not acceptable. > > you have two options: > > - add a proper header to the tree and put the checkboxes into a separate > > column "allow in 'random'". the list's double function is sti

Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets

2012-09-22 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review19320 --- Ship it! We just discussed and Aman will push the change now.

Re: Review Request: Ability to select which screen savers are used for "Random"

2012-09-22 Thread Jonathan Marten
> On Sept. 22, 2012, 9:28 a.m., Oswald Buddenhagen wrote: > > this UI is completely opaque to the user and thus not acceptable. > > you have two options: > > - add a proper header to the tree and put the checkboxes into a separate > > column "allow in 'random'". the list's double function is sti

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-22 Thread Thomas Lübking
> On Sept. 8, 2012, 12:11 p.m., Oswald Buddenhagen wrote: > > ksmserver/screenlocker/DESIGN, line 13 > > > > > > "xembe[]ds" > > > > this sounds funny. the saver window is on top of the greeter? > > Marco M

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-22 Thread Marco Martin
> On Sept. 22, 2012, 9:46 a.m., Oswald Buddenhagen wrote: > > how do you plan to merge this? the history is rather messy, discarding and > > later re-introducing a lot of code, which makes tracking its origin very > > hard. therefore i'd advocate a squash merge. but then the commit should be >

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-22 Thread Marco Martin
> On Sept. 8, 2012, 12:11 p.m., Oswald Buddenhagen wrote: > > ksmserver/screenlocker/DESIGN, line 13 > > > > > > "xembe[]ds" > > > > this sounds funny. the saver window is on top of the greeter? > > Marco M

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-22 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106124/#review19290 --- how do you plan to merge this? the history is rather messy, dis

Re: Review Request: Use a qml based screen locker in place of the screensaver

2012-09-22 Thread Oswald Buddenhagen
> On Sept. 8, 2012, 12:11 p.m., Oswald Buddenhagen wrote: > > ksmserver/screenlocker/DESIGN, line 13 > > > > > > "xembe[]ds" > > > > this sounds funny. the saver window is on top of the greeter? > > Marco M

Re: Review Request: Ability to select which screen savers are used for "Random"

2012-09-22 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106524/#review19288 --- this UI is completely opaque to the user and thus not acceptabl