Re: Review Request: Show mtp devices in kfileplacesview

2012-09-30 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106657/#review19671 --- kfile/kfileplacesitem.cpp

Re: Review Request: Use product as text for pluggable/removable devices

2012-09-30 Thread Kevin Ottens
> On Sept. 30, 2012, 12:23 a.m., Alex Fiestas wrote: > > I decided to make a review because I wonder why we were using description > > before, was it working better with HAL? Nope, but the HAL backend itself used to have a very similar piece of code. It's probably a better idea to have that co

Re: Review Request: Avoid creating an empty .tbcache for bookmarks

2012-09-30 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106563/ --- (Updated Sept. 30, 2012, 8:47 p.m.) Review request for kdelibs and David F

Re: Review Request: Part II: cookie configuration dialog to support the accept cookie for session option

2012-09-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106619/#review19660 --- This review has been submitted with commit 930e19b9a7244b45b9f

Re: Review Request: Part I: Add domain/cookie specific 'accept cookie for session' option to kcookiejar

2012-09-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106618/#review19658 --- This review has been submitted with commit ef269fdee3311335477

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-09-30 Thread Laszlo Papp
> Objections ? None from Harmattan side either. I have already updated [1] the cmake version to 2.8.9 previously due to the frameworks experiment. :-) Thank you for bringing this topic up. Laszlo http://lpapp.blogspot.ie/2012/09/randa-kde-frameworks-build-experiment.html

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-09-30 Thread Modestas Vainius
Hello, Saturday 29 September 2012 14:51:30 rašė: > On Saturday 29 September 2012 13:47:16 Thomas Lübking wrote: > > Am 29.09.2012, 13:19 Uhr, schrieb Alexander Neundorf : > > > Do you mean they ship cmake 2.8.9 rc1 ? > > > > Seems so. > > http://packages.debian.org/search?keywords=cmake&searchon=n

Re: Review Request: Part II: cookie configuration dialog to support the accept cookie for session option

2012-09-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106619/#review19625 --- Ship it! konqueror/settings/kio/kcookiespolicies.cpp

Re: Review Request: Part I: Add domain/cookie specific 'accept cookie for session' option to kcookiejar

2012-09-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106618/#review19622 --- Ship it! Looks good. Just a few minor C++ things to fix before

Re: Review Request: Make KFileDialog remember settings

2012-09-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/#review19620 --- Looks good to me (feel free to commit if nobody else has commen

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-09-30 Thread Alexander Neundorf
On Sunday 30 September 2012, you wrote: > Hello, > > Saturday 29 September 2012 14:51:30 rašė: > > On Saturday 29 September 2012 13:47:16 Thomas Lübking wrote: > > > Am 29.09.2012, 13:19 Uhr, schrieb Alexander Neundorf : > > > > Do you mean they ship cmake 2.8.9 rc1 ? > > > > > > Seems so. > > >

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-09-30 Thread Alexander Neundorf
On Saturday 29 September 2012, Michael Pyne wrote: > On Saturday, September 29, 2012 12:12:43 André Wöbbeking wrote: > > On Saturday 29 September 2012 11:59:04 Rolf Eike Beer wrote: > > > Am Samstag 29 September 2012, 11:48:16 schrieb André Wöbbeking: > > > > Hi Alex, > > > > > > > > On Saturday 2

Re: Requiring cmake 2.8.9 for kdelibs 4.10 ?

2012-09-30 Thread Alexander Neundorf
On Saturday 29 September 2012, Stephen Kelly wrote: > Alexander Neundorf wrote: > > To make it short, when upgrading CMake, and causing some pain by this, > > I'd like to have the maximum outcome of it, i.e. the most recent version > > possible. > > To meet that goal, I would suggest bumping to CM

Review Request: Show mtp devices in kfileplacesview

2012-09-30 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106657/ --- Review request for kdelibs and Kevin Ottens. Description --- Show mtp

Re: Review Request: Use product as text for pluggable/removable devices

2012-09-30 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106653/#review19613 --- I decided to make a review because I wonder why we were using d

Review Request: Use product as text for pluggable/removable devices

2012-09-30 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106653/ --- Review request for kdelibs and Kevin Ottens. Description --- The desc