Re: kde-runtime module master and KDE/4.9 branches

2012-10-09 Thread Laszlo Papp
On Tue, Oct 9, 2012 at 7:54 PM, Laszlo Papp wrote: > I think David took the responsibility for the merge: > http://lists.kde.org/?l=kde-release-team&m=134510779413123&w=4 Oh, that was mentioned for kdelibs, and not kde-runtime. Can someone do that for kde-runtime as well? Laszlo

Re: kde-runtime module master and KDE/4.9 branches

2012-10-09 Thread Laszlo Papp
I think David took the responsibility for the merge: http://lists.kde.org/?l=kde-release-team&m=134510779413123&w=4 Laszlo On Tue, Oct 9, 2012 at 3:36 PM, Aleix Pol wrote: > Hi, > I'm sending this e-mail because I was experiencing some bug with the > ScrollBar and I thought about fixing it. Then

kde-runtime module master and KDE/4.9 branches

2012-10-09 Thread Aleix Pol
Hi, I'm sending this e-mail because I was experiencing some bug with the ScrollBar and I thought about fixing it. Then I decided to commit it in KDE/4.9 because it's a bugfix and I realised it's already in 4.9, it's just not in master. My natural reaction was to see if we could merge KDE/4.9 to ma

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-09 Thread Albert Astals Cid
El Dilluns, 8 d'octubre de 2012, a les 22:40:55, Albert Astals Cid va escriure: > Hi fellow kde-core-develers, i was thinking that from time to time someone > commits some code that breaks the building of the tests. > > This happens because people is not aware that those parts are unit tested. >

Re: Review Request: Device notifier: show mounted device and path

2012-10-09 Thread Jonathan Marten
> On Oct. 8, 2012, 9:52 a.m., Aaron J. Seigo wrote: > > any application which expects the user to access files on disk but does not > > provide a clear representation of mounted / removable devices is broken. > > there's no point in degrading our own primary UI for such fixable > > brokenness.

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-09 Thread alpine . art . de
> Actually I've always been unsure why packagers don't run unit tests... > Maybe this would help. Because sometimes tests require certain "features" of the environment when building (read: running the test), like running X or network, which will make the whole build fail if not present.

Re: Review Request: Make sure KPropertiesDialog inherits the 'Categories' property when creating a new desktop file from an existing one

2012-10-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106771/#review20113 --- This is a never-ending issue. Initially, local desktop files we

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review20112 --- Ship it! Ship It! - David Faure On Oct. 8, 2012, 5:43 p.m.,

Re: Review Request: Fix Konqueror's MMB click to close tab option

2012-10-09 Thread David Faure
> On Sept. 29, 2012, 6:48 a.m., David Faure wrote: > > Doesn't this break "moving a tab with MMB" then? The KTabBar > > mousePress/mouseRelease code won't be called anymore. > > > > If this is the case, then what we really have is two incompatible > > features... so we could just remove the "m

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-09 Thread Laszlo Papp
> Because the tests are broken in certain environments (just like last > time on Harmattan with the frameworks branch) and due to the lack of > time on the packagers' side to fix upstream bugs, they choose the > simpler way as a temporary workaround. Therefore, they can proceed > with the project,

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review20110 --- konqueror/src/konqsessionmanager.cpp

Re: Review Request: Check if the startDir has an schema before discarting it

2012-10-09 Thread Jonathan Marten
> On Oct. 4, 2012, 4:28 p.m., Christoph Feck wrote: > > Causes a regression. When using "Save Image As..." in Konqueror, the file > > dialog starts at "Custom Path" (and lists root folder), without remembering > > the previously used path. Doing the test as follows appears to work, for both lo

Re: RFC: Enabling -DKDE4_BUILD_TESTS=ON by default

2012-10-09 Thread Laszlo Papp
> +1 for always building unit tests! > Actually I've always been unsure why packagers don't run unit tests... > Maybe this would help. Because the tests are broken in certain environments (just like last time on Harmattan with the frameworks branch) and due to the lack of time on the packagers' si