Re: Review Request: Add Configure Desktop Search button (to open Nepomuk KCM) into Nepomukcontroller Statuswidget

2012-10-10 Thread Kai Uwe Broulik
> On July 11, 2012, 8:35 a.m., Vishesh Handa wrote: > > Ping? > > > > Could you please update this for Nepomuk2, and then commit to master? If I find time for this, I will do a new patch, before feature freeze :) Sorry about that. - Kai Uwe -

Re: Review Request: Start the notification service if it is dbus autostartable and we are not in a full kde session

2012-10-10 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106780/#review20172 --- Ship it! Ship It! - Sune Vuorela On Oct. 10, 2012, 1:20 p.m

Re: Review Request: Allow usage of detailedsorry and detailederror in kdialog

2012-10-10 Thread Kai Uwe Broulik
> On July 12, 2012, 4:17 p.m., David Faure wrote: > > Looks good. For master only, though, given feature+message freeze in 4.9. Totally forgot to commit this :( Will do for master (4.10) once my ssh key for my new notebook got imported. - Kai Uwe

Re: Review Request: miscelaneous things for kdelibs/plasma

2012-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/#review20159 --- This review has been submitted with commit 168961c452d09c8d0c2

Re: Review Request: missing initializations in plasma

2012-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106781/#review20158 --- This review has been submitted with commit d14c7dd902486528f04

Re: Review Request: missing initializations in plasma

2012-10-10 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106781/#review20155 --- Ship it! Ship It! - Daker Pinheiro On Oct. 10, 2012, 3:42 p

Re: Review Request: missing initializations in plasma

2012-10-10 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106781/#review20154 --- Looks good. :-) - Daker Pinheiro On Oct. 10, 2012, 3:42 p.m

Re: Review Request: miscelaneous things for kdelibs/plasma

2012-10-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/#review20150 --- Ship it! Looks good to me. - David Edmundson On Oct. 10, 20

Re: Review Request: miscelaneous things for kdelibs/plasma

2012-10-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/#review20151 --- Ship it! Ship It! - Marco Martin On Oct. 10, 2012, 3:41 p.m

Re: Review Request: Fix whitespace related bugs when listing directories in kio_ftp

2012-10-10 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106636/ --- (Updated Oct. 10, 2012, 3:55 p.m.) Review request for kdelibs and David Fa

Re: Review Request: missing initializations in plasma

2012-10-10 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106781/ --- (Updated Oct. 10, 2012, 3:42 p.m.) Review request for kdelibs and Plasma.

Re: Review Request: miscelaneous things for kdelibs/plasma

2012-10-10 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/ --- (Updated Oct. 10, 2012, 3:41 p.m.) Review request for kdelibs and Plasma.

Re: Review Request: Fix Konqueror's MMB click to close tab option

2012-10-10 Thread Dawit Alemayehu
> On Sept. 29, 2012, 6:48 a.m., David Faure wrote: > > Doesn't this break "moving a tab with MMB" then? The KTabBar > > mousePress/mouseRelease code won't be called anymore. > > > > If this is the case, then what we really have is two incompatible > > features... so we could just remove the "m

Review Request: miscelaneous things

2012-10-10 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106782/ --- Review request for kdelibs. Description --- 1. change order between s

Review Request: missing initializations in plasma

2012-10-10 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106781/ --- Review request for kdelibs. Description --- some missing initializati

Review Request: Start the notification service if it is dbus autostartable and we are not in a full kde session

2012-10-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106780/ --- Review request for KDE Runtime. Description --- This makes the notifi

Re: kde-runtime module master and KDE/4.9 branches

2012-10-10 Thread Laszlo Papp
> Hm, as kde-runtime is not frozen in master, whoever does fixes in 4.9 should > merge them to master. Unfortunately, there may always be changes missing. Unsure how much it can be automated, but I have the impression we do not exactly know until a person is responsible for making sure. Laszlo

Re: kde-runtime module master and KDE/4.9 branches

2012-10-10 Thread Andras Mantia
On Tuesday, October 09, 2012 07:56:48 PM Laszlo Papp wrote: > On Tue, Oct 9, 2012 at 7:54 PM, Laszlo Papp wrote: > > I think David took the responsibility for the merge: > > http://lists.kde.org/?l=kde-release-team&m=134510779413123&w=4 > > Oh, that was mentioned for kdelibs, and not kde-runtime.