Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-15 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/ --- (Updated Oct. 15, 2012, 10:15 p.m.) Review request for kdelibs and David F

Re: Review Request: Do not copy or move keys that don't actually exist

2012-10-15 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106906/#review20438 --- This review has been submitted with commit a3f8609d49e0c0d09c0

Re: Review Request: Do not copy or move keys that don't actually exist

2012-10-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106906/#review20435 --- Ship it! Ship It! - David Faure On Oct. 15, 2012, 9:35 p.m.

Review Request: Do not copy or move keys that don't actually exist

2012-10-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106906/ --- Review request for kdelibs and David Faure. Description --- When runn

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-15 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/ --- (Updated Oct. 15, 2012, 7:52 p.m.) Review request for kdelibs and David Fa

Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-15 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/ --- Review request for kdelibs and David Faure. Description --- Check the

Re: Review LibKdeAccessibilityClient

2012-10-15 Thread Frederik Gladhorn
Søndag 7. oktober 2012 21.45.17 skrev Alexander Neundorf: > On Thursday 04 October 2012, Frederik Gladhorn wrote: > > Hi, > > > > so after we took the time to hack a bit more on the library in Randa, > > I would be happy about more comments. > > Why does it use KDEPIMLIBS_INSTALL_DIR ? > > macro

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-15 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106861/ --- (Updated Oct. 15, 2012, 12:24 p.m.) Review request for kdelibs. Changes

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

2012-10-15 Thread Rex Dieter
> On Oct. 15, 2012, 6:19 a.m., Rolf Eike Beer wrote: > > cmake/modules/FindSamba.cmake, line 20 > > > > > > Why the if? If there is no pkgconfig found it the macro will just do > > nothing. And pkgconfig could even