Re: Comparing KFileItems

Hi David, I see that I should probably have created a review request to make review easier for you - sorry about that! But I think we're getting closer to the final solution, so I'll just reply to your message with a new patch. 2012/10/23 David Faure: > On Monday 22 October 2012 20:10:23 Frank Re

Re: Review Request: Add pkgconfig hints to FindSamba.cmake

Alexander Neundorf writes: > On Monday 22 October 2012, Rex Dieter wrote: >> > On Oct. 21, 2012, 9:27 a.m., Raphael Kubo da Costa wrote: >> > > cmake/modules/FindSamba.cmake, line 23 >> > > > > > ne23> >> > > >> > > Plea

Review Request: KMainWindow: fix position support in --geometry option

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/ --- Review request for kdelibs. Description --- KDE applications support

Re: Comparing KFileItems

On Wednesday 24 October 2012 10:47:46 Frank Reininghaus wrote: > Hi David, > > I see that I should probably have created a review request to make > review easier for you - sorry about that! But I think we're getting > closer to the final solution, so I'll just reply to your message with > a new pa

Re: Review Request: KMainWindow: fix position support in --geometry option

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/#review20799 --- Ship it! works for me :) - Milian Wolff On Oct. 24, 2012, 3

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107017/ --- (Updated Oct. 24, 2012, 10:50 a.m.) Review request for kdelibs and Plasma.

Fwd: Re: Review Request: Possibility to change an element ID of svg image in IconWidget

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107017/ Review request for kdelibs and Plasma. By Dmitry Ashkadov. /Updated Oct. 24, 2012, 10:50 a.m./ Description New System tray uses IconWidget QML item, but it isn't possible to set svg ima

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107017/ --- (Updated Oct. 24, 2012, 1:02 p.m.) Review request for kdelibs and Plasma.

Re: Review Request: KMainWindow: fix position support in --geometry option

> On Oct. 24, 2012, 4:26 p.m., Milian Wolff wrote: > > works for me :) Any other comments? And into what branch am I supposed to commit? KDE/4.9 and master? - Dominik --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: KMainWindow: fix position support in --geometry option

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/#review20809 --- kdeui/widgets/kmainwindow.cpp

Re: Review Request: KMainWindow: fix position support in --geometry option

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/ --- (Updated Oct. 24, 2012, 5:56 p.m.) Review request for kdelibs. Changes -

Re: Review Request: KMainWindow: fix position support in --geometry option

> On Oct. 24, 2012, 5:48 p.m., Thomas Lübking wrote: > > kdeui/widgets/kmainwindow.cpp, line 456 > > > > > > why 0? > > if the value is omitted that likely means "dont care, place regularily" > > - doesn't? Tr

Re: Review Request: KMainWindow: fix position support in --geometry option

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/#review20816 --- Ship it! With v2, the patch is simlpy a logic inversion to now

Re: Review Request: KMainWindow: fix position support in --geometry option

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/#review20817 --- Are you sure it fixes bug 165355 ? That bug tracks the issue ab

kdereview: bodega

hi :) (x-posting between core-devel and -devel as this is (hopefully) of general interest and because we also are supposed to announce new kdereview modules.) So ... what is this "Bodega" thing I speak of? Bodega is a way to publish and get at content. That could be books, wallpapers, applicat

Re: Review Request: KMainWindow: fix position support in --geometry option

> On Oct. 24, 2012, 7:38 p.m., Christoph Feck wrote: > > Are you sure it fixes bug 165355 ? That bug tracks the issue about > > KUniqueApplication (Konsole, etc.) not passing the mentioned arguments to > > the spawned process. To clarify: I don't object to have this committed, but unless you c

Re: kdereview: bodega

Hi, Aaron J. Seigo wrote: > Bodega I hope you are aware about the meaning of the name in certain countries. :) In Spain it is winery, while in Romania and probably some parts of Hungary it is the name of the cheap drinking places especially in little villages where people go for only one thin

Re: kdereview: bodega

On Onsdag den 24. oktober 2012 23:19:57 Andras Mantia wrote: > Hi, > > Aaron J. Seigo wrote: > > Bodega > > I hope you are aware about the meaning of the name in certain countries. :) > In Spain it is winery, while in Romania and probably some parts of Hungary > it is the name of the cheap drink

Re: Review Request: KMainWindow: fix position support in --geometry option

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/ --- (Updated Oct. 24, 2012, 9:27 p.m.) Review request for kdelibs. Changes -

Re: Review Request: KMainWindow: fix position support in --geometry option

> On Oct. 24, 2012, 7:38 p.m., Christoph Feck wrote: > > Are you sure it fixes bug 165355 ? That bug tracks the issue about > > KUniqueApplication (Konsole, etc.) not passing the mentioned arguments to > > the spawned process. > > Christoph Feck wrote: > To clarify: I don't object to have

Re: Review Request: KMainWindow: fix position support in --geometry option

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/#review20825 --- This review has been submitted with commit d5a0d33a249c52fde68

Re: Re: kdereview: bodega

On Wednesday 24 October 2012 23:19:57 Andras Mantia wrote: > Hi, > > Aaron J. Seigo wrote: > > Bodega > > I hope you are aware about the meaning of the name in certain countries. :) > In Spain it is winery, while in Romania and probably some parts of Hungary > it is the name of the cheap drinkin

Review Request: Cache icon and accessibility in KFilePlacesItem

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107030/ --- Review request for kdelibs. Description --- Similar to what Dolphin d

Re: kdereview: bodega

Wed, 24 Oct 2012 23:19:57 +0300 you wrote Andras Mantia : I hope you are aware about the meaning of the name in certain countries. :) In Spain it is winery, while in Romania and probably some parts of Hungary it is the name of the cheap drinking places especially in little villages where people

Re: Review Request: Cache icon and accessibility in KFilePlacesItem

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107030/#review20830 --- Let me understand, what you are proposing. If Solid is slow ret

Re: Review Request: Cache icon and accessibility in KFilePlacesItem

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107030/#review20831 --- Ship it! On a second look, I see no cluttering. - Christoph F

Review Request: Keep KService::createInstance error message in KServiceTypeTrader::createInstanceFromQuery

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107032/ --- Review request for kdelibs and David Faure. Description --- When KSer

Re: kdereview: bodega

Hello Aaron, :: Aaron J. Seigo Mittwoch 24 Oktober 2012 > * it is not limited to (or even focused on) software, but any digital > asset. I'd like to encourage you to go further and drop the restriction to "digital" assets eventually. Many people use their computer to buy or share real stuff onl

Re: kdereview: bodega

I love you guys. I love the idea of Bogeda. Thanks for making KDE so awesome! Steven Sroka (lin-unix) On 2012-10-24, at 8:10 PM, Josef Spillner wrote: > Hello Aaron, > > :: Aaron J. Seigo Mittwoch 24 Oktober 2012 >> * it is not limited to (or even focused on) software, but any digital >> ass

Re: kdereview: bodega

2012/10/24, Josef Spillner : > Hello Aaron, > > :: Aaron J. Seigo Mittwoch 24 Oktober 2012 >> * it is not limited to (or even focused on) software, but any digital >> asset. > > I'd like to encourage you to go further and drop the restriction to > "digital" > assets eventually. Many people use thei

Re: kdereview: bodega

Bring back the kde-devel ML. Please next time keep the cc Cheers, Antonis

Re: kdereview: bodega

On Wednesday, October 24, 2012 11:48:08 PM Alex Fiestas wrote: > On Wednesday 24 October 2012 23:19:57 Andras Mantia wrote: > > Hi, > > > > Aaron J. Seigo wrote: > > > Bodega > > > > I hope you are aware about the meaning of the name in certain countries. > > :) > > > > In Spain it is winery,