Re: Moving libkfacebook to extragear

2012-12-30 Thread Raymond Wooninck
Hi Martin, On Saturday 29 December 2012 01:25:43 Martin Klapetek wrote: > > I finally got around finishing d-pointerizing the whole library, it's all > in master now. Please review. > I made a small adjustment in the CMakeLists.txt files to have a correctly versioned shared library. I noticed

Looking for a BlueDevil legacy maintainer

2012-12-30 Thread Alex Fiestas
Hi there Today we have finished the release of BlueDevil 1.3, which should be the most stable ever (yay for everybody !). As you all probably know, I'm working in a variety of projects (kscreen, user manager, webaccounts, kamoso) meaning that I can dedicate less time to BlueDevil. Trying to be

Re: Moving libkfacebook to extragear

2012-12-30 Thread Albert Astals Cid
El Dissabte, 29 de desembre de 2012, a les 01:25:43, Martin Klapetek va escriure: > On Wed, Nov 7, 2012 at 8:11 PM, Albert Astals Cid wrote: > > > The data classes are finally done - all of them now use d-pointers and > > > > none > > > > > are qobject; I've added the qobject-parsers as Kevin s

Re: Moving libkfacebook to extragear

2012-12-30 Thread Martin Klapetek
On Sun, Dec 30, 2012 at 6:22 PM, Albert Astals Cid wrote: > You missed one place > > ./libkfbapi/CMakeLists.txt:99: ${CMAKE_BINARY_DIR}/config.h > Damn, I blame kdevelop's "find in files" :P Fixed, thanks. Cheers -- Martin Klapetek | KDE Developer

Re: Moving libkfacebook to extragear

2012-12-30 Thread Albert Astals Cid
El Diumenge, 30 de desembre de 2012, a les 17:50:42, Martin Klapetek va escriure: > On Sun, Dec 30, 2012 at 5:07 PM, Albert Astals Cid wrote: > > What's config.h.cmake used for? > > Looks like it was used for supporting kdepim_44_compat mode, which is now > discouraged and was removed from this

Re: Moving libkfacebook to extragear

2012-12-30 Thread Martin Klapetek
On Sun, Dec 30, 2012 at 5:07 PM, Albert Astals Cid wrote: > > What's config.h.cmake used for? > Looks like it was used for supporting kdepim_44_compat mode, which is now discouraged and was removed from this library recently. Therefore this file is no longer useful, so I removed it. Cheers --

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

2012-12-30 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated Dec. 30, 2012, 4:45 p.m.) Review request for kdelibs, kwin, Aaron

Re: Moving libkfacebook to extragear

2012-12-30 Thread Alexander Neundorf
On Sunday 30 December 2012, Albert Astals Cid wrote: > El Dissabte, 29 de desembre de 2012, a les 01:25:43, Martin Klapetek va > > escriure: > > On Wed, Nov 7, 2012 at 8:11 PM, Albert Astals Cid wrote: > > > > The data classes are finally done - all of them now use d-pointers > > > > and > > > >

Re: Moving libkfacebook to extragear

2012-12-30 Thread Albert Astals Cid
El Dissabte, 29 de desembre de 2012, a les 01:25:43, Martin Klapetek va escriure: > On Wed, Nov 7, 2012 at 8:11 PM, Albert Astals Cid wrote: > > > The data classes are finally done - all of them now use d-pointers and > > > > none > > > > > are qobject; I've added the qobject-parsers as Kevin s

Re: Review Request: Port kdelibs to feature_summary

2012-12-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108002/#review24269 --- This review has been submitted with commit 92b4a1ee45064e3781c

Re: Review Request: Port kdelibs to feature_summary

2012-12-30 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108002/#review24263 --- Ship it! Looks ok in general. If everything#s fine for you, go

Re: Review Request: Initialize datetime of tags in tags:// protocol

2012-12-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107910/#review24262 --- This review has been submitted with commit 868026b5205ee22ab75

Re: Review Request: Initialize datetime of tags in tags:// protocol

2012-12-30 Thread Vishesh Handa
> On Dec. 30, 2012, 1:23 p.m., Vishesh Handa wrote: > > I'm sorry. I seen to have not seen this. Please add the nepomuk group from > > next time. *seem to have not seen this - Vishesh --- This is an automatically generated e-mail. To r

Re: Review Request: Initialize datetime of tags in tags:// protocol

2012-12-30 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107910/#review24245 --- Ship it! I'm sorry. I seen to have not seen this. Please add t