Re: Review Request: qml based kwin shadow

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review25132 --- Ship it! the duplication tells me we should someday add a shar

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/ --- (Updated Jan. 10, 2013, 6:50 a.m.) Review request for kdelibs, kwin, Plasm

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/#review25123 --- the big question is whether the code has been like that for his

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/#review25110 --- Copied over from https://git.reviewboard.kde.org/r/108308/

Re: Review Request: fix isMinimized in KWindowInfo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108314/#review25109 --- There should be no problem with ths one since WMs are encourage

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

> On Jan. 9, 2013, 10:45 p.m., Thomas Lübking wrote: > > Random addendums: > > - state hidden is also provided by metacity, icewm, openbox and compiz > > - mappingState() is part of the public API, thus not cut off (if you > > actually want to know it) > > - not unmapping windows has more issues

Re: KDEREVIEW: Mangonel

On Wednesday 09 January 2013 09:07:13 PM Yuri Chornoivan wrote: > написане Wed, 09 Jan 2013 19:35:49 +0200, Martin Sandsmark > : > > > On Tuesday 08 January 2013 19:30:45 Allen Winter wrote: > >> No docbook manual > > I guess I'll to contact the doc team for this? > > If there is no "Help" butt

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

> On Jan. 9, 2013, 10:45 p.m., Thomas Lübking wrote: > > Random addendums: > > - state hidden is also provided by metacity, icewm, openbox and compiz > > - mappingState() is part of the public API, thus not cut off (if you > > actually want to know it) > > - not unmapping windows has more issues

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

> On Jan. 9, 2013, 10:45 p.m., Thomas Lübking wrote: > > Random addendums: > > - state hidden is also provided by metacity, icewm, openbox and compiz > > - mappingState() is part of the public API, thus not cut off (if you > > actually want to know it) > > - not unmapping windows has more issues

Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/ --- Review request for kdelibs, kwin and Aaron J. Seigo. Description ---

Re: KDEREVIEW: Mangonel

написане Wed, 09 Jan 2013 19:35:49 +0200, Martin Sandsmark : On Tuesday 08 January 2013 19:30:45 Allen Winter wrote: No docbook manual I guess I'll to contact the doc team for this? If there is no "Help" button and no desktop file, there is not much sense in making docbooks. I propose

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

> On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote: > > systemsettings/icons/IconMode.cpp, line 183 > > > > > > Not sure I like the idea of a hardcoded list of languages... is there a > > better way of determining

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

> On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote: > > systemsettings/icons/IconMode.cpp, line 183 > > > > > > Not sure I like the idea of a hardcoded list of languages... is there a > > better way of determining

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

> On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote: > > systemsettings/icons/IconMode.cpp, line 183 > > > > > > Not sure I like the idea of a hardcoded list of languages... is there a > > better way of determining

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108308/#review25103 --- Random addendums: - state hidden is also provided by metacity,

Re: KDEREVIEW: Mangonel

On Wednesday 09 January 2013 19:45:27 Martin Gräßlin wrote: > There is one mail already on the list, so it is already spread. Okay, so the proverbial cat's out of the bag I guess, so I just added his email to the license headers. -- Martin Sandsmark KDE

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

> On Jan. 9, 2013, 6:43 p.m., Albert Astals Cid wrote: > > To be honest i don't think this is the correct fix, the correct fix is > > specifying a minimum space between the items or a minimum size of the items > > themselves, not forcing the wordwrapping off itemsize (spacing would also increa

Re: KDEREVIEW: Mangonel

On Wednesday 09 January 2013 19:49:36 Albert Astals Cid wrote: > You should probably make it look like > i18nc("some context of what stuff is", "(%1)", application.type) > > Just in case someone needs to do something different with the parenthesis. Okay, fixed. Thanks :-) -- Martin Sandsmark K

Re: KDEREVIEW: Mangonel

El Dimecres, 9 de gener de 2013, a les 01:09:28, Martin Sandsmark va escriure: > Hi, thanks for the review! > > On Tuesday 08 January 2013 23:12:01 Albert Astals Cid wrote: > > Which is its intended destination extragear-something? > > Yes, sorry, I forgot to mention, it is destined for extragear

Re: Re: KDEREVIEW: Mangonel

On Wednesday 09 January 2013 18:35:49 Martin Sandsmark wrote: > On Tuesday 08 January 2013 19:30:45 Allen Winter wrote: > > No docbook manual > > I guess I'll to contact the doc team for this? > > > Do you want apidox generated? if so you also need a Mainpage.dox > > No need for that (yet, at le

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108285/#review25091 --- To be honest i don't think this is the correct fix, the correct

Re: Question about HTTP KIO Slave

El Dimarts, 8 de gener de 2013, a les 17:17:33, David Narvaez va escriure: > Reposting here in case someone has an idea: Allan answered you in kde-devel weeks ago. Cheers, Albert

Re: KDEREVIEW: Mangonel

On Tuesday 08 January 2013 19:30:45 Allen Winter wrote: > No docbook manual I guess I'll to contact the doc team for this? > Do you want apidox generated? if so you also need a Mainpage.dox No need for that (yet, at least, we might want to make it plugin-based in the future). > Bart's email

Re: KDEREVIEW: Mangonel

On Wednesday 09 January 2013 08:56:25 Jekyll Wu wrote: > If you plan to > use bugs.kde.org as the tracker, then you don't need to call > setBugAddress() at all. The default value just works. Fixed. > And don't forget to ask sysadmins to create a "mangonel" product on > bugs.kde.org :) Done.

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

> On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote: > > systemsettings/icons/IconMode.cpp, line 183 > > > > > > Not sure I like the idea of a hardcoded list of languages... is there a > > better way of determining

Re: Review Request: set brightness to zero in profile doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108230/#review25051 --- This review has been submitted with commit 55b759ab8b9f2d45e48

Re: Finalized proposal for changes to i18n in KF5

On Tue, Jan 08, 2013 at 03:05:25PM +0100, Chusslove Illich wrote: > >> [: Chusslove Illich :] > >> I'm not opposed to some additional bureaucracy in order to make the > >> framework more accessible to potential users. [...] > > > > [: Oswald Buddenhagen :] > > [...] i'd hate it to see my thoroughly

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108285/#review25038 --- Code itself looks okay, see issue below though. systemsetting

Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108285/ --- Review request for kde-workspace. Description --- CJK languages do no

Re: Review Request: Fix KWindowSystem::compositingChanged signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated Jan. 9, 2013, 2 a.m.) Review request for kdelibs, kwin, Plasma, A

Re: Review Request: Fix KWindowSystem::compositingChanged signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review25025 --- kdeui/windowmanagement/kwindowsystem_x11.cpp

Re: KDEREVIEW: Mangonel

On 2013年01月09日 08:09, Martin Sandsmark wrote: >Any reason not to use bugs.kde.org? Fixed. Hi, I see you made the change : -aboutData->setBugAddress(QByteArray("bugs.mango...@tarmack.eu")); +aboutData->setBugAddress(QByteArray("https://bugs.kde.org/";)); Hmm, that is not going to wo

Re: Review Request: Fix KWindowSystem::compositingChanged signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/ --- (Updated Jan. 9, 2013, 12:52 a.m.) Review request for kdelibs, kwin, Plasm

Re: Review Request: Fix KWindowSystem::compositingChanged signal

> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything to kwin), and I > > notice some

Re: Review Request: Fix KWindowSystem::compositingChanged signal

> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything to kwin), and I > > notice some

Re: Review Request: Fix KWindowSystem::compositingChanged signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review25012 --- after I apply the patch, I notice that in some random unknnow c

Re: Re: KDEREVIEW: Mangonel

Hello List, On Tuesday 08 January 2013 23:12:01 Albert Astals Cid wrote: > El Dimarts, 8 de gener de 2013, a les 21:08:11, Martin Sandsmark va escriure: > > Dear Sirs and Madams, > > > > Mangonel has just been moved to KDE Review. > > > > Mangonel is a simple and lightweight application launche

Question about HTTP KIO Slave

Reposting here in case someone has an idea: Hi all, I'm working on a fix for a bug we have in KGet, where some files are downloaded incomplete. I found that at least one of the reasons why this happens is because of the following use case. when KGet is set up as the download manager for Rekonq: