Re: Review Request 108471: return icon for helper type protocol

2013-01-20 Thread Reza Shah
On Jan. 19, 2013, 9:58 p.m., David Faure wrote: Makes sense. However I don't like the logic duplication, for future maintainance. Let's extract it. Can you test if this works for you? http://www.davidfaure.fr/2013/kprotocolinfo.diff I tried your diff, it worked for me. - Reza

Review Request 108504: [High-dpi issues] Fix KIconDialog

2013-01-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108504/ --- Review request for kdelibs and KDE Usability. Description --- This

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

2013-01-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108504/#review25834 --- kio/kfile/kicondialog.cpp

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

2013-01-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108504/ --- (Updated Jan. 20, 2013, 11:15 a.m.) Review request for kdelibs and KDE

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

2013-01-20 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108504/#review25844 --- kio/kfile/kicondialog.cpp

Re: Review Request 108504: [High-dpi issues] Fix KIconDialog

2013-01-20 Thread Thomas Lübking
On Jan. 20, 2013, 2:40 p.m., Thomas Lübking wrote: kio/kfile/kicondialog.cpp, line 141 http://git.reviewboard.kde.org/r/108504/diff/2/?file=108215#file108215line141 Would it for such static sizes (why 60px in the first place?) not be more correct to use sh. like

Re: Plans for SVN infrastructure shutdown

2013-01-20 Thread Luigi Toscano
Ben Cooksley wrote: On Sat, Jan 5, 2013 at 10:45 AM, Oswald Buddenhagen o...@kde.org wrote: On Wed, Jan 02, 2013 at 06:52:32PM -0300, Nicolás Alvarez wrote: http://community.kde.org/Sysadmin/SVNInfrastructureShutdown Hi Oswald, this whole thing ignores that svn is still simply the better

Re: Plans for SVN infrastructure shutdown

2013-01-20 Thread Luigi Toscano
Ben Cooksley wrote: On Sat, Jan 12, 2013 at 2:28 AM, Oliver Henshaw oliver.hens...@gmail.com wrote: On 4 January 2013 10:31, David Faure fa...@kde.org wrote: The plan seems OK, except for the very last step, final shutdown. Please keep svn.kde.org around, readonly. [...] so if we could just

Re: Plans for SVN infrastructure shutdown

2013-01-20 Thread Burkhard Lück
Am Mittwoch, 2. Januar 2013, 18:52:32 schrieb Nicolás Alvarez: The initial draft of the SVN shutdown plan is available on the community wiki: http://community.kde.org/Sysadmin/SVNInfrastructureShutdown http://community.kde.org/Sysadmin/SVNInfrastructureShutdown#Note says: The only exception

Re: Plans for SVN infrastructure shutdown

2013-01-20 Thread Albert Astals Cid
El Dilluns, 21 de gener de 2013, a les 11:53:04, Ben Cooksley va escriure: On Mon, Jan 21, 2013 at 9:09 AM, Luigi Toscano luigi.tosc...@tiscali.it wrote: Ben Cooksley wrote: On Sat, Jan 5, 2013 at 10:45 AM, Oswald Buddenhagen o...@kde.org wrote: On Wed, Jan 02, 2013 at 06:52:32PM -0300,