Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

2013-01-24 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108570/#review26127 --- I've added a bunch of comments inline, those would need

Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

2013-01-24 Thread Sandro Andrade
On Jan. 24, 2013, 10:15 a.m., Sebastian Kügler wrote: plasma/generic/applets/systemtray/ui/applet.cpp, line 111 http://git.reviewboard.kde.org/r/108570/diff/1/?file=109069#file109069line111 Where do the magic numbers come from? Try to avoid them, otherwise add a comment. These

Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

2013-01-24 Thread Sandro Andrade
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108570/ --- (Updated Jan. 24, 2013, 1:04 p.m.) Review request for kde-workspace.

Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

2013-01-24 Thread Sandro Andrade
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108570/ --- (Updated Jan. 24, 2013, 1:11 p.m.) Review request for kde-workspace.

Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

2013-01-24 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108570/#review26137 --- While usually we don't want to have visual elements hiding and

Re: Review Request 108570: This patch add support for bulk operations in systemtray applet settings.

2013-01-24 Thread Sandro Andrade
On Jan. 24, 2013, 1:29 p.m., Aaron J. Seigo wrote: While usually we don't want to have visual elements hiding and disappearing, in this case I wonder if it would make it more evident/obvious what the bottom items are for (and remove the visual clutter when they aren't needed). Yes,